1. 14 Dec, 2016 2 commits
  2. 12 Dec, 2016 1 commit
  3. 09 Dec, 2016 1 commit
  4. 06 Dec, 2016 3 commits
  5. 07 Aug, 2016 2 commits
    • Vincent Bernat's avatar
      errors: don't make GetLastError() segfault when on no error condition · 54483b92
      Vincent Bernat authored
      When calling `GetLastError()` twice in a row, we get a segfault because
      `virGetLastError()` C function returns nil. We cannot return nil since
      we don't return a pointer, but we can return a special error that means
      "no error".
      54483b92
    • Vincent Bernat's avatar
      connection: move ancillary data to a separate struct · 52ddaf1e
      Vincent Bernat authored
      To implement error callbacks (in #96), the current error callback ID was
      associated to the VirConnection structure on which the SetErrorFunc has
      been called. However, if a user receives a connection from an event,
      this connection won't have the right error callback ID.
      
      Therefore, storing additional information in the VirConnection structure
      seems a bit fragile. Either we should ensure that each connection is a
      single VirConnection structure or we should store the data elsewhere.
      
      This commit moves the data in a dedicated structure and a map is used to
      associated a virConnectPtr to the appropriate ancillary data. Therefore,
      for a connection, we have an unique C.virConnectPtr, zero or more
      VirConnection struct and one virConnectionData struct.
      
      The other solution (ensuring we have only one VirConnection struct for a
      given connection) seemed far more complex to handle as it's hard to
      avoid a copy by the user (we would have to force the user to only use
      pointers).
      52ddaf1e
  6. 27 Jul, 2016 1 commit
    • Vincent Bernat's avatar
      test: ensure we don't have any connection leak · e59e9ced
      Vincent Bernat authored
      If ConnectionClose() method doesn't return 0, this means we have either
      an error, either there is still a reference to the connection by another
      object (we don't have virConnectRef()). In all tests, check that return
      code and ensure this is 0. Fix tests that weren't releasing all objects
      correctly.
      e59e9ced
  7. 26 Jul, 2016 2 commits