1. 20 Feb, 2019 15 commits
  2. 14 Feb, 2019 3 commits
  3. 12 Feb, 2019 1 commit
  4. 12 Oct, 2018 6 commits
  5. 03 Oct, 2018 3 commits
    • Fabiano Fidêncio's avatar
      domain: Introduce gvir_config_domain_set_custom_xml_ns_children() · 52e58460
      Fabiano Fidêncio authored
      gvir_config_domain_set_custom_xml_ns_children() basically has the same
      functionallity as gvir_config_domain_set_custom_xml() but also sets the
      namespace to the nodes' children.
      Signed-off-by: 's avatarFabiano Fidêncio <fidencio@redhat.com>
      52e58460
    • Fabiano Fidêncio's avatar
      object: Also add the ns to the node's children · c87a39f9
      Fabiano Fidêncio authored
      With the current code, we can only create a custom XML that looks like:
      <metadata>
        <boxes:gnome-boxes xmlns:boxes="https://wiki.gnome.org/Apps/Boxes">
          <os-state>installed</os-state>
          <media-id>http://centos.org/centos/7.0:0</media-id>
          <media>/home/fidencio/Downloads/CentOS-7-x86_64-DVD-1804.iso</media>
        </boxes:gnome-boxes>
      </metadata>
      
      Although it works well for some use cases, there are use cases where
      we'd like to have something a bit more complex libosinfo or nova
      examples:
      <metadata>
        <libosinfo:libosinfo xmlns:libosinfo="http://libosinfo.org/xmlns/libvirt/domain/1.0">
          <libosinfo:os id="http://fedoraproject.org/fedora/17"/>
        </libosinfo:libosinfo>
        <nova:instance xmlns:nova="http://openstack.org/nova/instance/1">
          <nova:flavor name="m1.small">
            <nova:memory>512</nova:memory>
            <nova:disk>10</nova:disk>
          </nova:flavor>
        </nova:instance>
      </metadata>
      
      And for the latter case we'd have to go through the node's children and
      also set the namespace for each children.
      Signed-off-by: 's avatarFabiano Fidêncio <fidencio@redhat.com>
      c87a39f9
    • Fabiano Fidêncio's avatar
      gconfig, gobject: Use G_DEFINE_ABSTRACT_TYPE_WITH_PRIVATE · 2d3ee844
      Fabiano Fidêncio authored
      Commit 7190c502 introduced the usage of new GObject define macros with
      private. However as the conversion hasn't been done for abstract types
      (G_DEFINE_ABSTRACT_TYPE) and the addition of the private classes for the
      abstract types has been removed as part of the commit, crashes can be
      seen in Apps consuming libvirt-glib, as this one from GNOME Boxes:
      
       Thread 1 "gnome-boxes" received signal SIGSEGV, Segmentation fault.
       0x00007ffff7ef2b35 in g_type_check_instance_is_fundamentally_a () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
       (gdb) bt
       #0  0x00007ffff7ef2b35 in g_type_check_instance_is_fundamentally_a () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
       #1  0x00007ffff7ed2e75 in g_object_unref () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
       #2  0x00007ffff6ef094e in gvir_domain_device_set_property (object=0x555556680950, prop_id=2, value=0x7fffffffcbe0,
           pspec=0x555556772540) at libvirt-gobject-domain-device.c:89
       #3  0x00007ffff7ed3b19 in ?? () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
       #4  0x00007ffff7ed5624 in g_object_new_valist () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
       #5  0x00007ffff7ed5959 in g_object_new () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
       #6  0x00005555555d8257 in boxes_libvirt_machine_get_domain_disk (self=0x5555560e6790, error=0x55555615a630)
           at /run/build/gnome-boxes/src/libvirt-machine.vala:547
       #7  0x00005555555d0e7e in boxes_libvirt_machine_update_io_stat_co (_data_=0x55555615a320)
           at /run/build/gnome-boxes/src/libvirt-machine.vala:280
       #8  0x00005555555d09b2 in boxes_libvirt_machine_update_io_stat (self=0x5555560e6790, info=0x555555f25990, stat=0x555556736a90,
           _callback_=0x5555555d2992 <boxes_libvirt_machine_update_stats_ready>, _user_data_=0x555556736a50)
           at /run/build/gnome-boxes/src/libvirt-machine.vala:5
       #9  0x00005555555d3120 in boxes_libvirt_machine_update_stats_co (_data_=0x555556736a50)
           at /run/build/gnome-boxes/src/libvirt-machine.vala:332
       #10 0x00005555555d29dd in boxes_libvirt_machine_update_stats_ready (source_object=0x5555567bb840, _res_=0x55555677ae00,
           _user_data_=0x555556736a50) at /run/build/gnome-boxes/src/libvirt-machine.vala:328
       #11 0x00007ffff72adc89 in ?? () from /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
       #12 0x00007ffff72adcc9 in ?? () from /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
       #13 0x00007ffff7dec948 in g_main_context_dispatch () from /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
       #14 0x00007ffff7decd38 in ?? () from /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
       #15 0x00007ffff7decdcc in g_main_context_iteration () from /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
       #16 0x00007ffff72c2dbd in g_application_run () from /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
       #17 0x00005555556004b6 in _vala_main (args=0x7fffffffd4f8, args_length1=1) at /run/build/gnome-boxes/src/main.vala:84
       #18 0x0000555555600517 in main (argc=1, argv=0x7fffffffd4f8) at /run/build/gnome-boxes/src/main.vala:68
      
      In order to solve the issue, let's just replace G_DEFINE_ABSTRACT_TYPE
      by G_DEFINE_ABSTRACT_TYPE_WITH_PRIVATE.
      Signed-off-by: 's avatarFabiano Fidêncio <fidencio@redhat.com>
      2d3ee844
  6. 16 Aug, 2018 2 commits
  7. 24 Apr, 2018 1 commit
    • Daniel P. Berrangé's avatar
      git: add config file telling git-publish how to send patches · 8f82bca6
      Daniel P. Berrangé authored
      The "git-publish" tool is a useful git extension for sending patch
      series for code review. It automatically creates versioned tags
      each time code on a branch is sent, so that there is a record of
      each version. It also remembers the cover letter so it does not
      need re-entering each time the series is reposted.
      
      With this config file present it is now sufficient[1] to run
      
        $ git publish
      
      to send all patches in a branch to the list for review, with the
      correct subject prefix added for this non-core libvirt module.
      
      [1] Assuming your $HOME/.gitconfig has an SMTP server listed
      at least e.g.
      
         [sendemail]
              smtpserver = smtp.example.com
      Signed-off-by: 's avatarDaniel P. Berrangé <berrange@redhat.com>
      8f82bca6
  8. 20 Feb, 2018 1 commit
    • Daniel P. Berrangé's avatar
      m4: disable gcc8 -Wcast-function-type warnings from -Wextra · 18f7dfe9
      Daniel P. Berrangé authored
      The -Wextra flag bundle gained a new warning -Wcast-function-type.
      This complains if you cast between two function prototypes where
      the number of parameters or their data types are not compatible.
      Unfortunately we need such "bad" function casts for our event
      callbacks. It is possible to silence the warning by first casting
      to the generic "void (*)(void)" function prototype, but that is
      rather ugly to add throughout libvirt code.
      Signed-off-by: 's avatarDaniel P. Berrangé <berrange@redhat.com>
      18f7dfe9
  9. 17 Jan, 2018 1 commit
    • Daniel P. Berrange's avatar
      remove bogus casts of arg to g_object_ref · 9930f404
      Daniel P. Berrange authored
      Latest version of glib uses typeof() magic to cast the
      return value of g_object_ref to match its argument,
      instead of returning a 'void *'. A few places in the
      code were casting the arg to G_OBJECT() which was then
      incompatible with the variable we assigned the result
      to. The parameter casts were always redundant so just
      remove them.
      Signed-off-by: 's avatarDaniel P. Berrange <berrange@redhat.com>
      9930f404
  10. 04 Dec, 2017 1 commit
  11. 30 Oct, 2017 1 commit
  12. 21 Sep, 2017 5 commits