1. 18 Dec, 2021 1 commit
  2. 18 Nov, 2021 1 commit
  3. 29 Oct, 2021 1 commit
  4. 20 Oct, 2021 1 commit
  5. 27 Sep, 2021 1 commit
    • Daniel P. Berrangé's avatar
      build: don't set glib version constraints for g-ir-scanner · 9a34c4ea
      Daniel P. Berrangé authored
      
      
      add_global_arguments() sets flags that apply to all invokations of the C
      compiler toolchain by meson. On the surface it sounds fine to use this
      for setting
      
        -DGLIB_VERSION_MIN_REQUIRED=VER
        -DGLIB_VERSION_MAX_ALLOWED=VER
      
      as we want all our code to be constrained by these declared glib
      versions to prevent us accidentally using APIS from newer glib by
      mistake.
      
      A subtle problem was revealed with the arrival of gobject-introspection
      version 1.70.  The g-ir-scanner program auto-generates some glib code
      for handling introspection, and this generated code uses glib APIs that
      are newer than our declared version and this triggers compile failures
      
      /root/rpmbuild/BUILD/libvirt-glib-4.0.0/redhat-linux-build/tmp-introspectkrq1wuz9/LibvirtGLib-1.0.c:251:3: error: ‘G_TYPE_FLAG_FINAL’ is deprecated: Not available before 2.70 [-Werror=deprecated-declarations]
        251 |   if (G_TYPE_IS_FINAL (type))
            |   ^~
      In file included from /usr/include/glib-2.0/gobject/gobject.h:24,
                       from /usr/include/glib-2.0/gobject/gbinding.h:29,
                       from /usr/include/glib-2.0/glib-object.h:22,
                       from /root/rpmbuild/BUILD/libvirt-glib-4.0.0/redhat-linux-build/tmp-introspectkrq1wuz9/LibvirtGLib-1.0.c:30:
      
      This is actually harmless, because systems with an older glib will also
      have older g-ir-scanner and thus not be using these new APIs.
      
      We need to exclude the glib version constraints from code generated by
      glib tools, and thus means we have to stop using add_global_arguments()
      and set cflags explicitly on each target.
      Signed-off-by: Daniel P. Berrangé's avatarDaniel P. Berrangé <berrange@redhat.com>
      9a34c4ea
  6. 16 Sep, 2021 1 commit
  7. 06 Sep, 2021 4 commits
  8. 27 Jul, 2021 2 commits
  9. 14 Jul, 2021 1 commit
    • Daniel P. Berrangé's avatar
      glib: be robust against possible NULL GError object · e25ee5cb
      Daniel P. Berrangé authored
      
      
      Latest GCC on mingw reports warnings about possible NULL pointer
      dereference:
      
      In file included from /usr/x86_64-w64-mingw32/sys-root/mingw/include/glib-2.0/glib.h:62,
                       from /usr/x86_64-w64-mingw32/sys-root/mingw/include/glib-2.0/glib/gi18n-lib.h:21,
                       from ../libvirt-glib/libvirt-glib-main.c:29:
      ../libvirt-glib/libvirt-glib-main.c: In function 'gvir_init':
      /usr/x86_64-w64-mingw32/sys-root/mingw/include/glib-2.0/glib/gmessages.h:334:25: error: null pointer dereference [-Werror=null-dereference]
        334 |                         g_log (G_LOG_DOMAIN,         \
            |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        335 |                                G_LOG_LEVEL_ERROR,    \
            |                                ~~~~~~~~~~~~~~~~~~~~~~~
        336 |                                __VA_ARGS__);         \
            |                                ~~~~~~~~~~~~
      ../libvirt-glib/libvirt-glib-main.c:103:9: note: in expansion of macro 'g_error'
        103 |         g_error("Could not initialize libvirt-glib: %s\n",
            |         ^~~~~~~
      Signed-off-by: Daniel P. Berrangé's avatarDaniel P. Berrangé <berrange@redhat.com>
      e25ee5cb
  10. 01 May, 2021 1 commit
  11. 23 Apr, 2021 7 commits
  12. 13 Apr, 2021 1 commit
  13. 07 Apr, 2021 1 commit
  14. 26 Mar, 2021 3 commits
  15. 04 Mar, 2021 1 commit
  16. 03 Mar, 2021 12 commits
  17. 15 Feb, 2021 1 commit