Summary There is heap-buffer-overflow errors in extractContigSamplesShifted24bits in tools/tiffcrop.c:3609. Remote attackers could leverage this vulnerability to cause a denial-of-service via a crafted tiff file. Version LIBTIFF, Version master (post 4.4.0), commit id 1bdbd03fbb4e7d662af052450259fcd353a49cc0 (Tue Nov 29 17:02:09 2022 +0000) Steps to reproduce ``` # CFLAGS="-g -fsanitize=address -fno-omit-frame-pointer" CXXFLAGS="-g -fsanitize=address -fno-omit-frame-pointer" ./configure --prefix=$PWD/build_asan --disable-shared # make -j; make install; make clean $ ./build_asan/bin/tiffcrop -E right -z 1,1,2048,2048:1,2049,2048,4097 -i -s poc /tmp/foo TIFFFetchNormalTag: Warning, ASCII value for tag "DocumentName" does not end in null byte. TIFFReadDirectory: Warning, Sum of Photometric type-related color channels and ExtraSamples doesn't match SamplesPerPixel. Defining non-color channels as ExtraSamples.. ================================================================= ==145258==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x7fd349a8f380 at pc 0x561ae8db5055 bp 0x7ffe7a93e1b0 sp 0x7ffe7a93e1a0 WRITE of size 1 at 0x7fd349a8f380 thread T0 #0 0x561ae8db5054 in extractContigSamplesShifted24bits /root/programs_latest/libtiff/tools/tiffcrop.c:3609 #1 0x561ae8dca2c5 in extractCompositeRegions /root/programs_latest/libtiff/tools/tiffcrop.c:6811 #2 0x561ae8dcdd0a in processCropSelections /root/programs_latest/libtiff/tools/tiffcrop.c:7733 #3 0x561ae8db0bb1 in main /root/programs_latest/libtiff/tools/tiffcrop.c:2511 #4 0x7fd34c897082 in __libc_start_main ../csu/libc-start.c:308 #5 0x561ae8da760d in _start (/root/programs_latest/libtiff/build_asan/bin/tiffcrop+0x2e60d) 0x7fd349a8f380 is located 4061 bytes to the right of 142243-byte region [0x7fd349a6b800,0x7fd349a8e3a3) allocated by thread T0 here: #0 0x7fd34d23f808 in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cc:144 #1 0x561ae8e4a09e in _TIFFmalloc /root/programs_latest/libtiff/libtiff/tif_unix.c:336 #2 0x561ae8da77a0 in limitMalloc /root/programs_latest/libtiff/tools/tiffcrop.c:644 #3 0x561ae8dcda81 in processCropSelections /root/programs_latest/libtiff/tools/tiffcrop.c:7705 #4 0x561ae8db0bb1 in main /root/programs_latest/libtiff/tools/tiffcrop.c:2511 #5 0x7fd34c897082 in __libc_start_main ../csu/libc-start.c:308 SUMMARY: AddressSanitizer: heap-buffer-overflow /root/programs_latest/libtiff/tools/tiffcrop.c:3609 in extractContigSamplesShifted24bits Shadow bytes around the buggy address: 0x0ffae9349e20: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0ffae9349e30: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0ffae9349e40: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0ffae9349e50: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0ffae9349e60: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa =>0x0ffae9349e70:[fa]fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0ffae9349e80: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0ffae9349e90: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0ffae9349ea0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0ffae9349eb0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0ffae9349ec0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb Shadow gap: cc ==145258==ABORTING ``` Platform ``` # uname -a Linux dd189b3c7b86 5.15.0-52-generic #58~20.04.1-Ubuntu SMP Thu Oct 13 13:09:46 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux ``` [poc.zip](/uploads/364bdd57cda09f6352f05fa026a0c3d6/poc.zip)