tiffcrop: heap-buffer-overflow in extractContigSamplesShifted32bits, tiffcrop.c:3724
Summary
There is heap-buffer-overflow errors in extractContigSamplesShifted32bits in tools/tiffcrop.c:3724. Remote attackers could leverage this vulnerability to cause a denial-of-service via a crafted tiff file.
Version
LIBTIFF, Version master (post 4.4.0), commit id 1bdbd03f (Tue Nov 29 17:02:09 2022 +0000)
Steps to reproduce
# CFLAGS="-g -fsanitize=address -fno-omit-frame-pointer" CXXFLAGS="-g -fsanitize=address -fno-omit-frame-pointer" ./configure --prefix=$PWD/build_asan --disable-shared
# make -j; make install; make clean
$ ./build_asan/bin/tiffcrop -E left -z 1,1,2048,2048:1,2049,2048,4097 -i poc /tmp/foo
TIFFFetchNormalTag: Warning, ASCII value for tag "DocumentName" contains null byte in value; value incorrectly truncated during reading due to implementation limitations.
TIFFFetchNormalTag: Warning, Incorrect count for "XResolution"; tag ignored.
TIFFReadDirectory: Warning, Incorrect count for "ColorMap"; tag ignored.
TIFFReadDirectory: Warning, Sum of Photometric type-related color channels and ExtraSamples doesn't match SamplesPerPixel. Defining non-color channels as ExtraSamples..
ZIPDecode: Decoding error at scanline 0.
=================================================================
==145341==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x63100003bcd0 at pc 0x5570a0a646d0 bp 0x7ffc39ed56b0 sp 0x7ffc39ed56a0
WRITE of size 1 at 0x63100003bcd0 thread T0
#0 0x5570a0a646cf in extractContigSamplesShifted32bits /root/programs_latest/libtiff/tools/tiffcrop.c:3724
#1 0x5570a0a79339 in extractCompositeRegions /root/programs_latest/libtiff/tools/tiffcrop.c:6823
#2 0x5570a0a7cd0a in processCropSelections /root/programs_latest/libtiff/tools/tiffcrop.c:7733
#3 0x5570a0a5fbb1 in main /root/programs_latest/libtiff/tools/tiffcrop.c:2511
#4 0x7f55de277082 in __libc_start_main ../csu/libc-start.c:308
#5 0x5570a0a5660d in _start (/root/programs_latest/libtiff/build_asan/bin/tiffcrop+0x2e60d)
0x63100003bcd0 is located 2193 bytes to the right of 76863-byte region [0x631000028800,0x63100003b43f)
allocated by thread T0 here:
#0 0x7f55dec1f808 in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cc:144
#1 0x5570a0af909e in _TIFFmalloc /root/programs_latest/libtiff/libtiff/tif_unix.c:336
#2 0x5570a0a567a0 in limitMalloc /root/programs_latest/libtiff/tools/tiffcrop.c:644
#3 0x5570a0a7ca81 in processCropSelections /root/programs_latest/libtiff/tools/tiffcrop.c:7705
#4 0x5570a0a5fbb1 in main /root/programs_latest/libtiff/tools/tiffcrop.c:2511
#5 0x7f55de277082 in __libc_start_main ../csu/libc-start.c:308
SUMMARY: AddressSanitizer: heap-buffer-overflow /root/programs_latest/libtiff/tools/tiffcrop.c:3724 in extractContigSamplesShifted32bits
Shadow bytes around the buggy address:
0x0c627ffff740: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c627ffff750: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c627ffff760: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c627ffff770: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c627ffff780: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
=>0x0c627ffff790: fa fa fa fa fa fa fa fa fa fa[fa]fa fa fa fa fa
0x0c627ffff7a0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c627ffff7b0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c627ffff7c0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c627ffff7d0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c627ffff7e0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07
Heap left redzone: fa
Freed heap region: fd
Stack left redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user: f7
Container overflow: fc
Array cookie: ac
Intra object redzone: bb
ASan internal: fe
Left alloca redzone: ca
Right alloca redzone: cb
Shadow gap: cc
==145341==ABORTING
Platform
# uname -a
Linux dd189b3c7b86 5.15.0-52-generic #58~20.04.1-Ubuntu SMP Thu Oct 13 13:09:46 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux