Skip to content

[Help document bug] For tiffcrop, the help document misses some options

Summary

The "-h" option of tiffcrop misses the option "B", "L", "M", "C" for version 4.4.0.

Version

4.4.0

Steps to reproduce

  • For the option "B", the following code appears during option parsing and modifies the mp in tools/tiffcrop.c:1768 for version 4.4.0.
      case 'B': *mp++ = 'b'; *mp = '\0';
  • For the option "L", the following code appears during option parsing and modifies the mp in tools/tiffcrop.c:1770 for version 4.4.0.
      case 'L': *mp++ = 'l'; *mp = '\0';
  • For the option "M", the following code appears during option parsing and modifies the mp in tools/tiffcrop.c:1772 for version 4.4.0.
      case 'M': *mp++ = 'm'; *mp = '\0';
  • For the option "C", the following code appears during option parsing and modifies the mp in tools/tiffcrop.c:1774 for version 4.4.0.
      case 'C': *mp++ = 'c'; *mp = '\0';

But it does not appear in the document provided by "-h". Besides, in the #450 (closed), these four options can lead to buffer overflow bugs. It is completely imperceptible to the users.

Platform

Ubuntu 20.04