Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • L libtiff
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 157
    • Issues 157
    • List
    • Boards
    • Service Desk
    • Milestones
    • Requirements
  • Merge requests 20
    • Merge requests 20
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
    • Model experiments
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • libtiff
  • libtiff
  • Issues
  • #278
Closed
Open
Issue created Jul 23, 2021 by 4ugustus@waugustusContributor

Heap buffer overflow in cpContigBufToSeparateBuf, tiffcp.c:1373

Summary

There is a heap buffer overflow in cpContigBufToSeparateBuf in tools/tiffcp.c. Remote attackers could leverage this vulnerability to cause a denial-of-service via a crafted tiff file.

Version

LIBTIFF, Version 4.3.0, commit id fb61aee8

POC file

heap-buffer-overflow_tiffcp.c-1373

Steps to reproduce

# export CFLAGS="-O -g -fsanitize=address"
# export CXXFLAGS="-O -g -fsanitize=address"
# ./configure --prefix=$PWD/build_asan
# make -j64 & make install

# ./build_asan/bin/tiffcp -i -s -p separate poc /tmp/foo
TIFFReadDirectoryCheckOrder: Warning, Invalid TIFF directory; tags are not sorted in ascending order.
poc: Warning, Nonstandard tile width 1, convert file.
TIFFFetchStripThing: Warning, Incorrect count for "StripOffsets"; tag ignored.
TIFFFetchStripThing: Warning, Incorrect count for "StripByteCounts"; tag ignored.
TIFFFillTile: 0: Invalid tile byte count, tile 1.
TIFFFillTile: 0: Invalid tile byte count, tile 2.
TIFFFillTile: 0: Invalid tile byte count, tile 3.
TIFFFillTile: 0: Invalid tile byte count, tile 4.
TIFFFillTile: 0: Invalid tile byte count, tile 5.
TIFFFillTile: 0: Invalid tile byte count, tile 6.
TIFFFillTile: 0: Invalid tile byte count, tile 7.
TIFFFillTile: 0: Invalid tile byte count, tile 8.
TIFFFillTile: 0: Invalid tile byte count, tile 9.
TIFFFillTile: 0: Invalid tile byte count, tile 10.
TIFFFillTile: 0: Invalid tile byte count, tile 11.
TIFFFillTile: 0: Invalid tile byte count, tile 12.
TIFFFillTile: 0: Invalid tile byte count, tile 13.
TIFFFillTile: 0: Invalid tile byte count, tile 14.
TIFFFillTile: 0: Invalid tile byte count, tile 15.
=================================================================
==44064==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x61500000ff00 at pc 0x000000401e4b bp 0x7ffcfd19e4f0 sp 0x7ffcfd19e4e0
READ of size 1 at 0x61500000ff00 thread T0
    #0 0x401e4a in cpContigBufToSeparateBuf /root/programs/Libtiff/tools/tiffcp.c:1373
    #1 0x4034a2 in writeBufferToSeparateStrips /root/programs/Libtiff/tools/tiffcp.c:1683
    #2 0x404001 in cpImage /root/programs/Libtiff/tools/tiffcp.c:1420
    #3 0x4040c7 in cpContigTiles2SeparateStrips /root/programs/Libtiff/tools/tiffcp.c:1934
    #4 0x407600 in tiffcp /root/programs/Libtiff/tools/tiffcp.c:979
    #5 0x407600 in main /root/programs/Libtiff/tools/tiffcp.c:334
    #6 0x7fd77abcc83f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2083f)
    #7 0x401ab8 in _start (/root/programs/Libtiff/build_asan/bin/tiffcp+0x401ab8)

0x61500000ff00 is located 0 bytes to the right of 512-byte region [0x61500000fd00,0x61500000ff00)
allocated by thread T0 here:
    #0 0x7fd77b341602 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98602)
    #1 0x7fd77b049c61 in _TIFFmalloc /root/programs/Libtiff/libtiff/tif_unix.c:314

SUMMARY: AddressSanitizer: heap-buffer-overflow /root/programs/Libtiff/tools/tiffcp.c:1373 cpContigBufToSeparateBuf
Shadow bytes around the buggy address:
  0x0c2a7fff9f90: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c2a7fff9fa0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c2a7fff9fb0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c2a7fff9fc0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c2a7fff9fd0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x0c2a7fff9fe0:[fa]fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c2a7fff9ff0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c2a7fffa000: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c2a7fffa010: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c2a7fffa020: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c2a7fffa030: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Heap right redzone:      fb
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack partial redzone:   f4
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
==44064==ABORTING

Platform

# uname -a 
Linux 37d1a8efe7bb 4.15.0-142-generic #146~16.04.1-Ubuntu SMP Tue Apr 13 09:27:15 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
```(Operating system, architecture, compiler details)`
Assignee
Assign to
Time tracking