- 28 Nov, 2020 1 commit
-
-
The old conditionals were causing the following E_NOTICEs: "Trying to access array offset on value of type null in <line>"
-
- 05 Nov, 2020 1 commit
-
-
Jack Phoenix authored
Passing an incorrectly capitalized name to SpecialPage#getTitleFor causes a notice when development notices are enabled. For legacy reasons, older special pages' names (e.g. Userlogin, Whatlinkshere) are expected to be in lowercase except for the first letter, but newer special pages are assumed to be CamelCased (e.g. CreateAccount, EditTags, etc.).
-
- 09 Feb, 2020 1 commit
-
-
Jack Phoenix authored
Requires MW 1.34+ or newer (though since PermissionsManager was introduced in 1.33, this might be 1.33-compatible, didn't check)
-
- 01 Jan, 2020 10 commits
-
-
Jack Phoenix authored
Support the old-school "orange bar of death" when the Echo extension isn't installed See merge request !114
-
Jack Phoenix authored
Support the old-school "orange bar of death" when the Echo extension isn't installed so that users will still see an obvious visual cue when they have new messages
-
Jack Phoenix authored
Fix URL generation for page names containing slashes in live RC JS by using mw.util.getUrl() See merge request !113
-
Jack Phoenix authored
Previously for a page named "Foo/Bar" the slash would get URL-encoded, which would then take the user to a HTTP 404 page instead of the desired wiki page.
-
Jack Phoenix authored
Clarify the liberty-pref-fonts-help i18n msg a bit See merge request !112
-
Jack Phoenix authored
-
Jack Phoenix authored
Unbreak Special:Preferences on MW 1.34+ See merge request !111
-
Jack Phoenix authored
Previously an exception was thrown upon accessing Special:Preferences: "Default 'null' is invalid for preference liberty-dark of user <username>"
-
Jack Phoenix authored
Make new preferences properly i18n-able See merge request !110
-
Jack Phoenix authored
Unfortunately preserving the Korean i18n in this commit is not possible, as the automatic TWN translation import process would overwrite any all changes I'd make to other i18n files than en.json and qqq.json. Thus in order to preserve the Korean i18n, the respective MediaWiki: pages will need to be created at TWN.
-
- 27 Dec, 2019 2 commits
-
-
Jack Phoenix authored
Use SPDX 3.0 license identifier See merge request !109
-
Jack Phoenix authored
SPDX released version 3 of their license list (<https://spdx.org/licenses/>), which changed the FSF licenses to explicitly end in -only or -or-later instead of relying on an easy to miss + symbol. See https://phabricator.wikimedia.org/T183858
-
- 16 Oct, 2019 2 commits
-
-
Jack Phoenix authored
CI, indentation and coding style fixes/tweaks See merge request !106
-
Jack Phoenix authored
-
- 21 Apr, 2019 2 commits
-
-
Jack Phoenix authored
Awful, quick fix for the new RC Filters in MW 1.32+ See merge request !89
-
Jack Phoenix authored
This really isn't the correct way to do this, but this works... With the new, OOUI-ful RCFilter stuff, this rule causes the "hamburger" icon on the "Filter changes (use menu or search for filter)" <input> area to be mispositioned, and additionally something here makes that input one or two pixels too tall so it "overflows". Adding a new :not() selector here fixes both issues, but it's not the clean, nice, scalable solution I'd want.
-
- 17 Apr, 2019 2 commits
-
-
Jack Phoenix authored
Hide empty list elements See merge request !88
-
Jack Phoenix authored
Also tweaked coding style in a few places while at it. Upstream bug ticket: https://phabricator.wikimedia.org/T192446
-
- 28 Mar, 2019 2 commits
-
-
Jack Phoenix authored
Use $wgResourceModuleSkinStyles to load CSS specific to the RelatedArticles... See merge request !87
-
Jack Phoenix authored
Use $wgResourceModuleSkinStyles to load CSS specific to the RelatedArticles extension only when that extension is loaded .read-more-container styles are defined by /extensions/RelatedArticles/resources/ext.relatedArticles.readMore/readMore.default.less which is a part of the ResourceLoader module "ext.relatedArticles.readMore". Also stylized the CSS file so that it now uses tabs instead of spaces for indentation and bumped up skin version number.
-
- 24 Mar, 2019 2 commits
-
-
Jack Phoenix authored
Add Finnish (fi) i18n + replace hardcoded string in live-recent.js with an i18n msg See merge request !86
-
Jack Phoenix authored
Despite that code not working in the past, it is now (?!). Tested under MediaWiki 1.32.0.
-
- 21 Mar, 2019 2 commits
-
-
Jack Phoenix authored
Move ad-related JS code out of /js/layout.js in case if ads are turned off See merge request !85
-
Jack Phoenix authored
In SkinLiberty#setupSkinUserCss, we load the Google AdSense JS code in page <head> only if $wgLibertyAdSetting['client'] is set. If it isn't (ie. ads are turned off for whatever reason), surely there's no point in loading this JS on all page views?
-
- 11 Mar, 2019 2 commits
-
-
Jack Phoenix authored
Upgrade Bootstrap to version 3.3.7 to stop JavaScript errors in MW 1.32+ due... See merge request !84
-
Jack Phoenix authored
Upgrade Bootstrap to version 3.3.7 to stop JavaScript errors in MW 1.32+ due to "too new" jQuery bundled with MW Also stop loading a custom, outdated jQuery in the skins.liberty.bootstrap ResourceLoader module. MediaWiki has loaded jQuery for quite many versions by default on *all* page loads. In MediaWiki 1.32+ the version of jQuery bundled with MediaWiki and thus loaded automatically on all page loads is "too new" for Bootstrap v.3.3.6. To play it safe, I decided to upgrade Bootstrap only to v.3.3.7 because it's known to work with the version of jQuery that MW 1.32+ ships with (see https://github.com/twbs/bootstrap/issues/16834) even though the current release of Bootstrap is v.4.3.1. I've tested 3.3.7 locally and confirmed that it's working, e.g. the user menu shows again when you click on it and so on. Added the unminified, single-file bootstrap.js version of Bootstrap v.3.3.7 to the repository as well, even though it's not used, but having already minified source files without the unminified "real" source in the repository is kinda annoying, and from a security point of view, you'll wanna make sure that the source is there. Bootstrap files downloaded from GitHub (bootstrap-3.3.7-dist.zip).
-
- 10 Mar, 2019 1 commit
-
-
Jack Phoenix authored
Don't use OutputPage#addModuleScripts, use OutputPage#addModules instead See merge request !83
-
- 08 Jan, 2018 2 commits
-
-
Jack Phoenix authored
Remove deprecated 'position' annotations from ResourceLoader module definitions See merge request !66
-
Jack Phoenix authored
Defining 'position' for a RL module has been deprecated since MW 1.29, as per https://phabricator.wikimedia.org/T184257 and https://gerrit.wikimedia.org/r/#/c/320315/
-
- 02 Jan, 2018 2 commits
-
-
Jack Phoenix authored
Performance: use $wgResourceModuleSkinStyles to load some CSS only when needed See merge request !65
-
Jack Phoenix authored
Now the CSS specific to Special:Preferences (and/or other (special) pages using the "mediawiki.special.preferences.styles" ResourceLoader module) will only be loaded there. Because the ResourceLoader module "skins.liberty.styles" includes the only-mw.css file, previously the #preftoc styles were loaded on all pages, regardless of whether the CSS was needed there or not. Also added an old CSS fix of mine for File: pages to fix some overlapping issue with the social share buttons.
-
- 24 Nov, 2017 2 commits
-
-
Jack Phoenix authored
Allow turning the live recent changes feature off See merge request !64
-
Jack Phoenix authored
-
- 23 Nov, 2017 4 commits
-
-
Jack Phoenix authored
Explicitly declare skins.liberty.layoutjs module's dependency on core mediawiki.cookie module See merge request !63
-
Jack Phoenix authored
-
Jack Phoenix authored
Don't output the meta description tag in the skin if an extension has already taken care of that See merge request !62
-
Jack Phoenix authored
-