Loading
Commits on Source 22
-
-
Rasmus Munk Larsen authored -
-
-
-
-
Rasmus Munk Larsen authored
-
-
-
-
Antonio Sánchez authored
-
Antonio Sánchez authored
-
Antonio Sánchez authored
-
-
-
Antonio Sánchez authored
<!-- Thanks for contributing a merge request! We recommend that first-time contributors read our [contribution guidelines](https://eigen.tuxfamily.org/index.php?title=Contributing_to_Eigen). Before submitting the MR, please complete the following checks: - Create one PR per feature or bugfix, - Run the test suite to verify your changes. See our [test guidelines](https://eigen.tuxfamily.org/index.php?title=Tests). - Add tests to cover the bug addressed or any new feature. - Document new features. If it is a substantial change, add it to the [Changelog](https://gitlab.com/libeigen/eigen/-/blob/master/CHANGELOG.md). - Leave the following box checked when submitting: `Allow commits from members who can merge to the target branch`. This allows us to rebase and merge your change. Note that we are a team of volunteers; we appreciate your patience during the review process. --> ### Description <!--Please explain your changes.--> More ComplexQZ fixes. Extra semicolons are triggering some warnings and errors with `-Werror`. Moved the `Sparse` import up to the umbrella header to avoid IWYU exports. ### Reference issue <!-- You can link to a specific issue using the gitlab syntax #<issue number>. If the MR fixes an issue, write "Fixes #<issue number>" to have the issue automatically closed on merge. --> ### Additional information <!--Any additional information you think is important.--> See merge request !2036
-
<!-- Thanks for contributing a merge request! We recommend that first-time contributors read our [contribution guidelines](https://eigen.tuxfamily.org/index.php?title=Contributing_to_Eigen). Before submitting the MR, please complete the following checks: - Create one PR per feature or bugfix, - Run the test suite to verify your changes. See our [test guidelines](https://eigen.tuxfamily.org/index.php?title=Tests). - Add tests to cover the bug addressed or any new feature. - Document new features. If it is a substantial change, add it to the [Changelog](https://gitlab.com/libeigen/eigen/-/blob/master/CHANGELOG.md). - Leave the following box checked when submitting: `Allow commits from members who can merge to the target branch`. This allows us to rebase and merge your change. Note that we are a team of volunteers; we appreciate your patience during the review process. --> ### Description <!--Please explain your changes.--> Support AVX for i686. There was an existing work-around for windows. Added the more generic architecture comparison to also apply for linux. ### Reference issue <!-- You can link to a specific issue using the gitlab syntax #<issue number>. If the MR fixes an issue, write "Fixes #<issue number>" to have the issue automatically closed on merge. --> Fixes #2991. Closes #2991 See merge request libeigen/eigen!2037
-
Charles Schlosser authored
<!-- Thanks for contributing a merge request! Please name and fully describe your MR as you would for a commit message. If the MR fixes an issue, please include "Fixes #issue" in the commit message and the MR description. In addition, we recommend that first-time contributors read our [contribution guidelines](https://eigen.tuxfamily.org/index.php?title=Contributing_to_Eigen) and [git page](https://eigen.tuxfamily.org/index.php?title=Git), which will help you submit a more standardized MR. Before submitting the MR, you also need to complete the following checks: - Make one PR per feature/bugfix (don't mix multiple changes into one PR). Avoid committing unrelated changes. - Rebase before committing - For code changes, run the test suite (at least the tests that are likely affected by the change). See our [test guidelines](https://eigen.tuxfamily.org/index.php?title=Tests). - If possible, add a test (both for bug-fixes as well as new features) - Make sure new features are documented Note that we are a team of volunteers; we appreciate your patience during the review process. Again, thanks for contributing! --> ### Reference issue <!-- You can link to a specific issue using the gitlab syntax #<issue number> --> ### What does this implement/fix? <!--Please explain your changes.--> Currently, we run each test 3 times to account for flaky tests. Sometimes, the test fails so quickly that the random seed is the same for the subsequent test, which fails the exact same way. This MR uses a nanosecond seed which resolves the issue described above. Now, if the test does not pass on the first attempt but passes on the retries, the gitlab job status will be yellow but still be treated as a pass in the ci/cd pipeline. Hopefully, this means we will get more passes and help us identify room for improvement. ### Additional information <!--Any additional information you think is important.--> See merge request !2025
-
It fixes this compiler error: ``` /home/tav/git/Sleipnir/build/_deps/eigen3-src/Eigen/src/SparseCore/SparseVector.h:143:19: error: cannot convert ‘int’ to ‘const Eigen::internal::CompressedStorage<boost::decimal::decimal64_t, int>::Scalar&’ {aka ‘const boost::decimal::decimal64_t&’} 143 | m_data.append(0, i); | ^ | | | int ``` This change matches what SparseMatrix does: https://gitlab.com/libeigen/eigen/-/blob/master/Eigen/src/SparseCore/SparseMatrix.h#L430-L438 See merge request !2040 -
<!-- Thanks for contributing a merge request! We recommend that first-time contributors read our [contribution guidelines](https://eigen.tuxfamily.org/index.php?title=Contributing_to_Eigen). Before submitting the MR, please complete the following checks: - Create one PR per feature or bugfix, - Run the test suite to verify your changes. See our [test guidelines](https://eigen.tuxfamily.org/index.php?title=Tests). - Add tests to cover the bug addressed or any new feature. - Document new features. If it is a substantial change, add it to the [Changelog](https://gitlab.com/libeigen/eigen/-/blob/master/CHANGELOG.md). - Leave the following box checked when submitting: `Allow commits from members who can merge to the target branch`. This allows us to rebase and merge your change. Note that we are a team of volunteers; we appreciate your patience during the review process. --> ### Description <!--Please explain your changes.--> Eliminate use of std::cout in ArpackSelfAdjointEigenSolver. Instead set the appropriate error status on failure. ### Reference issue <!-- You can link to a specific issue using the gitlab syntax #<issue number>. If the MR fixes an issue, write "Fixes #<issue number>" to have the issue automatically closed on merge. --> ### Additional information <!--Any additional information you think is important.--> See merge request !2041
-
<!-- Thanks for contributing a merge request! We recommend that first-time contributors read our [contribution guidelines](https://eigen.tuxfamily.org/index.php?title=Contributing_to_Eigen). Before submitting the MR, please complete the following checks: - Create one PR per feature or bugfix, - Run the test suite to verify your changes. See our [test guidelines](https://eigen.tuxfamily.org/index.php?title=Tests). - Add tests to cover the bug addressed or any new feature. - Document new features. If it is a substantial change, add it to the [Changelog](https://gitlab.com/libeigen/eigen/-/blob/master/CHANGELOG.md). - Leave the following box checked when submitting: `Allow commits from members who can merge to the target branch`. This allows us to rebase and merge your change. Note that we are a team of volunteers; we appreciate your patience during the review process. --> ### Description <!--Please explain your changes.--> Clarify range spanning major versions only works with 3.4.1. ### Reference issue <!-- You can link to a specific issue using the gitlab syntax #<issue number>. If the MR fixes an issue, write "Fixes #<issue number>" to have the issue automatically closed on merge. --> Fixes #2994. Closes #2994 See merge request libeigen/eigen!2042
-
Rasmus Munk Larsen authored
ComplexQZ would try to apply a Jacobi rotation to an empty block, which triggers a warning in static analyzers, since the corresponding `Eigen::Map` object will contain a `nullptr`. See merge request !2043