Skip to content

Regression in c20e908e for msvc

Summary

Since commit c20e908e our code fails to compile with the following error:
CoreEvaluators.h(905): warning C4305: "Argument": truncation from "unsigned int" to "bool"

Environment

  • Operating System : Windows
  • Architecture : x64
  • Eigen Version : since c20e908e
  • Compiler Version : msvc 16.11.x
  • Compile Flags : /nologo /TP -DQUICKCPPLIB_ENABLE_VALGRIND=1 -DUNICODE -DWIN32 -DWIN64 -D_ENABLE_EXTENDED_ALIGNED_STORAGE -D_UNICODE -D_WIN64 -IC:\cmake_cache\eigen\e90ff199727736341f07fd2420a2cc6b7f6db2c3\eigen /DWIN32 /D_WINDOWS /EHsc /Zi /Ob0 /Od /RTC1 -MDd /D_USE_MATH_DEFINES /DNOMINMAX /DWIN32_LEAN_AND_MEAN /D_WIN32_WINNT=0x0601 /DBOOST_THREAD_USE_LIB /W3 /WX -Zc:__cplusplus -permissive- -utf-8 -std:c++latest /showIncludes

Minimal Example

Can't create one, I am not familiar enough with that part of our codebase.

Steps to reproduce

use

[build] ... Eigen::internal::evaluator<Derived>".
[build]         with
[build]         [
[build]             Derived=Eigen::Map<Eigen::Array<std::complex<double>,-1,1,0,-1,1>,0,Eigen::Stride<0,0>>
[build]         ]

What is the current bug behavior?

Compile error

What is the expected correct behavior?

No compilation error

Relevant logs

$ git bisect log
git bisect start
# bad: [7b5a8b6bc55151f1998dee63a46d745c4a635894] Improve plog: 20% speedup for
 float + handle denormals
git bisect bad 7b5a8b6bc55151f1998dee63a46d745c4a635894
# good: [3e819d83bf52abda16bb53565f6801df40d071f1] Before 3.4 branch
git bisect good 3e819d83bf52abda16bb53565f6801df40d071f1
# good: [6c10495a78ec400d258e2c7e6b534973468a64c7] Remove unnecessary std::tupl
e reference.
git bisect good 6c10495a78ec400d258e2c7e6b534973468a64c7
# good: [5c642950a5d0232ebdfa6b460b4515e6e2b8828d] Bug Fix: correct the bug tha
t won't define EIGEN_HAS_FP16_C if the compiler isn't clang
git bisect good 5c642950a5d0232ebdfa6b460b4515e6e2b8828d
# good: [d60f7fa518470bb2985bdd6b1adef2c6c8b0a36e] Improved lapacke binding cod
e for HouseholderQR and PartialPivLU
git bisect good d60f7fa518470bb2985bdd6b1adef2c6c8b0a36e
# bad: [2d39da8af54982a02e62adec26ea0fb7425e5cb0] space separated EIGEN_TEST_CU
STOM_CXX_FLAGS
git bisect bad 2d39da8af54982a02e62adec26ea0fb7425e5cb0
# good: [e4c40b092a209a52b882e2e46f32799582c2f430] disambiguate overloads for e
mpty index list
git bisect good e4c40b092a209a52b882e2e46f32799582c2f430
# good: [0b81185fe35dac28f527e2a05d5a0a7fedeb244e] removed Find*.cmake scripts
for which these are available in cmake itself
git bisect good 0b81185fe35dac28f527e2a05d5a0a7fedeb244e
# good: [0f36e42169abf08cbcc348f26fa2054dbb9802f9] Fix
git bisect good 0f36e42169abf08cbcc348f26fa2054dbb9802f9
# bad: [6b2df803173e47e8efe9fa1a1f09dfae1b0f63fa] Fixes for enabling HIP unit t
ests.  Includes a fix to make this work with the latest cmake.
git bisect bad 6b2df803173e47e8efe9fa1a1f09dfae1b0f63fa
# bad: [c20e908ebc42f7174b1d85ce82583a66d185520c] turn some macros intro conste
xpr functions
git bisect bad c20e908ebc42f7174b1d85ce82583a66d185520c
# first bad commit: [c20e908ebc42f7174b1d85ce82583a66d185520c] turn some macros
 intro constexpr functions

Warning Messages

See above