Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • eigen eigen
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 649
    • Issues 649
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Custom issue tracker
    • Custom issue tracker
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

GitLab 15.0 is launching on May 22! This version brings many exciting improvements, but also removes deprecated features and introduces breaking changes that may impact your workflow. To see what is being deprecated and removed, please visit Breaking changes in 15.0 and Deprecations.

  • libeigen
  • eigeneigen
  • Issues
  • #1687
Closed
Open
Created Dec 04, 2019 by Eigen Bugzilla@eigenbzReporter

Reconsider usage of EIGEN_FAST_MATH

Submitted by Christoph Hertzberg @chhtz

Assigned to Nobody

Link to original bugzilla bug (#1687)
Version: 3.4 (development)

Description

Currently setting EIGEN_FAST_MATH to 1 (which it is by default) essentially just means that sin and cos are calculated using SIMD-math.
I assume that meanwhile our implementation is within 1ULP of the accuracy of the std implementation, so this flag is nearly irrelevant.
If we want to keep this, I suggest renaming this to something like EIGEN_USE_SIMD_MATH_FUNCTIONS and let it enable/disable all other packet-functions (like plog/pexp/...) as well.

And if we refactor this, I would also suggest removing HasSin, HasCos, ... from all the packet_traits, and replace the logic by checking if we have cast_to_int, bitshift, bittest, ... (or whatever operations are needed to implement the relevant function).

Also related is Bug #1259. If SVML (or something equivalent) is available we could offer to use that library instead of our own functions.

Depends on

#1259

Blocking

#564 (closed) #1608 #1693

Edited Dec 15, 2020 by Rasmus Munk Larsen
Assignee
Assign to
Time tracking