unnamed OpenMP critical section may interfer with user unnamed critical sections

Submitted by fabien chêne

Assigned to Nobody

Link to original bugzilla bug (#1151)
Version: 3.3 (current stable)

Description

In GeneralMatrixMatrix.h, I can see the presence of an OpenMP unnamed critical section. The problem is that it may interfer with user unnamed critical sections, if any.

One approach to tackle the problem would be to name the critical section with a somewhat unique identifier (eigen_mat_mul_critical_section or the like). Another (perhaps better) approach would be to use locks from OpenMP.

Incidentaly, I don't see the need for an atomic update within a critical section.