- 02 Aug, 2022 1 commit
-
- 31 Jul, 2022 3 commits
-
-
Tom Englund authored
commit c8fc1491 missed adding code to optionsmodel.cpp implenting optionType and OptionsModel::allValues(), also ensure we use optionList for virtual desktops on wayland. x11PropertyHash had outdates entries update them aswell. fixes crashes when trying to Configure Special Window Settings on both x11 and wayland.
-
Tom Englund authored
m_settings was never initialized and can contain arbitrary random data and cause issues down the line.
-
Tom Englund authored
m_settings was never being initialized and could potentially cause issues further down the line having arbitrary random data.
-
- 29 Jul, 2022 15 commits
-
-
Tom Englund authored
commit fa105ea7 added an second connect to the signal virtualDesktopsUpdated while it should have simply modified the currently existing one, this fixes a nullptr crash when trying to access window rules.
-
Tom Englund authored
backport of 1b215e6c, EffectQuickView is used by Aurorae. As long as Aurorae decorations are rendered by kwin, it's not a problem. However, kde-gtk-config kded module can also render them. This creates a problem. If effects object is not created, accessing any of its getters or setters will result in a segmentation fault. This change rewrites the share context check so the effects object is not accessed anymore. One could argue that kde-gtk-config has to provide a dummy EffectsHandler but it doesn't use effects and libkwineffects is not a dependency of KDecoration2. So, providing a dummy EffectsHandler makes no sense. In hindsight, we need to revisit the usage of EffectQuickView in Aurorae as accessing the EffectsHandler in EffectQuickView is a totally valid usecase and integration of QOpenGLContext. Co-authored-by: Vlad Zahorodnii
-
Tom Englund authored
on wayland we use rgba colors, so set QImage::rgba8888 instead of ::argb32. fixes weird color distortions. also with the right colors set we dont have to flip and invert the image.
-
Tom Englund authored
seems a typo has been left in there. actually check maxsize in maxsize.
-
Tom Englund authored
fixes popups sometimes being in the wrong stacking order and also the situation when the dock has an popup and setshowingdesktop gets called which iterates over the stackingorder and calls update_layer and then belong_to_layer, now without this it means its entering win->layer_for_dock() because this popup has windowtype of net::dock but is an xdgxshell popup without control and hits the assert in there.
-
Tom Englund authored
add missing includes.
-
Tom Englund authored
slide effects might delete themself while iterating, and iterating in a for ranges loop that gets modified is undefined behaviour.
-
Tom Englund authored
if internal window is not a deleted we call delete_window_from_space that deletes "this" which means assigning m_internalWindow to nullptr afterwards is a write to pointer after free, also move delete this, to not double delete it.
-
Tom Englund authored
ensures we dont deep copy on each call.
-
Tom Englund authored
QFileInfo::exists(file) is documented to be faster then QFileInfo(file).exists().
-
Tom Englund authored
seems focus stealing prevention level was never being set, ensure its being set.
-
Tom Englund authored
ensures it doesnt deep copy the container on each call.
-
Tom Englund authored
dont call .first or .last on temporarys, use constFirst or constLast. ensures they dont unnecesserly detach/deep copies. found with clang tidy/clazy.
-
Tom Englund authored
ensure Qt containers does not detach by using qAsConst, found with clang tidy/clazy.
-
Tom Englund authored
add missing references and const, found by clang tidy/clazy.
-
- 28 Jul, 2022 1 commit
-
-
Roman Gilg authored
Store space and input platform in base See merge request !227
-
- 27 Jul, 2022 20 commits
-
-
Roman Gilg authored
As with space store the input platform in base.
-
Roman Gilg authored
Move the functionality from the output class to a free function template. This way we can add additional parameters.
-
Roman Gilg authored
This way we don't need to access it via the global getter.
-
Roman Gilg authored
This allows to afterwards template the functions.
-
Roman Gilg authored
This way we don't need to access it via the global getter.
-
Roman Gilg authored
Move the D-Bus interface parts out into a separate object. This way we can template the manager class.
-
Roman Gilg authored
Prepare templating over the platform by defining selected functions in the header.
-
Roman Gilg authored
Instead of using Qt's ownership model.
-
Roman Gilg authored
Instead of accessing it via the global input getter.
-
Roman Gilg authored
The includes are not needed as we use templates. We need to fix the includes in other parts though afterwards.
-
Roman Gilg authored
Getting the platform via a reference but then accessing it as a pointer is confusing. Better just except the caller to provide a reference to the object.
-
Roman Gilg authored
This way we don't need to access the global getter.
-
Roman Gilg authored
Move the init functions of shortcuts out of the virtual desktop manager class and access the input platform through the space instead of using the global getter.
-
Roman Gilg authored
This allows later to make it a class template.
-
Roman Gilg authored
This will allow to call a non-member function on the receiver.
-
Roman Gilg authored
This way we don't have to access the type-unsafe sender function.
-
Roman Gilg authored
The slots and properties are not needed anymore since the D-Bus interface had been moved to a separate class.
-
Roman Gilg authored
Move it to a free function and add a template parameter on the input platform to not have to access the global getter.
-
Roman Gilg authored
Instead access it via dependency injection.
-
Roman Gilg authored
This way we don't need to access it via the global getter.
-