SSUSessionConfirmed: review if/why Alice sends invalid identity size and/or certificate length
Created by: anonimal
By submitting this issue, I confirm the following:
- I have read and understood the contributor guide.
- I have checked that the issue I am reporting can be replicated or that the feature I am suggesting is not present.
- I have checked opened or recently closed pull requests for existing solutions/implementations to my issue/suggestion.
Place an X inside the bracket to confirm
-
I confirm.
First noticed on our OSX 10.12 machine:
2016:11:04|DBG SSUServer: handling received data
2016:11:04|DBG SSUServer: receiving data
2016:11:04|DBG SSUServer: handling received packets
2016:11:04|DBG SSUSession: [] [IPv4 address] --> 1456 bytes transferred, 4259 total bytes received
2016:11:04|ERR IdentityEx: certificate length 23753 exceeds buffer length 83
Segmentation fault: 11
I was not running LLDB at the time but I've now attached all running kovri's that weren't previously attached.
If cert length exceeds buffer, we do return false but it's likely that, after the fact, we're not catching elsewhere (I'm not at my dev machine but can confirm later). IIRC, this is the first time I've seen this issue (we really should have more unit-tests in this area though where possible).
Referencing #366