alperezc commented on merge request !17 at KOTO L3 / L3 software

alperezc
2025-12-15T08:29:18Z

In Allen at LHCb we use unsigned throughout, I prefer it to unsigned int because as you say, it is the same thing, so having less code to read is better for me, but I have no hard feelings on this. However, If you want to go for explicit, we should change ints to int32_t/int16_t also?

Also, the reason for having a dedicated info_idx is because we are calculating the same offset (i_event * (288 * 16 * 3) + i_fadc * 16 * 3 + i_fadc_ch * 3) many times, and not only is this less maintainable, it makes reading the code harder. However, just to make sure, I did tests with and without the extra variable, to see if we should have the computation throughout or use one more register. As I expected, the compiler is smart enough to only perform the computation once and store it on a register, so might as well use that variable and clean the code