qa-test-tools don't pass t/00-testcritic.t
For some reason in my koha-testing-docker instance, I have qa-test-tools that popped at Koha's code root. Not a being deal, that should be useful for the future. But they are picked up by t/00-testcritic.t and causes errors.
Since it's code we might want to treat it as Koha's. Or maybe since it's a small sub project we might want to have the test ignore the qa-test-tools. So it would rather be a ticket like this: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25928
t/00-testcritic.t ....................................................... 169/?
# Failed test 'Test::Perl::Critic for "qa-test-tools/QohA/File/Template.pm"'
# at /usr/share/perl5/Test/Perl/Critic.pm line 121.
#
# "@files" is declared but not used at line 52, column 5. Unused variables clutter code and make it harder to read. (Severity: 3)
# Failed test 'Test::Perl::Critic for "qa-test-tools/QohA/File/Perl.pm"'
# at /usr/share/perl5/Test/Perl/Critic.pm line 121.
#
# "@ok" is declared but not used at line 58, column 5. Unused variables clutter code and make it harder to read. (Severity: 3)
# "@ko" is declared but not used at line 58, column 5. Unused variables clutter code and make it harder to read. (Severity: 3)
t/00-testcritic.t ....................................................... 196/?
# Failed test 'Test::Perl::Critic for "qa-test-tools/QohA/File/Specific/Kohastructure.pm"'
# at /usr/share/perl5/Test/Perl/Critic.pm line 121.
#
# Two-argument "open" used at line 26, column 5. See page 207 of PBP. (Severity: 5)
# Two-argument "open" used at line 56, column 5. See page 207 of PBP. (Severity: 5)
# Two-argument "open" used at line 95, column 5. See page 207 of PBP. (Severity: 5)
# Two-argument "open" used at line 121, column 9. See page 207 of PBP. (Severity: 5)
# Failed test 'Test::Perl::Critic for "qa-test-tools/QohA/File/Specific/OpacCss.pm"'
# at /usr/share/perl5/Test/Perl/Critic.pm line 121.
#
# Two-argument "open" used at line 24, column 5. See page 207 of PBP. (Severity: 5)
# "$fh" is declared but not used at line 24, column 12. Unused variables clutter code and make it harder to read. (Severity: 3)
# Failed test 'Test::Perl::Critic for "qa-test-tools/QohA/File/Specific/Sysprefs.pm"'
# at /usr/share/perl5/Test/Perl/Critic.pm line 121.
#
# Two-argument "open" used at line 22, column 5. See page 207 of PBP. (Severity: 5)
# Failed test 'Test::Perl::Critic for "qa-test-tools/qa-tools/git/pre-commit"'
# at /usr/share/perl5/Test/Perl/Critic.pm line 121.
#
# Two-argument "open" used at line 13, column 5. See page 207 of PBP. (Severity: 5)
t/00-testcritic.t ....................................................... 224/?
# Failed test 'Test::Perl::Critic for "qa-test-tools/koha-qa.pl"'
# at /usr/share/perl5/Test/Perl/Critic.pm line 121.
#
# Code before strictures are enabled at line 3, column 1. See page 429 of PBP. (Severity: 5)
# Failed test 'Test::Perl::Critic for "qa-test-tools/t/Perl.t"'
# at /usr/share/perl5/Test/Perl/Critic.pm line 121.
#
# "$dir_patch" is declared but not used at line 25, column 14. Unused variables clutter code and make it harder to read. (Severity: 3)
# Failed test 'Test::Perl::Critic for "qa-test-tools/t/data/2/perl/i_fail_critic.pl"'
# at /usr/share/perl5/Test/Perl/Critic.pm line 121.
#
# Bareword file handle opened at line 3, column 1. See pages 202,204 of PBP. (Severity: 5)
t/00-testcritic.t ....................................................... Dubious, test returned 1 (wstat 256, 0x100)
Failed 17/2124 subtests