joubu authored Jan 13, 2020 and joubu committed Jan 13, 2020

This will not catch 100% of the problematic cases, but most of them.

joubu authored Aug 14, 2019 and joubu committed Aug 14, 2019

To make the tests pass

joubu authored Jun 22, 2019 and joubu committed Aug 07, 2019

This patch will ensure our SQL12 coding guideline.
https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL12:_Booleans

Test plan:
0/ Go to your Koha repo
1/ Modify kohastructure.sql and add a new column with the type BOOLEAN
2/ Commit and execute the QA script
=> New check boolean_vs_tinyint will fail
3/ Replace the type with TINYINT(1)
4/ Commit and execute the QA script
=> New check tinyint_has_boolean_flag will fail
5/ Edit the relevant schema file to tell DBIx::Class that this new column is a boolean
6/ Commit and execute the QA script
=> Success!

This reverts commit 4e076f26.

Tests were failing, see also bug 21892
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892

joubu authored May 08, 2019 and joubu committed May 10, 2019

Prevent badly formed Signed-off-by lines, author's names or
email address to be pushed.

joubu authored Mar 03, 2019 and joubu committed Mar 06, 2019

We can be more exact search for ^

joubu authored Feb 22, 2019 and joubu committed Mar 02, 2019

We should not use this hash, we lost the order set by the checks

Test plan:
edit a template file, remove all the '| html' filter
commit
run the QA script

Mark Tompsett authored Nov 27, 2018 and joubu committed Dec 05, 2018

1) without this patch applied to your qa-test-tools
   run the test plans for the first two patches
-- both should fail, with just 1 applied, and both applied
   to your kohaclone.
2) apply this patch to your qa-test-tools
3) rerun the test plans for the first two patches
-- just 1 applied should now pass, but both applied should
   still fail.

Issue 6

See merge request !5

joubu authored Sep 21, 2018 and joubu committed Sep 21, 2018

Bug 21393
(https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21393) will
let us reuse the code to catch missing filters in templates.

Test plan:
- Apply patches from 21393
- Add a new commit to your Koha codebase with variables that are not
escaped, run the QA script
=> Failures on new "filters" check
- Add a new commit with correctly escaped variables
=> No failure
- run the tests from qa-test-tools (prove t)
=> Return green

- Checkout a Koha master branch (so without 21393 assuming it's not
pushed yet)
- Run the QA script
=> The next "filters" check is skipped (module does not exist)
Note: the qa-test-tools tests will fail but I do not think we should
spend time on that

Julian Maurice authored Sep 19, 2018 and joubu committed Sep 19, 2018

The first pass is 0, not 1

Julian Maurice authored Apr 12, 2018 and joubu committed Apr 13, 2018

Koha::Template::Plugin::Asset needs them

joubu authored Apr 04, 2018 and joubu committed Apr 04, 2018

https://wiki.koha-community.org/wiki/Commit_messages

joubu authored Jan 22, 2018 and joubu committed Jan 22, 2018

But fail since
  Bug 19760: Die if koha-conf is not accessible

joubu authored Jan 22, 2018 and joubu committed Jan 22, 2018

Test output has not been updated in previous commit

joubu authored Jan 22, 2018 and joubu committed Jan 22, 2018

Fix silly conditions

Josef Moravec authored Dec 08, 2017 and joubu committed Dec 12, 2017

Test plan:

0) Have commit which touches any file in /svc /opac/svc or /opac/unapi,
    you can use bug 19439 and bug 19496, or just create your own commit
1) Run QA tools on this commit
2) There should be report for this files

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.com>

joubu authored Jun 01, 2017 and joubu committed Jun 01, 2017

If set the ouput will only display tests that fail for a given file.
The filenames will still be displayed even if all tests pass.

This is only useful when used with -v 2

That breaks our translate script
See bug 18675.