• joubu's avatar
    Bug 17323: Column search_history.time cannot be null · 6d5b056a
    joubu authored
    When doing a search, with SearchHistory pref switched on:
    
    DBD::mysql::st execute failed: Column 'time' cannot be null [for Statement "
            INSERT INTO search_history(
                userid, sessionid, query_desc, query_cgi, type, total, time
            ) VALUES(
                ?, ?, ?, ?, ?, ?, ?
            )
        " with ParamValues: 0="7874", 1='12338a0bd8da63e32c79ee84f8493a07', 2="kw,wrdl: d", 3='q=d', 4='biblio', 5=6104, 6=undef] at C4/Search/History.pm line 34.
    
    Since MySLQ 5.7, undef does not mean "the default value".
    To let the DBMS set the default value (CURRENT_TIMESTAMP), the parameter should not be passed
    
    Test plan:
    OPAC+Intranet, swith the 2 SearchHistory syspref on
    Do a search
    => Without this patch, you will get an error in the log and the row will not be inserted in the table.
    => With this patch, everything must go fine
    Signed-off-by: 's avatarChris Cormack <chrisc@catalyst.net.nz>
    Signed-off-by: 's avatarMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
    Not verified with MySQL 5.7. But this looks good to me.
    Works under Jessie.
    Signed-off-by: 's avatarKyle M Hall <kyle@bywatersolutions.com>
    6d5b056a
Name
Last commit
Last update
..
History.pm Loading commit data...
PazPar2.pm Loading commit data...