This project is mirrored from git://git.koha-community.org/koha.git. Updated .
  1. 08 Jul, 2016 1 commit
  2. 21 Jun, 2016 1 commit
    • Marc Véron's avatar
      Bug 16747 - Patron card creator broken with version 16.05 · 87dbed0a
      Marc Véron authored
      To reproduce:
      - Prepare a patron car layout with Image 1 using Patron Image
      - Create a patron card for a patron without patron image
      Result: OK, PDF can be opened wit PDF viewer
      - Try to create a patron card with a patron who has a patron image
      Result: The PDF file is corrupt (contains text only with error message)
              intranet error log contains: create-pdf.pl: Illegal division
              by zero at /usr/share/kohaclone/patroncards/create-pdf.pl line 200
      To test:
      - Apply patch
      - Create a patron card with a patron who has a patron image
      Result: PDF is OK and contains the image
      
      Bonus test: Do the same with a card layout with an additional image
      (Image 2: Image source: Other image)
      Signed-off-by: default avatarOwen Leonard <oleonard@myacpl.org>
      
      Test and bonus test pass: PDF generated without errors.
      Signed-off-by: default avatarKyle M Hall <kyle@bywatersolutions.com>
      Signed-off-by: default avatarBrendan Gallagher <brendan@bywatersolutions.com>
      87dbed0a
  3. 29 Apr, 2016 1 commit
  4. 26 Apr, 2016 3 commits
  5. 22 Mar, 2016 1 commit
  6. 04 Mar, 2016 1 commit
  7. 27 Jan, 2016 1 commit
  8. 31 Dec, 2015 1 commit
    • Marc Véron's avatar
      Bug 14131 - Patroncard: Add possibility to print from patron lists · 5b35435d
      Marc Véron authored
      This patch adds the possibility to print patron cards from patron lists.
      
      To test:
      
      - Go to Home > Tools > Patron card creator
      - Prepare a patron card and create some cards using the batch functionality
      - Apply patch
      - Prepare a patron list e.g. from patron search
      - Go to Home > Tools > Patron card creator > Manage batches
      - Below the list of batches you have a dropdown to select a patron list
      - Select your list and hit "Export from patron list"
      - Select template and layout as you would do with batches
      - Hit "Export"
      - Download PDF
      
      Modified patch to work with Bug 14676 changes. Functionality unchanged.
      Signed-off-by: default avatarNick Clemens <nick@quecheelibrary.org>
      Signed-off-by: Liz Rea's avatarLiz <wizzyrea@gmail.com>
      
      (Amended to make it apply on current master)
      
      Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com 
      5b35435d
  9. 17 Nov, 2015 1 commit
  10. 04 Nov, 2015 1 commit
    • Joonas Kylmälä's avatar
      Bug 14805: Allow the user to delete multiple batches · 808ec53c
      Joonas Kylmälä authored
      Allows the user to delete multiple patron card batches.
      
      Test plan:
      
      1. Add first some 20 batches
      2. Go to the edit page of some X batch by first selecting from the
         batch list the batch you want to edit and then after that by clicking
         edit.
      3. Delete one batch by selecting one batch and then clicking delete.
      4. Select 0 batches and click delete, notice you cannot delete.
      5. Select 0 batches and click edit, notice you cannot edit.
      6. Select 2 batches and click edit, notice you cannot edit.
      7. Apply patch
      8. Check that steps from 2-6 work like they worked before.
         (and add more batches so that you have ~20 of them)
      9. Select 2 batches and click delete. Make sure they are deleted.
      10. Try to figure out some anomalies this patch might have caused.
      
      Sponsored-by: Vaara-kirjastot
      
      Followed test plan, works as expected.
      Signed-off-by: default avatarMarc Véron <veron@veron.ch>
      Signed-off-by: joubu's avatarJonathan Druart <jonathan.druart@bugs.koha-community.org>
      Signed-off-by: default avatarTomas Cohen Arazi <tomascohen@theke.io>
      808ec53c
  11. 20 Oct, 2015 1 commit
    • Liz Rea's avatar
      Bug 14676: UI/UX improvements to patron card creator · 0d29051a
      Liz Rea authored
      Reasoning
      
      Librarians will be doing patron card things in the following frequencies, from most frequent to least frequent:
      1. Creating new patron card batches - every day/every few days
      2. Managing existing card batches - every day/every few days
      3. Managing existing card layouts - as needed, infrequent
      5. Managing existing card templates - as needed, infrequent
      6. Creating new card layouts - as needed, infrequent
      7. Creating new card templates - as needed, infrequent
      8. Managing existing printer profiles - possibly once only!
      9. Creating new printer profiles - possibly once only!
      
      This change to the patron card creator aims to make the most frequently used items easily accessible at the top of the main area,
      reduces clutter on the page, and makes the label creator fall in line with UI paradigms found elsewhere in Koha.
      I think I've also improved the translatability here somewhat, please check that.
      
      To test:
      
      Open the patron card creator: More -> Tools -> Patron card creator
      Note that the toolbar has changed. It should be consistent across all of the patron card creator (it is an include).
      
      + New menu:
      
      patron card batch
      1. make sure it looks ok - toolbar buttons are consistent at the top of the main block.
      2. add patrons both by borrowernumber, and by search
      3. note that the usual buttons have moved below the textarea, and now have icons.
      4. delete and export single patrons using the buttons corresponding to each patron
      5. select multiple and use the buttons above the table to remove and export selected patrons
      6. export a full batch
      7. deduplicate a batch
      There should be no regressions in functionality.
      
      Image
      1. This menu item should take you directly to the upload/delete images interface
      2. Upload an image, note success message is now below the form, eliminating the jumping box.
      3. Delete single images using the buttons
      4. Delete multiple images using the tickboxes and "Delete selected"
      5. Not deletion success message is below the table, eliminating the jumping box.
      
      Layout
      1. This menu item should take you directly to the "Edit layout" screen.
      2. no functional changes here.
      3. note toolbar at top is consistent
      
      Card template
      1. this menu item should take you directly to the "Edit patron card template" page.
      2. no functional changes here.
      3. note toolbar at top is consistent.
      
      Printer profile
      1. this menu item should take you directly to the "Edit printer profile" page.
      2. no functional changes here.
      3. note toolbar at top is consistent.
      
      + Manage menu:
      
      Card batches
      1. This menu item should take you directly to the "currently available batches" page.
      2. select a batch to edit using the buttons - it should take you to the editing interface
      3. select a batch to delete using the buttons - it should ask for confirm.
      4. select several batches using the tickboxes, and select Export selected. Batches should be exported as normal.
      5. note toolbar at top is consistent.
      
      Images (this is actually the same page as on the new menu, I included it in both because it does both functions - can change if requested)
      1. This menu item should take you directly to the upload/delete images interface
      2. Upload an image, note success message is now below the form, eliminating the jumping box.
      3. Delete single images using the buttons
      4. Delete multiple images using the tickboxes and "Delete selected"
      5. Not deletion success message is below the table, eliminating the jumping box.
      
      Layouts
      1. This menu item should take you directly to the "currently available layouts" page.
      2. select a layout to edit using the buttons
      3. select a layout to delete using the buttons
      4. note toolbar at top is consistent.
      
      Card templates
      1. This menu item should take you directly to the "currently available templates" page.
      2. select a template to edit using the buttons
      3. select a template to delete using the buttons
      4. note toolbar at top is consistent.
      
      Printer profiles
      1. This menu item should take you directly to the "currently available profiles" page.
      2. select a profile to edit using the buttons
      3. select a profile to delete using the buttons
      4. note toolbar at top is consistent
      
      + General
      * note that sidebar now only has "labels home" instead of the full "manage" list. It seemed redundant with the toolbar tidied up.
      
      Please note that I am happy to take suggestions/amendments to these changes.
      
      Followed test plan, behaves as advertised.
      Signed-off-by: default avatarMarc Véron <veron@veron.ch>
      Signed-off-by: joubu's avatarJonathan Druart <jonathan.druart@bugs.koha-community.org>
      Signed-off-by: default avatarTomas Cohen Arazi <tomascohen@theke.io>
      0d29051a
  12. 06 Oct, 2015 2 commits
    • joubu's avatar
      Bug 14739: Fix plack compatibility · a7818b35
      joubu authored
      perlcritic raised "Declare variables outside of the condition"
      
      Works as expected
      Signed-off-by: Josef Moravec's avatarJosef Moravec <josef.moravec@gmail.com>
      Signed-off-by: joubu's avatarJonathan Druart <jonathan.druart@bugs.koha-community.org>
      Signed-off-by: default avatarTomas Cohen Arazi <tomascohen@theke.io>
      a7818b35
    • Nick Clemens's avatar
      Bug 14739: Add several patrons to a new batch will create a new batch per patron added · a8a9c7b7
      Nick Clemens authored
      This patch changes the functionality of adding patrons to patroncard batches.  Instead of using only the patron search, there is now a textarea which can either be manually populated with borrowernumbers, or can be populated using the patron-search
      
      To test:
      1 - Create a new patron batch
      2 - Click the add items button, if there is no data in the borrowrnumber form you should get a popup
      3 - Add items to batch using the popup, borrowernumbers should populate to the form
      4 - Click add items again and items should be added to a new batch
      5 - Create a new batch
      6 - Manually enter invalid borrowernumbers to the form
      7 - Click add items, batch should return empty
      8 - Manually enter valid borrowernumber
      9 - Click add items, batch should be updated
      10 - Edit an existing batch and confirm add items works as above
      11 - Create a new label batch
      12 - Click add items with no data, popup item search should appear
      13 - Adding items by checking boxes or using 'Add' button - they should populate the text box on the edit batch page
      14 - When adding using form the 'Enter by itemnumber' button should be marked automatically
      15 - Submit items and confirm they are added to batch
      16 - Create a new batch, enter by barcode manually and check 'Enter by itemnumber"
      17 - Click add items, no items should be added
      18 - Repopulate form with barcodes, check 'Enter by barcode'
      19 - Click add items, items should be added correctly
      20 - Test various combinations of radio buttons and numbers and using form or not
      Signed-off-by: Barton Chittenden's avatarBarton Chittenden <barton@bywatersolutions.com>
      Signed-off-by: joubu's avatarJonathan Druart <jonathan.druart@bugs.koha-community.org>
      Signed-off-by: default avatarTomas Cohen Arazi <tomascohen@theke.io>
      a8a9c7b7
  13. 24 Jul, 2015 1 commit
  14. 08 Jul, 2015 1 commit
  15. 06 May, 2015 1 commit
    • Marc Véron's avatar
      Bug 14122: Patron card: Software error when creating using borrower_number as parameter from URL · a6247f44
      Marc Véron authored
      To test prepare an URL like the following:
      
      ...cgi-bin/koha/patroncards/create-pdf.pl?borrower_number=61&template_id=24&layout_id=21&start_card=1
      
      Change the values for borrower_number, template_id and layout_id to something that exists in your system.
      
      Without patch, the URL leads to a software error:
      Can't use an undefined value as a HASH reference at /usr/share/kohaclone/patroncards/create-pdf.pl line 118.
      
      With patch, a PDF with the patron card is created.
      Signed-off-by: Mark Tompsett's avatarMark Tompsett <mtompset@hotmail.com>
      
      NOTE: This does NOT deal with the case where borrowernumber,
      template_id, or layout_id are invalid. This only deals with
      the case where they do exist.
      
      Invalid borrowernumber still gives same error.
      Invalid template_id or layout_id gives error on line 111.
      Those are beyond the scope of this bug.
      Signed-off-by: Katrin Fischer's avatarKatrin Fischer <katrin.fischer.83@web.de>
      Signed-off-by: Tomas Cohen Arazi's avatarTomas Cohen Arazi <tomascohen@gmail.com>
      a6247f44
  16. 20 Apr, 2015 1 commit
  17. 13 Apr, 2015 2 commits
  18. 09 Apr, 2015 1 commit
    • Marc Véron's avatar
      Bug 8796 - patron cards not starting on designated card · 4f601380
      Marc Véron authored
      The patron cards always printed from position 1 on the print form, because patroncards/create-pdf.pl expected start_label as parameter and got star_card instead.
      
      To verify and test:
      1)
      Go to Home > Tools >Patron card creator >Manage batches
      2)
      Select a batch anc click "Export"
      
      3)
      Set "Enter starting card number" e.g. to 5
      4)
      Export
      5)
      Download PDF and view it
      
      Result: The first card is always printed on position 1 (top left) instead of position 5.
      
      Apply patch
      Repeat steps above
      Step 3) should now read "Enter starting card position"
      
      Result after step 5)
      The first card ist printed at the correct position on the printing form.
      Signed-off-by: Josef Moravec's avatarJosef Moravec <josef.moravec@gmail.com>
      
      Works as expected
      Signed-off-by: Katrin Fischer's avatarKatrin Fischer <katrin.fischer.83@web.de>
      
      Rebased for current master and tested. /MV
      Signed-off-by: Tomas Cohen Arazi's avatarTomas Cohen Arazi <tomascohen@gmail.com>
      4f601380
  19. 08 Apr, 2015 1 commit
  20. 12 Feb, 2015 1 commit
    • Kyle M Hall's avatar
      Bug 13189 - Patron card creator patron search browse by last name broken by extended attributes · b2ccd0f3
      Kyle M Hall authored
      The browse by last name letters on the patron search for the patron card
      creator doesn't work quite right. If extended patron attributes are
      disabled, it works fine, but if they are enabled, they are searched even
      when using the browse last name. Thus, if a searchable attribute has a
      "D" in it, and one clicks the "D" link for the last name browser, that
      patron will show even if he or she has no "D" in his or her hame!
      
      Test Plan:
      1) Enable extended patron attributes
      2) Add a new searchable patron attribute
      3) Create a new patron with the last name "Ace"
      4) Add the value "D" to the attribute for this patron
      5) Browse to the patron card maker, start a new patron batch
      6) Click "Add item(s)" to bring up the patron search
      7) Click the letter "D" in the patron search box
      8) Note that "Ace" shows in the results list
      9) Apply this patch
      10) Repeat step 7
      11) Note that "Ace" no longer shows in the results list
      12) Perform a regular search by putting the letter "D" in the "Name:"
          field, and hit the "Search" button
      13) Note this time the results *do* have Ace in them
      Signed-off-by: Frédéric Demians's avatarFrederic Demians <f.demians@tamil.fr>
        Well described for a tricky bug. Reproducible. Fixed with this patch.
      Signed-off-by: Katrin Fischer's avatarKatrin Fischer <katrin.fischer.83@web.de>
      This works as described, no problems or regressions found.
      b2ccd0f3
  21. 13 Jan, 2015 1 commit
  22. 10 Aug, 2014 1 commit
    • Owen Leonard's avatar
      Bug 5502 - Patron card category search field should be menu · 0ddeabd3
      Owen Leonard authored
      When searching for patrons to add to a patron card creator batch there
      is a text input field for submitting a patron category. This should be a
      dropdown menu. This patch corrects it.
      
      To test, go to Tools -> Patron card creator and click "New batch."
       - Click the "Add item(s)" button.
       - Confirm that in the Patron search pop-up window there is a dropdown
         menu populated with existing patron categories.
       - Confirm that searches limited by patron category return correct
         results.
       - Confirm that the correct patron category is automatically preselected
         after performing a search limited by category.
       - Confirm that reordering the table of search results works correctly.
      Signed-off-by: Aleisha Amohia's avatarAleisha <aleishaamohia@hotmail.com>
      Signed-off-by: default avatarKyle M Hall <kyle@bywatersolutions.com>
      Signed-off-by: Tomas Cohen Arazi's avatarTomas Cohen Arazi <tomascohen@gmail.com>
      0ddeabd3
  23. 17 Jul, 2014 1 commit
  24. 14 Oct, 2013 1 commit
  25. 08 Sep, 2013 1 commit
    • Galen Charlton's avatar
      Bug 9924: (follow-up) ensure that correct error message is displayed · 46bbfa12
      Galen Charlton authored
      (Apparently) unlike HTML::Template::Pro, Template Toolkit doesn't like
      template variables that are entirely numeric -- in conditionals, it
      consider them integers, most of which are Perl true.
      
      This patch changes this by setting the error variable to the error
      value.
      
      To test:
      
      [1] Run the test plan from the previous patch.  In each
          case, verify that the error message is specifically applicable
          to the test.  For example, if you try uplaoading a patron image
          that is larger than 500KB, the error message displayed should
          specifically say so.
      Signed-off-by: Galen Charlton's avatarGalen Charlton <gmc@esilibrary.com>
      Signed-off-by: Katrin Fischer's avatarKatrin Fischer <Katrin.Fischer.83@web.de>
      Thank you Galen for catching this. Error messages showing up
      now are much more specific and according to the error codes given.
      I testd uploading a file larger then 500KB and triggered several
      error messages giving the error code in the URL:
      /cgi-bin/koha/patroncards/manage.pl?card_element=profile&error=201
      
      All tests and QA script pass.
      Signed-off-by: Galen Charlton's avatarGalen Charlton <gmc@esilibrary.com>
      46bbfa12
  26. 12 Jul, 2013 1 commit
  27. 29 Apr, 2013 1 commit
  28. 20 Apr, 2013 1 commit
  29. 13 Mar, 2013 1 commit
  30. 13 Jul, 2012 1 commit
  31. 27 Feb, 2012 1 commit
  32. 19 Oct, 2011 1 commit
    • Srdjan Jankovic's avatar
      bug_6253: Unified member Search() · 18b8991c
      Srdjan Jankovic authored
      Removed SearchMembers() and replaced with more generic Search()
      Amended Search() to try cardnumber first
      Replaced SearchMembers() calls with Search()
      Replaced SELECT with Search() where appropriate
      C4::SQLHelper:
      - added support for '' key for search filter.
      - when passing an array to filter, join with OR (rather than AND)
      - added support for key => [val1, val2] in filter
      - did not document - there was no input documentation to start with,
        and SQLHelper should be replaced with something better anyway
      Signed-off-by: default avatarLiz Rea <lrea@nekls.org>
      (again - testing merge issue)
      The functionality of the patch seems to be maintained with Biblibre's changes.
      
      I tested the following:
      Extended attribute searching: works
      3 part name searching: works
      2 part name searching: works
      1 part name searching: works
      
      From:
      mainpage.pl
      members-home.pl
      	Patron search limited by branch: Works
      	Patron search limited by patron category: works
      	Ordering by cardnumber instead of surname: works
      The "Check Out" field in the masthead.
      
      Circ Autocomplete is not reliably functional at this time, but the problem appears to predate this patch.
      Signed-off-by: default avatarIan Walls <ian.walls@bywatersolutions.com>
      Signed-off-by: default avatarChris Cormack <chrisc@catalyst.net.nz>
      18b8991c
  33. 28 Sep, 2011 1 commit
  34. 01 Aug, 2011 1 commit
  35. 29 May, 2011 1 commit
  36. 07 Apr, 2011 1 commit