Commit a5485b65 authored by Marcel de Rooy's avatar Marcel de Rooy Committed by Kyle M Hall

Bug 17866: Change sender for serial claim notifications

Currently, the From field uses the emailaddress of the staff client member
from the user context. This is exceptional in Koha. And might very well be,
as in our case, the cause of fraud detection warnings.
We should use branch email address or fallback to KohaAdminEmailAddress,
as we do (almost) everywhere else.

Test plan:
Go to subscription detail in Koha.
Go to Claims.
Select a missing issue and click Send notification.
Verify the sender address in the generated notification. (Make sure that
you receive this mail.)
Signed-off-by: Grace's avatarGrace McKenzie <grace.mcky@gmail.com>
Signed-off-by: joubu's avatarJonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: default avatarKyle M Hall <kyle@bywatersolutions.com>
parent d2ee53fb
......@@ -572,10 +572,11 @@ sub SendAlerts {
$letter->{content} =~ s/<order>(.*?)<\/order>/$1/gxms;
# ... then send mail
my $library = Koha::Libraries->find( $userenv->{branch} );
my %mail = (
To => join( ',', @email),
Cc => join( ',', @cc),
From => $userenv->{emailaddress},
From => $library->branchemail || C4::Context->preference('KohaAdminEmailAddress'),
Subject => Encode::encode( "UTF-8", "" . $letter->{title} ),
Message => $letter->{'is_html'}
? _wrap_html( Encode::encode( "UTF-8", $letter->{'content'} ),
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment