Commit 0a366e19 authored by joubu's avatar joubu Committed by Galen Charlton

Bug 11209: (follow-up) check if a notice has been already sent today

The previous patch checks if a notice has already been sent when the
current notices has been sent in queue. Which is wrong!
We have to check if a similar notice has been sent today.

This patch has been created after an observation on a production server:
If a user place on holds several items, he will receive 1 SMS per hold.
Here we only want 1 SMS for all holds.
Signed-off-by: default avatarChris Cormack <>
Signed-off-by: default avatarMarcel de Rooy <>
Signed-off-by: Galen Charlton's avatarGalen Charlton <>
parent 159e99f3
......@@ -1033,9 +1033,9 @@ sub _is_duplicate {
WHERE message_transport_type = ?
AND borrowernumber = ?
AND letter_code = ?
AND CAST(time_queued AS date) = CAST(? AS date)
AND CAST(time_queued AS date) = CAST(NOW() AS date)
AND status="sent"
|, {}, $message->{message_transport_type}, $message->{borrowernumber}, $message->{letter_code}, $message->{time_queued} );
|, {}, $message->{message_transport_type}, $message->{borrowernumber}, $message->{letter_code} );
return $count;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment