Commit 002a2dcb authored by Marc Véron's avatar Marc Véron Committed by Kyle M Hall

Bug 15429 - sub _parseletter should not change referenced values

In C4/, sub _parseletter changes values that are passed by
reference. E.g. patron's expiry date can change from iso format to
syspref format, leading to strange behaviour in the calling routines
(see Bug 15423).

This patch makes sub _parseletter work on a copy of the referenced values.

(Submitted to get feedback - is this the way to go?)
Signed-off-by: Frédéric Demians's avatarFrédéric Demians <>
  Good solution to real time bomb.
Signed-off-by: joubu's avatarJonathan Druart <>
Signed-off-by: default avatarKyle M Hall <>
parent 976d715a
......@@ -790,14 +790,18 @@ sub _parseletter_sth {
parameters :
- $letter : a hash to letter fields (title & content useful)
- $table : the Koha table to parse.
- $values : table record hashref
- $values_in : table record hashref
parse all fields from a table, and replace values in title & content with the appropriate value
(not exported sub, used only internally)
sub _parseletter {
my ( $letter, $table, $values ) = @_;
my ( $letter, $table, $values_in ) = @_;
# Work on a local copy of $values_in (passed by reference) to avoid side effects
# in callers ( by changing / formatting values )
my $values = { %$values_in };
if ( $table eq 'borrowers' && $values->{'dateexpiry'} ){
$values->{'dateexpiry'} = format_sqldatetime( $values->{'dateexpiry'} );
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment