• Julian Maurice's avatar
    Bug 20538: Remove the need of writing [% KOHA_VERSION %] everywhere · ed754328
    Julian Maurice authored
    Having to write [% KOHA_VERSION %] for each url is bad because:
    - It's easily forgettable when adding new <script> or <link>
    - It prevents grep'ing for the full filename
    - It violates the DRY principle
    - If at some point we want to change the "force js and css reload"
      mechanism, it will be tedious
    This patch:
    - adds a Template::Toolkit plugin that generates <script> and
      <link> tags for JS and CSS files, and inserts automatically the Koha
      version in the filename
    - use the new plugin to remove all occurences of [% KOHA_VERSION %]
    - remove the code that was adding KOHA_VERSION as a template variable
    Test plan:
    1. Apply patch
    2. Go to several different pages in Koha (opac and intranet) while
       checking your browser's dev tools (there should be no 404 for JS and
       CSS files, and the Koha version should appear in filenames) and the
       server logs (there should be no "File not found")
    3. `git grep KOHA_VERSION` should return nothing
    4. prove t/db_dependent/Koha/Template/Plugin/Asset.t
    Signed-off-by: Josef Moravec's avatarJosef Moravec <josef.moravec@gmail.com>
    Signed-off-by: Katrin Fischer's avatarKatrin Fischer <katrin.fischer.83@web.de>
    Signed-off-by: joubu's avatarJonathan Druart <jonathan.druart@bugs.koha-community.org>
Templates.pm 12.3 KB