• Marcel de Rooy's avatar
    Bug 19096: Make Default authoritative in core modules · 590cae04
    Marcel de Rooy authored
    After feedback from the dev mailing list, it seems appropriate here to
    propose making the Default framework authoritative for Koha to MARC
    mappings. This implies checking only the Default framework in the
    routines:
    
    [1] GetMarcFromKohaField: The parameter frameworkcode is removed. A
        follow-up report (19097) will update the calls not adjusted here.
        This is safe since the parameter is silently ignored.
    [2] GetMarcSubfieldStructureFromKohaField: Framework parameter is removed
        and calls are adjusted. Includes acquisitions_stats.pl.
    [3] TransformKohaToMarc: The parameter is removed; all calls are verified
        or adjusted.
    [4] TransformMarcToKoha: The parameter is no longer used and will be
        removed in a follow-up report (19097). It always goes to Default now.
    [5] TransformMarcToKohaOneField: The parameter is removed and all calls
        are adjusted. Including: Breeding, XISBN and MetadataRecord modules.
    [6] C4::Koha::IsKohaFieldLinked: This routine was called only once (in
        C4::Items::_build_default_values_for_mod_marc. It can be replaced by
        calling GetMarcFromKohaField. If there is no kohafield linked, undef
        is returned. (Corresponding unit test is removed here.)
    [7] C4::Items::ModItemFromMarc: The helper routine
        _build_default_values_for_mod_marc does no longer have a framework
        parameter. The cache key default_value_for_mod_marc- is no longer
        combined with a frameworkcode. Three admin scripts are adjusted
        accordingly; some tests will be corrected in the next patch.
    
    Test plan:
    See next patch. That patch adjusts all tests involved.
    Signed-off-by: Josef Moravec's avatarJosef Moravec <josef.moravec@gmail.com>
    Signed-off-by: 's avatarKyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: joubu's avatarJonathan Druart <jonathan.druart@bugs.koha-community.org>
    590cae04
Breeding.pm 24.6 KB