Skip to content
  • Colin Campbell's avatar
    Bug 11480: Fix invalid assumptions in JSONStream test · 732ad864
    Colin Campbell authored
    
    
    Tests for C4::Output::JSONStream made the invalid assumption
    that the hash keys of the modules internal structure
    will always be returned in the same sequence.
    A hash is an unordered structure. as of perl 5.18
    this has beem reinforced by random seeding of the
    hashing function. See the info in perldelta and
    the doc for JSON.
    
    This patch changes the tests to be sequence-neutral
    where the previous test was testing that a new element
    was added and an existing one was untouched these have
    been separated into individual tests.
    
    Some typos in the messages have been corrected
    
    Signed-off-by: default avatarChris Cormack <chris@bigballofwax.co.nz>
    
    Test Plan
    
    1/ Run t/Output_JSONStream.t , 8 tests should pass (or perhaps fail,
       but inconsistently under perl 5.18 or greater)
    2/ Apply patch
    3/ Run t/Output_JSONStream.t 10 tests should pass now
    
    Signed-off-by: default avatarKyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: default avatarGalen Charlton <gmc@esilibrary.com>
    732ad864