Skip to content
  • joubu's avatar
    Bug 15629: Koha::Libraries - Remove GetBranchDetail · 4f521731
    joubu authored
    
    
    C4::Branch::GetBranchDetail retrieved library infos, it could be easily
    replaced with Koha::Libraries->find
    
    When this change needs other big changes, the unblessed method is
    called, to manipulate a hashref (as before) instead of a Koha::Library
    object (for instance when $library is sent to GetPreparedLetter).
    
    Test plan:
    1/ Print a basket group, the library names should be correctly
    displayed.
    2/ Enable emailLibrarianWhenHoldIsPlaced and place a hold, a HOLDPLACED
    notice will be generated (focus on the library name)
    3/ Edit a patron and change his/her library
    4/ Generate the advanced notices (misc/cronjobs/advance_notices.pl) and
    have a look at the generated notices
    5/ Same of overdues notices
    6/ Set IndependentBranches and use a non superlibrarian user to place a
    hold. The "pickup at" should be correctly filled.
    
    Signed-off-by: default avatarOwen Leonard <oleonard@myacpl.org>
    
    Signed-off-by: default avatarKyle M Hall <kyle@bywatersolutions.com>
    
    Signed-off-by: default avatarBrendan Gallagher <brendan@bywatersolutions.com>
    4f521731