This project is mirrored from https://git.koha-community.org/Koha-community/Koha.git. Pull mirroring updated .
  1. 02 Dec, 2021 15 commits
  2. 26 Nov, 2021 9 commits
  3. 25 Nov, 2021 6 commits
  4. 24 Nov, 2021 4 commits
    • Joonas Kylmälä's avatar
      Bug 29381: Prevent sending of automatic renewal messages on every cron run · 92dce646
      Joonas Kylmälä authored and joubu's avatar joubu committed
      
      
      Currently the auto-renewal digest messages are sent on every cron run
      even if there was nothing to renew or no renewal errors.
      
      This regression was introduced in the commit "Bug 18532: Add
      individual issues to digest notice and hide auto_renewals messaging
      preference when not needed".
      
      To test:
       1) set syspref AutoRenewalNotices to be according to patron
          preferences
       2) Enable renewal digest messages on a patron's messaging preferences
       3) Checkout a book for patron, during the checkout use the Checkout
       settings menu to check the box "Automatic renewal"
       4) Run
          $ perl misc/cronjobs/automatic_renewals.pl --send-notices --confirm --digest-per-branch
          $ perl misc/cronjobs/automatic_renewals.pl --send-notices --confirm --digest-per-branch
       5) Notice you have now two renewal messages for the patron
       6) Apply patch
       7) repeat step 4) and notice you don't get anymore these unnecessary
          renewal messages
      Signed-off-by: David Nind's avatarDavid Nind <david@davidnind.com>
      Signed-off-by: Wm. Nick Clemens's avatarNick Clemens <nick@bywatersolutions.com>
      Signed-off-by: joubu's avatarJonathan Druart <jonathan.druart@bugs.koha-community.org>
      92dce646
    • joubu's avatar
      Bug 29524: (bug 28935 follow-up) Restore modification of some patron's attributes · ee76f80a
      joubu authored
      On
        commit 5f37d8d2
      
      
        Bug 28935: No filtering on patron's data on member entry pages
      we restricted the list of the columns from the borrowers table that can
      be modified from the patron edit view.
      We were too restrictive, the following 3 attributes can be edited from
      this form: privacy_guarantor_fines, privacy_guarantor_checkouts,
      checkprevcheckout and lang
      
      Test plan:
      Turn on the following prefs:
      - AllowStaffToSetFinesVisibilityForGuarantor
      - AllowStaffToSetCheckoutsVisibilityForGuarantor
      - CheckPrevCheckout (set to 'unless overridden *')
      - TranslateNotices
      Edit a patron and see the 4 different options are now displayed.
      Change their value, save, edit again
      Confirm that the values have been saved
      Signed-off-by: Owen Leonard's avatarOwen Leonard <oleonard@myacpl.org>
      Signed-off-by: Kyle M Hall's avatarKyle M Hall <kyle@bywatersolutions.com>
      Signed-off-by: joubu's avatarJonathan Druart <jonathan.druart@bugs.koha-community.org>
      ee76f80a
    • joubu's avatar
      Bug 29565: Prevent regressions.t to fail on slow boxes · 53956232
      joubu authored
      
      
      It's failing randomly on some Jenkins' nodes
      
       #   Failed test 'Encoding in session variables'
       #   at t/db_dependent/selenium/regressions.t line 300.
       Can't call method "get_text" on an undefined value at t/db_dependent/selenium/regressions.t line 285.
      
      It can be recreated locally with the following changes:
      @ t/lib/Selenium.pm:50 @ sub new {
           );
           bless $self, $class;
           $self->add_error_handler;
      -    $self->driver->set_implicit_wait_timeout(5000);
      +    $self->driver->set_implicit_wait_timeout(1000);
           return $self;
       }
      
      @ t/lib/Selenium.pm:50 @ sub new {
           );
           bless $self, $class;
           $self->add_error_handler;
      -    $self->driver->set_implicit_wait_timeout(5000);
      +    $self->driver->set_implicit_wait_timeout(1000);
           return $self;
       }
      
      This patch suggests to simply double the timeout.
      Signed-off-by: joubu's avatarJonathan Druart <jonathan.druart@bugs.koha-community.org>
      53956232
    • joubu's avatar
      Bug 29485: (follow-up) Trying to prevent administration_tasks.t to fail randomly · 65edbe5a
      joubu authored
      Recreated the problem after run #47
      Error while executing command: no such element: Unable to locate element: //*[@id
      
      ="userid"] at /usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm line 411.
      
      With this patch I do not longer recreate the failure. It's ugly but,
      well, I don't have any other solutions. It seems that the accept_alert
      is taking too long and is async (??)
      Signed-off-by: joubu's avatarJonathan Druart <jonathan.druart@bugs.koha-community.org>
      65edbe5a
  5. 22 Nov, 2021 6 commits