RF_Module: Issues in HOPERF_RFM9XW_THT
During my inspection I've found the following problems:
- Pin 1 is circular (Should be squared instead);
- Holes drill size is 0.762mm (Should be 0.8 mm, as per datasheet);
- F.SilkS thickness is 0.1mm (The current recommended value is 0.12 mm, as per KLC);
- F.Fab thickness is 0.12mm (The current recommended value is 0.1 mm, as per KLC);
- F.CrtYd is 0.33 mm away from body edge of the footprint (The current recommended value is 0.25 mm, as per KLC);
- Missing pin 1 indication at F.SilkS layer
- Outdated manufacturer datasheet link (broken) Current: http://www.hoperf.com/upload/rf/RFM95_96_97_98W.pdf Updated: https://www.hoperf.com/data/upload/portal/20181127/5bfcbea20e9ef.pdf
- Holes groups are 12.8mm away from each other (The correct value is 13.6mm).
The correct distance information is missing in the RFM9X series datasheet. I found the correct distance in the datasheet from a similar product of the same manufacturer; RFM69HCW (https://www.hoperf.com/data/upload/portal/20181127/5bfcb8284d838.pdf).
I've provided the due corrections and I intend to open a PR.
Otavio Augusto