Wrong fill color for shapes in symbol editor
Description
I've found that when editing a symbol I cannot properly set the fill style for shapes anymore. This is the behavior I'm getting:
- Do not fill: Does not fill the shape
- Fill with body outline color: Does not fill the shape
- Fill with body background color: Fills with outline color
Steps to reproduce
- Open symbol editor
- Create a shape, for example a rectangle
- Double click the shape and try to change between the different fill styles
Findings
I have been taking a look to the source and I believe this issue could be caused by changes made to file "eeschema/dialogs/dialog_lib_shape_properties.cpp" on commit b5252952, most likely around the dynamic_cast
between LIB_SYMBOL
and EDA_SHAPE
.
Apologies in advance if my findings are wrong, I'm still working my way to get familiar with code, so I can some day become a contributor.
KiCad Version
Application: KiCad Symbol Editor
Version: (5.99.0-12828-g57d0cbce), release build
Libraries: wxWidgets 3.0.5 libcurl/7.79.1 OpenSSL/1.1.1l zlib/1.2.11 brotli/1.0.9 zstd/1.5.0 libidn2/2.3.2 libpsl/0.21.1 (+libidn2/2.3.0) libssh2/1.9.0 nghttp2/1.45.1
Platform: Linux 5.14.12-arch1-1 x86_64, 64 bit, Little endian, wxGTK, KDE, x11
Build Info: Date: Oct 15 2021 22:13:18 wxWidgets: 3.0.5 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24 Boost: 1.76.0 OCC: 7.5.0 Curl: 7.79.1 ngspice: 35 Compiler: GCC 11.1.0 with C++ ABI 1016
Build settings: KICAD_USE_OCC=ON KICAD_SPICE=ON