eeschema: rename subsheet-files fails with file-string-dialog

Description

For renaming of subsheet-files there are two ways:

  1. with Sheet-properties dialog: works
  2. with double-click on the filename (usually below the subsheet-rectangle) I get the "Edit Sheet File Field" dialog. This way doesn't work and produces no new copied schematic file.

I think this may be part of the problems in #8620 (closed).

Steps to reproduce

prerequisites: have a kicad-project with a non-empty subsheet named "Sheet1"

working version with Sheet-properties-window:

  1. select subsheet-rectangle, press hotkey "E" for edit
  2. get Sheet properties dialog, change second row to filename "Sheet21.kicad_sch"
  3. click OK
  4. get question-message to create/copy a new schematic file
  5. confirm with YES - I have a new file and all works well

nonworking version with doubleclick subsheet-filename:

  1. select subsheet-filename below subsheet-rectangle
  2. press "E" to get the "Edit Sheet File Field"-dialog (seems like a standard string-dialog)
  3. change filename to "Sheet21.kicad_sch"
  4. click OK. The string-dialog closes, observe:
  5. None of the "would you like to copy?" messages as above (working version, step4)
  6. look at the file-system, no new file "Sheet21.kicad_sch" created
  7. but the string for the filename is changed
  8. on doubleclicking the subsheet the subsheet opens: on the titlebar it shows the old original filename "Sheet1"

Look at the pictures below: first working version (Sheet properties dialog), below non-working version

rename_edit_dialog

rename_filenamestring

KiCad Version

Application: KiCad Schematic Editor (64-bit)

Version: (5.99.0-12387-g847c9e32c8), release build

Libraries:
	wxWidgets 3.1.5

Platform: Windows 10 (build 19041), 64-bit edition, 64 bit, Little endian, wxMSW

	wxWidgets: 3.1.5 (wchar_t,wx containers)
	Boost: 1.76.0
	OCC: 7.5.0
	Curl: 7.78.0-DEV
	ngspice: 35
	Compiler: Visual C++ 1929 without C++ ABI

Build settings:
	KICAD_USE_OCC=ON
	KICAD_SPICE=ON