pcbnew: "Add a dimension" starts drawing a dimension in inches, even if "mm" is selected as unit (master branch).
Description
"Add a dimension" starts drawing a dimension in inches, even if "mm" is selected as unit. Expected behaviour:
- Have new dimensions quoted in mm if "mm" is selected and inches if "inch" is selected when starting to draw it (this is the current 5.1.5 behaviour).
OR/AND - Have a way to change between inches and mm during the draw operation (using the default shortcut CTRL-U that changes unit and/or having an item in the right-click pop-up menu while drawing the dimension)
Steps to reproduce
- Create a new project/pcb
- add a dimension
- switch units
- add a dimension In both cases dimensions are in inches.
Please copy version information (from About KiCad -> Copy Version Info) and paste it here.
KiCad Version
Master branch: affected
Stable branch: Not affected (tested on 5.1.5)
Note: "dirty" build since the patch from (lp:#1842906) has been applied.
Application: Pcbnew
Version: (5.99.0-501-ged025972a-dirty), release build
Libraries:
wxWidgets 3.0.2
libcurl/7.52.1 GnuTLS/3.5.8 zlib/1.2.8 libidn2/0.16 libpsl/0.17.0 (+libidn2/0.16) libssh2/1.7.0 nghttp2/1.18.1 librtmp/2.3
Platform: Linux 4.9.0-8-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
Build date: Dec 12 2019 07:28:04
wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
Boost: 1.69.0
OpenCASCADE Community Edition: 6.8.0
Curl: 7.52.1
Compiler: GCC 6.3.0 with C++ ABI 1010
Build settings:
KICAD_SCRIPTING=ON
KICAD_SCRIPTING_MODULES=ON
KICAD_SCRIPTING_PYTHON3=OFF
KICAD_SCRIPTING_WXPYTHON=ON
KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
KICAD_SCRIPTING_ACTION_MENU=ON
BUILD_GITHUB_PLUGIN=ON
KICAD_USE_OCE=ON
KICAD_USE_OCC=OFF
KICAD_SPICE=ON
Also previous commit was affected (I did not test other commits).
Application: Pcbnew
Version: (5.99.0-498-ge57fe9d17-dirty), release build
Libraries:
wxWidgets 3.0.2
libcurl/7.52.1 GnuTLS/3.5.8 zlib/1.2.8 libidn2/0.16 libpsl/0.17.0 (+libidn2/0.16) libssh2/1.7.0 nghttp2/1.18.1 librtmp/2.3
Platform: Linux 4.9.0-8-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
Build date: Dec 11 2019 19:37:28
wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
Boost: 1.69.0
OpenCASCADE Community Edition: 6.8.0
Curl: 7.52.1
Compiler: GCC 6.3.0 with C++ ABI 1010
Build settings:
KICAD_SCRIPTING=ON
KICAD_SCRIPTING_MODULES=ON
KICAD_SCRIPTING_PYTHON3=OFF
KICAD_SCRIPTING_WXPYTHON=ON
KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
KICAD_SCRIPTING_ACTION_MENU=ON
BUILD_GITHUB_PLUGIN=ON
KICAD_USE_OCE=ON
KICAD_USE_OCC=OFF
KICAD_SPICE=ON
Edited by Dino Ghilardi