eeschema: hidden pins are click targets
Description
If a pin is hidden, it shouldn't be a click target...but right now, it is. This doesn't matter in a vast number of cases, except if the pin is located outside of the symbol body for some reason.
I ran into this issue because I was programatically placing invisible NC pins off-grid, but with a large enough number the names may extend outside of the symbol body and become click targets. In the case of thousands of stacked pins, I wonder if this contributes to any UI lag.
Steps to reproduce
- Create a symbol with a hidden pin placed outside of the body of the symbol.
- Place the symbol in the schematic.
- Click where the hidden pin would be; the part gets selected.
KiCad Version
Application: KiCad Schematic Editor
Version: 6.0.5-a6ca702e91~116~ubuntu22.04.1, release build
Libraries:
wxWidgets 3.0.5
Platform: Linux 5.15.0-27-generic x86_64, 64 bit, Little endian, wxGTK, xubuntu, x11
wxWidgets: 3.0.5 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
Boost: 1.74.0
OCC: 7.5.2
Curl: 7.83.0
ngspice: 36
Compiler: GCC 11.2.0 with C++ ABI 1016
Build settings:
KICAD_USE_OCC=ON
KICAD_SPICE=ON