Fixes #13767

Fixes #13768

Don't use the value field when adding Eagle part attributes to a symbol.
This issue was cause by using a mandatory symbol field ID instead of
using the next available field ID when adding new fields to as symbol.

Fixes #13468

Step 2: Remove some useless spacers, and do not force some widgets
to have a too large size.

1) Special case doesn't work for polygons with holes
2) Fix special case to handle intersecting lines where neither end is
   in the polygon.

Note that only (1) is required for the bug below.  (2) was just
discovered while implementing (1).

Fixes #13779

Remove some useless spacers, and do not force some widgets to have a to
large size (by removing empty areas).
Work in progress: one panel is still too big.

Don't set text if outside of the clipbox.  Text is non-cached so will
get redrawn on zoom

Fixes https://gitlab.com/kicad/code/kicad/issues/13572

Graham Keeth authored Feb 03, 2023 and Jeff Young committed Feb 04, 2023

The ngspice manual does not indicate that there is any default
model type. This change ensures we get a `level=xy` written out to the
.model line when we select a HiSIM_HV model.

Graham Keeth authored Feb 03, 2023 and Jeff Young committed Feb 04, 2023

- generate .model lines in spice netlist for all device types that need
  one
- add "level=<n>" to .model line for non-default model levels. This is
  necessary to allow more sophisticated models to be used, and some
  devices *always* need a level specified (e.g. JFETs)
- add "version=<n>" to .model line for models that have multiple
  versions available (AFAIK only affects HiSIM_HV MOSFET models)

Fixes: kicad/code/kicad#13775

Graham Keeth authored Feb 03, 2023 and Jeff Young committed Feb 04, 2023

Fixes: kicad/code/kicad#13774

Fixes #13769

Fixes #13753

Only update value and footprint fields from instance data if it's not
empty.  These fields were not always stored in the instance data so
loading them from instance data that does not contain them will clear
the fields.

#13735

Internal routines have no need for locking the mutex they already own.
While external routines that want to recalculate the Ratsnest do need an
exclusive lock before being allowed access

Fixes #13011

Fix also a compil warning

Rather than update library symbols one at a time, queue them up by
schematic symbol to prevent multiple updates to the same symbol in
complex hierarchies.  This also removes all of the library symbols
first which will clear out all of the library symbol variants that
were created by modifying library symbols in place and/or changes to
the symbol in the library.

Don't add new variant library symbol if an equivalent variant already
exists in the schematic local cache.  This prevents duplicate library
symbols from being added to the local cache when the first variant in
the cache does not match that of the symbol being added.

Just testing a single point to find copper that is outside the board works
until the arc->segment conversion moves the board outline just enough to
have the filled copper slightly (few IU) outside of the converted outline.

Instead, we do an expensive check of comparing the size of the
intersection between the island and the island's intersection with the
board.  If the intersection is at least half as large as the original
island, we can say with certainty that the island is inside.  The margin
could be much smaller than half but this preserves the intent without
picking an arbitrary number that might be violated

Fixes https://gitlab.com/kicad/code/kicad/issues/13717

It was broken by my commit f8051d95
Fixes #13747
#13747

Fixes #13741

Fixes https://gitlab.com/kicad/code/kicad/-/issues/13746

Item pins might not be in the same order.

Fixes #13741

James J authored Jan 30, 2023 and jean-pierre charras committed Feb 02, 2023

Exporting symbols to new library now saves the library and forces
update of symbol links

Fixes #13494

ENUM_MAP<PCB_LAYER_ID> is tested initialized in some other XXX_DESC,
but not in ZONE_DESC
Fixes #13699
#13699

Fixes #13743

Fixes #13727

${DNP} displayed "DNP" when DNP was cleared, and "" when DNP was set

For debugging purposes, currently.