"From display type" should not be able to point to a non existing tag type
I stumbled upon a song on last Saturday during a karaoke that had no tag listed for its singer/series/singergroup in my operator view.
The song was the music video Kokoro Odoru (which is an ending for SD Gundam Force). I since fixed that in the base.
The problem was that the song had a from_display_type
set to singers
even though it had no singers anymore. The singers had probably been converted to a singer group at some point.
The problem is that this can happen in two ways :
- Removal via the kara form
- Removal via batch edit
We have several options :
- For batch edits, should we precheck all songs involved and refuse to proceed if an incorrect display type is selected? Or proced reset it to undefined?
- For the kara form, shoudl the frontend prevent validation if an incorrect type is entered? If yes, the API should probably do that too.
- On the frontend (public/systempanel/operator) it should probably default back to the usual suspects (series, singergroup, singer) if it doesn't find crresponding tags.
We can at least already try to fix the third point.