ChangeLog 329 KB
Newer Older
1
2015-04-01  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>
2

3
	Preparing the openvas-scanner 5.0.1 release.
4 5 6

	* CHANGES: Updated.

7
2015-03-31  Hani Benhabiles  <hani.benhabiles@greenbone.net>
8

9 10 11 12 13 14 15
	* src/attack.c (attack_init_hostinfos_vhosts, attack_init_hostinfos)
	(attack_start, attack_network), src/nasl_plugins.c (nasl_plugin_add)
	(nasl_plugin_launch, nasl_thread), src/ntp.c (files_add_translation)
	(files_add_size_translation), src/openvassd.c (scanner_thread)
	(main_loop), src/pluginload.c (plugin_set_socket), src/plugs_req.c
	(requirements_common_ports), src/utils.c (list2arglist): Adjust
	arg_add_value() and arg_set_value() calls.
16

17
2015-03-30  Hani Benhabiles  <hani.benhabiles@greenbone.net>
18

19 20 21
	* src/openvassd.c (scanner_thread): Use getpeername() to get socket's
	client address.
	(main_loop): Don't set family and client_address in globals.
22

23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943
2015-03-30  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/comm.c (send_plug_info): Improve code style and remove useless
	extra allocation.

2015-03-27  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (init_host_kb, attack_host, attack_start)
	(attack_network), src/comm.c (comm_wait_order), src/nasl_plugins.c
	(nasl_thread), src/ntp.c (ntp_parse_input, ntp_recv_file),
	src/openvassd.c (handle_client, scanner_thread) , src/pluginload.c
	(plugin_get_socket): Use arg_get_value_int().

2015-03-27  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/comm.c (is_client_present): New function.
	(comm_terminate): Wait for client to acknowledge termination.

	* src/openvassd.c (handle_client): Remove ntp_keep_communication_alive
	preference handling loop.

	* src/utils.c, src/utils.h (is_client_present): Remove function.

2015-03-27  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (comm_send_status): Take socket instead of globals as
	argument.
	(init_host_kb): Don't set unused CURRENTLY_TESTED_HOST globals value.
	(attack_host): Adjust function call.

2015-03-27  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (error_message_to_client, report_kb_failure)
	(apply_source_iface_preference, check_kb_access): Take socket as
	argument, instead of globals arglist.
	(init_host_kb, attack_network): Adjust functions calls.
	(attack_start): Don't set unused confirm value.

	* src/ntp.c (ntp_long_attack): Take socket as argument.
	(ntp_parse_input): Adjust function call.

	* src/otp.h: Remove unused function header.

	* src/pluginlaunch.c (running): Remove unused globals element.
	(plugin_launch): Don't set globals element.

	* src/utils.c (auth_send): Remove unused confirm parameter.
	(send_printf): Adjust function call.
	(auth_printf): Remove unused function.

	* src/utils.h: Remove function prototype.

2015-03-27  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/comm.c (comm_terminate, send_plug_info, plugin_send_infos)
	(comm_send_pluginlist, comm_send_preference, comm_setup_plugins)
	(comm_send_nvt_infos): Take socket as argument, instead of globals
	arglist. Call send_printf() instead of auth_printf() and adjust
	functions calls.

	* src/comm.h: Adjust and remove functions prototypes.

	* src/ntp.c (ntp_parse_input, ntp_read_prefs, __ntp_timestamp_scan)
	(ntp_timestamp_host_scan_starts, ntp_timestamp_host_scan_ends)
	(__ntp_timestamp_scan_host): Take socket as argument, instead of globals
	arglist. Adjust functions calls.

	* src/ntp.h: Adjust functions prototypes.

	* src/openvassd.c (handle_client): Don't set plugins entry in globals.
	Adjust functions calls.

	* src/attack.c (attack_host, attack_start, attack_network): Get plugins
	arglist from global_plugins, instead of globals. Adjust functions calls.

	* src/utils.c (send_printf): New function.

	* src/utils.h: Add function prototype.

2015-03-26  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/comm.c (comm_send_nvt_info): Use recv_line() instead of removed
	auth_gets().

	* src/utils.c (auth_send, auth_printf): New functions, moved from
	libraries and adjusted.

	* src/utils.h: Add function prototype.

2015-03-26  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/comm.c (comm_wait_order): Handle ntp_parse_input () return value
	correctly. Return value instead of exitting.

	* src/comm.h: Adjust function prototype.

	* src/ntp.c (ntp_parse_input): Handle empty input.

2015-03-26  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/utils.c (is_client_present): Reset errno as it will be tested for
	after select() call. Check for select() failure.

2015-03-25  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (check_scan_stop): Remove function.
	(launch_plugin): Remove check_scan_stop() call.
	(handle_scan_stop_signal): New function.
	(attack_network): Set SIGUSR1 signal handler.

	* src/hosts.c (hosts_stop_host): Send SIGUSR1 signal to host, instead of
	sending INTERNAL_COMM_CTRL_STOP via the communication socket.
	(hosts_read_data): Set hosts to next only when h is first host in list.

	* src/pluginlaunch.c (process_mgr_sighand_term): Remove function.
	(pluginlaunch_init): Remove SIGTERM handler.

2015-03-20  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/hosts.c (hosts_stop_all): Stop the right host.

2015-03-19  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/hosts.c (hosts_read_data): Set hosts to next value before calling
	host_rm().

2015-03-16  Michael Wiegand <michael.wiegand@greenbone.net>

	Post release version bump.

	* CMakeLists.txt: Set version to 5.0.1.

2015-03-16  Michael Wiegand <michael.wiegand@greenbone.net>

	Preparing the openvas-scanner 5.0.0 release.

	* CHANGES: Updated.

	* CMakeLists.txt: Switch version scheme. Exclude generated files from
	source package.

2015-03-16  Michael Wiegand <michael.wiegand@greenbone.net>

	* tools/openvas-nvt-sync.in: Support for migration of unsigned files
	to the "private/" subdirectory has been removed as it was obsolete
	since the retirement of OpenVAS-5.

2015-03-03  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/ntp.c, src/attack.c: Remove inused includes.

2015-03-02  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/ntp.c: Remove useless include.

2015-03-02  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (is_pattern, pattern_matches)
	(fill_host_kb_ssh_credentials): Remove unused functions.
	(init_host_kb): Don't call fill_host_kb_ssh_credentials().

	* src/ntp.c (build_global_host_sshlogins_map)
	(build_global_sshlogin_info_map): Remove functions.
	(ntp_recv_file): Don't call removed functions.

2015-02-27  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/openvassd.c (reload_flag, loading_stop): Rename  to reload_signal
	and loading_stop_signal.
	(termination_signal): New variable.
	(set_reload_flag, sighand_loading_stop_signal): Rename to
	handle_reload_signal and handle_loading_stop_signal for consistency.
	(handle_termination_signal, check_termination, init_signal_handlers):
	New functions.
	(loading_handler_start, reload_openvassd): Adjust for function and
	variables renames.
	(check_and_reload): Rename to check_reload.
	(main_loop): Handle termination signal asynchronously.
	(init_openvassd): Don't set signal handlers.
	(main): Set signal handlers, after loading plugins.

	* src/processes.c (create_process): Call init_child_signal_handlers.
	(pr_sigterm): Remove unused function.
	(init_child_signal_handlers): New function.

	* src/sighand.c (sighandler): Remove function.

	* src/sighand.h: Remove function prototype.

2015-02-26  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/openvassd.c: Removed accidently committed debug code.

2015-02-26  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/openvassd.c (main): Updated year to 2015.

2015-02-26  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/openvassd.c (reload): Make variable volatile and rename to
	reload_flag.
	(sighup): Rename to set_reload_flag().
	(reload_openvassd, check_and_reload, init_openvassd): Adjust for
	renamings. Don't set superfluous signal handlers.

	* src/pluginlaunch.c (pluginlaunch_init, pluginlaunch_stop),
	src/nasl_plugins (nasl_thread), src/processes.c (create_process): Remove
	superfluous signal handlers setting.

	* src/sighand.c (sighandler): Adjust to remove unused signals for
	handler.

2015-02-26  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/hosts.c (sigchld_handler): Remove function.
	(hosts_init): Don't set SIGCHLD signal handler, as this is already
	handled by hosts_read_data().

2015-02-25  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (attack_network): Check if scan is stopped with
	scan_is_stopped() instead of stop_required global value.

	* src/hosts.c (host_rm): Remove hosts argument.
	(hosts_stop_host): Take host struct as argument. Don't call host_rm() as
	host scan processes may send data to the parent before exiting.
	(hosts_stop_all): Adjust to not change hosts global variable value.
	(hosts_read_data): Adjust for host_rm() change.

	* src/hosts.h: Remove useless prototype.

	* src/ntp.c (ntp_parse_input): Don't set stop_required globals value.

2015-02-24  Benot Allard  <benoit.allard@greenbone.net>

	* doc/openvassd.8.in: Fix typo in man page

2015-02-23  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (attack_host): Update scan status only when scan is
	still running.

2015-02-05  Henri Doreau <henri.doreau@gmail.com>

	* src/attack.c (attack_start): Reduce stack-located buffers to required
	size.

2015-02-05  Henri Doreau <henri.doreau@gmail.com>

	* src/attack.c (attack_start_args, attack_start, attack_network): Code
	cleanup. Do not bother duplicating target FQDN into a structure field.
	Use the heap allocated pointer returned by openvas_host_value_str()
	instead.

2015-02-05  Henri Doreau <henri.doreau@gmail.com>

	* CMakeLists.txt, src/CMakeLists.txt: Link against libomp to satisfy
	dependency chain.

2015-02-17  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (free_uploaded_file): Remove function.
	(apply_hosts_preferences): Use g_hash_table_destroy() directly.

2015-02-11  Michael Wiegand <michael.wiegand@greenbone.net>

	Post release version bump.

	* CMakeLists.txt: Set version to 5.0+beta7.

2015-02-11  Michael Wiegand <michael.wiegand@greenbone.net>

	Preparing the openvas-scanner 5.0+beta6 release.

	* CHANGES: Updated.

2015-02-09  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (comm_send_status): New function, moved from libraries.
	(attack_host): Update host scanning status, when finished or terminated.

2015-01-19  Michael Wiegand <michael.wiegand@greenbone.net>

	* CMakeLists.txt: Check if pkg-config was found. Abort and log a fatal
	error if it is not found.

2015-01-19  Michael Wiegand <michael.wiegand@greenbone.net>

	Add check for required libgcrypt. It was already expected to be
	present (see usage of libgcrypt-config), but never checked for.

	* CMakeLists.txt: Try to find libgcrypt before calling
	libgcrypt-config. Raise SEND_ERROR if the library can not be found.
	Remove now obsolete TODO.

	* INSTALL: Note libgcrypt as prerequisite. Remove mention of gnutls
	since it is only an indirect dependency via openvas-libraries.

2015-01-19  Michael Wiegand <michael.wiegand@greenbone.net>

	Simplify handling of library flags in CMakeLists.txt files, thereby
	removing the need for clumsy workarounds.

	* CMakeLists.txt: Remove redundant queries of library flags which were
	already retrieved by CMake. Remove unnecessary aggregation of flags.

	* src/CMakeLists.txt: Set include directories with include_directories
	instead of target properties. Remove quotes in target_link_libraries
	so that CMake lists get expanded correctly.

2015-01-12  Michael Wiegand <michael.wiegand@greenbone.net>

	Post release version bump.

	* CMakeLists.txt: Set version to 5.0+beta6.

2015-01-12  Michael Wiegand <michael.wiegand@greenbone.net>

	Preparing the openvas-scanner 5.0+beta5 release.

	* CHANGES: Updated.

2014-12-16  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/utils.c (is_scanner_only_pref): Added "kb_location".

2014-12-11  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/pluginscheduler.c (plugins_scheduler_init): Adjust
	enable_plugin_and_dependencies() call to use the full nvt filename.

2014-12-08  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/openvassd.c: Removed unneeded include's.

2014-12-08  Michael Wiegand <michael.wiegand@greenbone.net>

	* tools/greenbone-nvt-sync.in: Remove stray "=" introduced with last
	commit.

2014-12-08  Michael Wiegand <michael.wiegand@greenbone.net>

	Generate greenbone-nvt-sync during build as well so that information
	available at build time is used and does not have to be gathered at
	runtime.

	* CMakeLists.txt: Add tools/greenbone-nvt-sync to the list of files to
	be generated and ignore generated file when packaging source tar ball.
	Install generated file from build directory.

	* tools/greenbone-nvt-sync.in: New. Renamed from greenbone-nvt-sync.
	Use CMake variables instead of runtime checks. Simplify variables
	derived from CMake variables.

	* tools/greenbone-nvt-sync: Moved to greenbone-nvt-sync.in.

2014-12-06  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/openvassd.c (main): Updated/improved version info.

2014-11-24  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* CMakeLists.txt, src/CMakeLists.txt: Remove check for and linking
	against libgnutls and libpcap.  This is already done adequately in
	libraries.

	* src/openvassd.c: Remove useless includes.

2014-11-21  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/nasl_plugins.c (nasl_plugin_add): Remove nvti_set_src() call.

2014-11-21  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (launch_plugin): Remove cur_plug and num_plugs arguments.
	Don't send scan status.
	(attack_host): Send scan status after launching plugin.

2014-11-20  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Post release version bump.

	* CMakeLists.txt: Set version to 5.0+beta5.

2014-11-20  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Preparing the openvas-scanner 5.0+beta4 release.

	* CHANGES: Updated.

2014-11-20  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (launch_plugin): Adjust comm_send_status() call.

2014-11-19  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/attack.c (launch_plugin): Don't duplicate the result of
	nvticache_get_src anymore because it now already returns a copy.

2014-11-17  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (check_scan_stop): Exit currently running plugins
	processes when scan stop is received.

2014-11-17  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* CMakeLists.txt: Check for and link against libopenvas_nasl,
	libopenvas_base and libopenvas_misc libraries instead of the whole
	libopenvas package.

2014-11-16  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/nasl_plugins.c (nasl_plugin_add): Adjust call of exec_nasl_script
	by providing the oid.
	(nasl_thread_args): Extend struct by element "oid".
	(nasl_plugin_launch): Add parameter "oid" and use it for struct
	nasl_thread_args.
	(nasl_thread): Adjust call of exec_nasl_script providing the oid.

	* src/pluginload.h: Adjust proto for nasl_plugin_launch accordingly.

	* src/pluginlaunch.c (plugin_launch): Adjust call of nasl_plugin_launch
	by providing NULL as oid.

2014-11-16  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/comm.c (send_plug_info): It is guaranteed that a NVTI
	has a OID, therefore simpify the code. Also remove some uneeded
	setting of variables as they are never used.

2014-11-16  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Remove any use of the "OID" arglist element of a plugin arglist
	structure.

	* src/attack.c (launch_plugin): The plugins' arglist name is
	the OID, so use this instead of aglist element "OID".

	* src/pluginlaunch.c (process_internal_msg, update_running_processes,
	read_running_processes, plugin_launch): The plugins' arglist name is
	the OID, so use this instead of aglist element "OID".

	* src/comm.c (send_plug_info, plugin_send_infos, qsort_cmp,
	_get_plug_by_oid): The plugins' arglist name is
	the OID, so use this instead of aglist element "OID".

	* src/pluginscheduler.c (hash_add, enable_plugin_and_dependencies,
	plugins_scheduler_init): The plugins' arglist name is the OID, so
	use this instead of aglist element "OID".

2014-11-14  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/openvassd.c (reload_openvassd, main): Exit on plugins reload failure.

	* src/pluginload.c (plugins_reload_from_dir): Stop loading plugins after
	encountering 20 erroneous plugins.

2014-11-13  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/nasl_plugins.c (nasl_plugin_add): Instead of the filename, use
	the OID as "name" of the plugin arglist structure.

	* src/pluginscheduler.c (hash_add): Create the cache based on the
	filename which now means to retrieve it first.
	(_hash_get): Get the filename for comparison.
	(hash_fill_deps): Since now the name of the arglist is the oid, simplify
	the calls to get the filename based on an OID.

2014-11-12  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (scan_is_stopped, check_scan_stop): New functions.
	(launch_plugin): Only launch ACT_END plugins in stopped scan case.

	* src/hosts.c (hosts_stop_host): Don't kill scan hosts processes. Send
	internal control message instead.
	(hosts_read_client): Adjust ntp_parse_input() return value check.

	* src/ntp.c (ntp_parse_input): Don't return NTP_STOP_WHOLE_TEST on scan
	stop.

	* src/ntp.h: Remove unused NTP_STOP_WHOLE_TEST define.

2014-11-12  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/attack.c (launch_plugin): Use nvticache_get_filename() to get
	the filename of a NVT instead of using the "name" element of
	the plugin arglist.

	* src/pluginlaunch.c (update_running_processes, read_running_processes):
	Use nvticache_get_filename() to get the filename of a NVT instead of
	using the "name" element of the plugin arglist.

	* src/pluginscheduler.c (hash_fill_deps, enable_plugin_and_dependencies):
	Use nvticache_get_filename() to get the filename of a NVT instead of
	using the "name" element of the plugin arglist.

2014-11-11  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/ntp.c (ntp_long_attack, ntp_recv_file): Fix memory leaks.

2014-11-11  Benot Allard  <benoit.allard@greenbone.net>

	* CMakeLists.txt: define _DEFAULT_SOURCE to silent a warning with glibc
	  >= 2.20. See
	  https://sourceware.org/glibc/wiki/Release/2.20#Packaging_Changes

2014-11-10  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/log.c (log_vwrite): Fix indention.

2014-11-09  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Final step of switching to global preference store.

	* src/nasl_plugins.c (nasl_plugin_add): Adjust calls of
	plug_create_from_nvti_and_prefs which does not need the preferences
	as argument anymore. Do not add a "preferences" element to the
	plugins arglist.
	(nasl_plugin_launch): Drop argument "preferences". Do not add a
	"preferences" element to the plugins arglist.

	* src/pluginload.c (plugin_unlink): Do not set the "preferences"
	element to the plugins arglist.

	* src/pluginload.h: Adjust proto of nasl_plugin_launch.

	* src/pluginlaunch.c (plugin_launch): Adjust call of
	changed nasl_plugin_launch, now without preferences.

	* src/openvassd.c (handle_client): Use prefs_get instead
	of directly using arglist.
	(main_loop): Do not add the "preferences" arglist to the globals
	arglist anbymore.
	(init_openvassd): Do not set the "preferences" arglist in the options.

	* src/ntp.c: Fixed a comment.

2014-11-06  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/openvassd.c (reload_openvassd): Free the nvti cache before
	reloading the plugins.

2014-11-05  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/plugs_req.c (get_closed_ports, get_closed_udp_ports): Adjust to
	new proto of kb_get_port_state_proto.

2014-11-05  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Move preferences handling from scanner to libraries because
	we need to access it from some modules there directly while
	at the same time getting rid of storing preferences pointer
	in the arglists.

	* src/preferences.c, src/preferences.h: Removed.

	* src/CMakeLists.txt: Removed handling of module preferences.

	* src/pluginlaunch.c, src/pluginload.c, src/utils.c,
	src/plugs_req.c, src/comm.c, src/nasl_plugins.c, src/ntp.c,
	src/openvassd.c, src/attack.c: Adjust include to new prefs.h.

	* COPYING: Remove module preferences.

2014-11-03  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/preferences.c (struct openvassd_option, openvassd_defaults):
	Removed. Moved to openvassd.c.
	(prefs_init): Removed handling of options. Moved handling of config
	into prefs_config().
	(prefs_config): New. The config file settings from prefs_init.

	* src/preferences.h: Adapt protos accordingly.

	* src/openvassd.c (struct openvassd_option, openvassd_defaults): New.
	Moved here from preferences.c.
	(reload_openvassd, init_openvassd): Adapt to split of prefs_init and
	prefs_config and set the options in its own.

2014-11-03  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/preferences.c (preferences_set): Removed unneeded function.

	* src/preferences.h: Removed proto accordingly.

2014-11-02  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/pluginlaunch.c (plugin_launch): Get global preferences directly
	and therefore drop the argument "preferences".

	* src/pluginlaunch.h: Adjust proto accordingly.

	* src/pluginload.c (plugins_reload_from_dir): Adapt to new proto of
	nasl_plugin_add.
 
	* src/pluginload.h: Adjust proto accodingly.

	* src/plugs_req.c (get_closed_ports, get_closed_udp_ports): Get global
	preferences directly and therefore drop the argument "preferences".
	(requirements_plugin): Adapt to changed protos and therefore drop the
	argument "preferences".

	* src/nasl_plugins.c (nasl_plugin_add): Get global preferences directly
	and therefore drop the argument "preferences".

	* src/openvassd.c (set_globals_from_preferences): Don't set the preferences
	because it is not changing anything. Therefore drop the argument "prefs".
	(reload_openvassd): Adjust the call of set_globals_from_preferences.

	* src/attack.c (launch_plugin): Adjust to new protos.
	(iface_authorized): Drop unneeded argument "preferences".
	(apply_source_iface_preference): Adjust to new proto and therefore drop
	argument "preferences".
	(attack_network): Adjust to new protos.


2014-11-02  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/pluginload.c (plugins_reload_from_dir): Dropped argument
	"prefrences" because prefrences_get() is used directly.
	(plugins_init): Dropped argument "preferences" because it is
	not needed anymore to call plugins_reload_from_dir.

	* src/pluginload.h: Adjust protos accordingly.

	* src/plugs_req.c (requirements_plugin): Use prefs_get
	instead of arglist.

	* src/preferences.h: Add missing include of glib.

	* src/openvassd.c (reload_openvassd, init_plugins): Adapt to new
	proto of plugins_init.

2014-11-01  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/preferences.c (preferences_init): Renamed to prefs_init().
	(prefs_init): Set the default options directly.
	(prefrences_dump): Renamed to prefs_dump.
	(preferences_plugin_timeout): Renamed to prefs_nvt_timeout and avoid arg_list
	calls.

	* src/preferences.h: Adjust protos accordingly.

	* src/pluginlaunch.c (plugin_launch): Adjust to new function
	for timeout preference.

	* src/openvassd.c (reload_openvassd, init_openvassd): Adjust to new call of prefs_init.
	(main): Adjust to prefs_dump call.

2014-10-31  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/openvassd.c (init_ssl_ctx): Replaced calls of
	preferences_get_string() by prefs_get().

	* src/attack.c (apply_hosts_preferences): Replaced calls of
	preferences_get_string() by prefs_get(). And dropped the now unneeded
	parameter for preferences.
	(apply_source_iface_preference, attack_network): Replaced calls of
	preferences_get_string() by prefs_get().

	* src/preferences.c (preferences_get_string): Removed now unneeded function.

	* src/preferences.h: Removed proto accordingly.

2014-10-31  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/preferences.c (preferences_optimize_test): Removed meanwhile unneeded function.

2014-10-31  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/attack.c (apply_hosts_preferences, attack_network): Replaced calls of
	preferences_get_bool() by prefs_get_bool()

	* src/preferences.c (preferences_get_bool): Removed now unneeded function.

	* src/preferences.h: Removed proto accordingly.

2014-10-30  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/pluginload.c (plugins_reload_from_dir): Call prefs_get().

2014-10-30  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (pattern_matches, fill_host_kb_ssh_credentials),
	src/ntp.c (ntp_long_attack), src/pluginlaunch.c (next_free_process),
	src/pluginload.c (plugins_reload_from_dir, plugin_unlink),
	src/pluginscheduler.c (scheduler_rm_running_ports): Use log_write
	instead of printf() and fprintf().

	* src/comm.c, src/utils.c: Remove useless include.

2014-10-29  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Replacing several explicit functions to get a boolean value
	from the preferences. Those functions used to cache the value
	which is not done anymore. The relevance of this caching is
	unclear and if really needed the place where it is relevant
	should take appropriate measures.

	* src/preferences.c (prefs_get_bool): New. Get a boolean expression
	of a preference value via a key.
	(preferences_log_whole_attack, preferences_log_plugins_at_load,
	preferences_plugins_timeout, preferences_benice,
	preferences_drop_privileges, preferences_safe_checks_enabled,
	preferences_nasl_no_signature_check, preferences_reset_cache): Removed.

	* src/preferences.h: Updated proto list accordingly.

	* src/pluginlaunch.c (update_running_processes): Use prefs_get_bool()
	instead of explicit function. Removed loop across processes that
	collected the preference about log_whole_attack. Since it is a single
	preference, the loop is pointless.
	(plugin_launch): Use prefs_get_bool() instead of explicit function.

	* src/pluginload.c (plugins_reload_from_dir): Use prefs_get_bool()
	instead of explicit function.

	* src/nasl_plugins.c (nasl_plugin_add):
	Use prefs_get_bool() instead of explicit function.
	(nasl_thread_args, nasl_thread): Dropped now-unneeded element "preferences".
	(nasl_plugin_launch): Don't set the removed element anymore.

	* src/openvassd.c (handle_client): Don't reset the preferences cache anymore
	as this is not needed anymore.
	(scanner_thread): Don't set the removed element anymore.

	* src/attack.c (launch_plugin): Don't set the removed element anymore.

2014-10-29  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/pluginload.c (plugins_reload_from_dir, plugins_init): Use
	prefs_get() instead of arglist.

	* src/openvassd.c (start_daemon_mode, set_globals_from_preferences,
	reload_openvassd, init_openvassd): Use prefs_get() instead of arglist.

	* src/attack.c (attack_start, attack_network): Use prefs_get() instead
	of arglist.

2014-10-27  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/utils.c, src/preferences.c, src/utils.h,
	src/preferences.h, src/pluginlaunch.c, src/pluginload.c,
	src/pluginlaunch.h, src/hosts.c, src/pluginload.h, src/hosts.h:
	Made any method without parameter explicitly use "void" to
	inticate this and help compiler to identify wrong usage.

	* src/comm.h: Dropped proto for non-existent function "client_handler".

2014-10-27  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/ntp.c (ntp_recv_file): Log error with log_write().

2014-10-27  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/ntp.c (ntp_long_attack): Use prefs_set() instead of arglist
	handling.

2014-10-27  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/utils.c (get_max_hosts_number, get_max_checks_number): Use
	prefs_get() instead of arglist. Also drop parameter as it is not
	needed anymore.

	* src/utils.h: Adjust protos accordingly.

	* src/attack.c (attack_network): Adjust calls to above API change.

	* src/pluginlaunch.c (pluginlaunch_init): Adjust calls to above API
	change.

2014-10-26  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/ntp.c (ntp_read_prefs): Increase size of buffer for
	preferences to allow for upto 69K NVTs.

2014-10-26  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/preferences.c (prefs_set): Change behaviour to always take care
	for memory allocation for both, key and value.

	* src/ntp.c (ntp_long_attack): Free the target after prefs_set.
	(ntp_read_prefs): Use prefs_set() instead of doing it on arglist level.

2014-10-26  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/ntp.c (ntp_long_attack): Use prefs_set instead of doing it on
	arglist level.

	* src/preferences.c (prefs_set): New.

	* src/preferences.h: Add proto accordingly.

	* src/attack.c (attack_network): Use prefs_get() instead of arglist.

2014-10-26  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	First step of using preferences via API instead of via arglists.

	* src/preferences.c (prefs_get): New. Get a preference value via a key.
	(preferences_kb_location): Removed. This should be used via prefs_get
	now.

	* src/preferences.h: Adjust protos accordingly.

	* src/openvassd.c (flush_all_kbs): Use prefs_get() to directly get
	a preference. This allows to drop the function parameter as well.
	(main): Use prefs_get() to directly get a prefernce.

	* src/attack.c (report_kb_failure, init_host_kb, check_kb_access,
	attack_network):  Use prefs_get() to directly get a preference.

2014-10-26  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	First step for switching from preferences stored in a "globals"
	arglist to a specific global module.

	* src/comm.c (comm_send_preferences): Use preferences_get() instead
	of searching though globals arglist.

	* src/ntp.c (ntp_long_attack, ntp_read_prefs): Use preferences_get()
	instead of searching though globals arglist.

	* src/openvassd.c (handle_client, scanner_thread): Use preferences_get()
	instead of searching though globals arglist.

	* src/pluginlaunch.c (update_running_processes, pluginlaunch_init):
	Use preferences_get() instead of searching though globals arglist.
	(pluginlaunch_init): Drop argument "globals" because now it is not used
	anymore.

	* src/pluginlaunch.h: Adjust proto accordingly.

	* src/attack.c (report_kb_failure, launch_plugin, init_host_kb,
	attack_start, check_kb_access, attack_network): Use preferences_get()
	instead of searching though globals arglist.
	(attack_host): Adjust to new proto of pluginlaunch_init().

	* src/pluginscheduler.c: Drop unneeded include.

2014-10-24  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Move preference dump function into preferences module as it
	is of general use.

	* src/preferences.c (preferences_dump): New. Dump the
	preferences to stdout.

	* src/preferences.h: Add proto accordingly.

	* src/openvassd.c (dump_cfg_specs): Removed.
	(main): Use preferences_dump instead of dump_cfg_specs.

2014-10-24  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Move the global preferences variable from openvassd to module
	preferences.

	* src/openvassd.c (global_preferences): Removed this global variable.
	(start_daemon_mode): Instead of directly using global_preferences,
	use the new function preferences_get().
	(set_globals_from_preferences): Instead freeing and setting the new
	preferences, just call preferences_set().
	(reload_openvassd, init_ssl_ctx, main_loop, main): Instead of using the
	global variable, use preferences_get().

	* src/preferences.c (global_prefs): New.
	(preferences_init): Changed to use the global variable instead.
	(preferences_get): New. Return the global variable.
	(preferences_set): New. Replace global variable with new content.

	* src/preferences.h: Adjust protos accordingly.

2014-10-24  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/preferences.c (preferences_init): Instead of pointer-pointer
	parameter simply return the result.

	* src/preferences.h: Adjust proto accordingly.

	* src/openvassd.c (reload_openvassd, init_openvassd): Adjust call of
	preferences_init to new API.

2014-10-24  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (launch_plugin): Pass the full nvt path to
	plugin_launch().

2014-10-24  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/preferences.c (preferences_init): Dropped the return value
	because it is never used anywhere.

	* src/preferences.h: Adjust proto accordingly.

2014-10-22  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/nasl_plugins.c (nasl_plugin_add): Removed redundant setting
	of the OID. This saves considerable amount of memory per process.

2014-10-22  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Dropped superfluous log lines. The log will also without this line
	provide the information about the updating. This makes the log
	cleaner to read.

	* tools/greenbone-nvt-sync (update_openvassd, update_openvasmd): Remove log
	info about start of update.

2014-10-22  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/sighand.c (print_trace): New function.
	(sighand_segv): Log backtrace when a process segfaults.

2014-10-21  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/attack.c (fill_host_kb_ssh_credentials): Print debug info when
	DEBUG is defined instead of printing debug info if NDEBUG is not defined.
	This avoids noise by default.

2014-10-21  Henri Doreau <henri.doreau@gmail.com>
944

945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537
	* src/comm.c (send_plug_info): Replaced g_malloc0() + snprintf() by
	g_strdup_printf().

2014-10-14  Michael Wiegand <michael.wiegand@greenbone.net>

	Post release version bump.

	* CMakeLists.txt: Set version to 5.0+beta4.

2014-10-14  Michael Wiegand <michael.wiegand@greenbone.net>

	Preparing the openvas-scanner 5.0+beta3 release.

	* CHANGES: Updated.

2014-10-13  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/ntp.c: Fix include for hash_table_file for new location.

2014-10-10  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/nasl_plugins.c (nasl_plugin_add): Free the nvti struct returned by
	nvticache_get() as it is not kept in the cache memory anymore.

2014-10-09  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (attack_start): Fix memory leak.

	* src/nasl_plugins.c (nasl_thread): Don't set NASL_EXEC_DONT_CLEANUP
	mode.

2014-10-09  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/pluginlaunch.c (process_internal_msg): In case of unexpected
	death, don't just report the PID which is mostly useless. Add the
	OID as well now.

2014-10-08  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (launch_plugin): Remove useless memory allocations and
	clean code.

	* src/pluginlaunch.c (process_internal_msg): Code style fix. Don't make
	variables static.

2014-10-08  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/comm.c (send_plug_info), src/pluginscheduler.c (hash_add)
	(plugins_scheduler_init): Call nvticache_get_by_oid_full() instead of
	nvticache_get_by_oid().

2014-10-07  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (launch_plugin), src/comm.c (send_plug_info),
	src/nasl_plugins.c (nasl_plugin_add), src/pluginload.c
	(plugins_reload_from_dir), src/pluginscheduler.c (hash_add)
	(plugins_scheduler_init): Adjust for nvticache API changes.

2014-10-07  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/nasl_plugins.c (nasl_plugin_add): Adjust for nvticache_get()
	changes as the returned nvti object is unnecessarily not cloned.

2014-09-22  Michael Wiegand <michael.wiegand@greenbone.net>

	Post release version bump.

	* CMakeLists.txt: Set version to 5.0+beta3.

2014-09-22  Michael Wiegand <michael.wiegand@greenbone.net>

	Preparing the openvas-scanner 5.0+beta2 release.

	* CHANGES: Updated.

2014-09-22  Michael Wiegand <michael.wiegand@greenbone.net>

	* INSTALL: Remove libhiredis from the list of prerequisites since it
	is actually required by openvas-libraries and handled there.

2014-09-19  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Replace last old internal calls for memory management by respective
	glib functions.

	* src/ntp.c (ntp_long_attack): Replaced emalloc() by g_malloc0() and efree()
	by g_free().
	(ntp_read_prefs): Replaced emalloc() by g_malloc0(), efree() by g_free()
	and estrdup() by g_strdup().
	(ntp_recv_file): Replaced estrdup() by g_strdup().

	* src/openvassd.c (main_loop): Replaced emalloc() by g_malloc0().

	* src/attack.c (attack_init_hostinfos_vhosts, attack_init_hostinfos):
	Replaced emalloc() by g_malloc0() and estrdup() by g_strdup().
	(attack_start): Replaced estrdup() by g_strdup().
	(attack_network): Replaced free() by g_free().

2014-09-19  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Replace more old internal calls for memory management by respective
	glib functions.

	* src/pluginlaunch.c (process_internal_msg): Replace efree() by
	g_free() and set buffer to NULL. 

	* src/comm.c (send_plug_info): Replaced estrdup() by g_strdup(),
	emalloc() by g_malloc0() and efree by g_free().
	(comm_setup_plugins): Replaced emalloc() by g_malloc0() and efree()
	by g_free().

	* src/utils.c (list2arglist): Avoid calling efree(). Replace
	emalloc() by g_malloc0().

2014-09-19  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Replace old internal calls for memory management by respective
	glib functions.

	* src/pluginload.c (plugins_init): Replace emalloc() by g_malloc0().

	* src/hosts.c (forward): Replace efree() by g_free() and take care
	the pointer is set to NULL because it is a static variable.
	(host_rm): Replace efree() by g_free().
	(hosts_new): Replace emalloc() by g_malloc0() and estrdup() by
	g_strdup().

	* src/nasl_plugins.c (nasl_plugin_add): Replace emalloc()
	by g_malloc0().

	* src/plugs_req.c (requirements_common_ports): Replace emalloc()
	by g_malloc0().

	* src/preferences.c (preferences_init): Replace emalloc()
	by g_malloc0().
	(preferences_process): Replace estrdup() by estrdup().
	(preferences_plugin_timeout): Replace efree() by g_free().

2014-09-12  Henri Doreau <henri.doreau@gmail.com>

	Make the redis socket actually configurable.

	* src/attack.c (scanner_kb_path): Moved to preferences.c and renamed.
	(error_message_to_client, init_host_kb, apply_source_iface_preference)
	(attack_network): Updated calls to use the new preferences_kb_location()
	function.

	* src/openvassd.c (flush_all_kbs): Don't use default KB location but the
	configured one, if present.
	(main): Updated call accordingly.

	* src/preferences.c (openvassd_defaults): Define "kb_location" with the
	other scanner options.
	(preferences_kb_location): Return the KB path, read option from
	"preferences" arglist instead of globals as previously done by
	scanner_kb_path().

	* src/preferences.h (preferences_kb_location): Expose
	preferences_kb_location() prototype.

2014-09-11  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Remove element "name" from list struct because it is never used.

	* src/pluginscheduler.c (struct list): Removed element "name".
	(plugins_scheduler_init): Don't set element "name".

2014-09-11  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/pluginscheduler.c (struct watch_list): Removed,
	because it is not used.

2014-09-11  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Use glib memory management instead of own one.

	* src/pluginscheduler.c (hash_init): Replaced call of emalloc by
	g_malloc0. Dropped the additional single extra byte which was
	allocated and made no sense.
	(hash_link_destroy, hash_destroy, scheduler_rm_running_ports,
	plugins_scheduler_next, plugins_scheduler_free): Replace efree by g_free.
	(hash_add, hash_fill_deps, scheduler_mark_running_ports): Replaced
	emalloc by g_malloc0.
	(plugins_scheduler_init):  Replace efree by g_free and emalloc by
	g_malloc0.

2014-09-11  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (launch_plugin): Do not implicitly launch ACT_SETTINGS
	plugins. See r14214.

2014-09-09  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/comm.c (send_plug_info), src/hosts.c (forward, hosts_set_pid),
	src/ntp.c (ntp_read_prefs), src/openvassd.c (init_ssl_ctx, init_network)
	(set_daemon_mode): Use proper log_write() function instead of printing
	to stderr fd which might be closed.

2014-09-09  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/nasl_plugins.c (nasl_plugin_add): Use log_write() instead of
	printf() and fprintf().

2014-09-03  Michael Wiegand <michael.wiegand@greenbone.net>

	* doc/CMakeLists.txt: Use appropriate text for second paragraph of the
	license notice.

2014-09-03  Michael Wiegand <michael.wiegand@greenbone.net>

	Make license of CMakeLists.txt files consistent.

	* doc/CMakeLists.txt: Change license from LGPLv2+ to GPLv2+.

2014-08-29  Michael Wiegand <michael.wiegand@greenbone.net>

	* CMakeLists.txt, src/CMakeLists.txt, src/otp.c, src/otp.h,
	tools/greenbone-nvt-sync: Ensure the GPLv2+ license notice uses the
	paragraph suggested by the Free Software Foundation.

2014-08-28  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/pluginschedule.c (plugins_scheduler_init): Check for null function
	argument earlier, otherwise we may crash due to null pointer dereference.

	* src/ntp.c (ntp_timestamp_host_scan_interrupted): Remove unused
	function.

	* src/ntp.h: Remove function prototype.

2014-08-27  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/attack.c (attack_start): Removed setting of non_simult_ports
	in case the preferences is missing. It is not a good idea to set
	some arbitrary default right here instead of keeping this in a
	single place, the preferences defaults.

2014-08-27  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/pluginscheduler.c: Removed TODO about cache as this
	is not relevant anymore.
	(struct plist): Changed fixed size of name into a pointer.
	(scheduler_mark_running_ports): Use g_strdup instead of
	strncpy for the name.
	(scheduler_rm_running_ports): Free the name now that
	it is a pointer.

2014-08-27  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/pluginscheduler.c (plugins_scheduler_init): Do NULL
	check before calling g_strsplit to silence assertion messages.

2014-08-27  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Get rid of last occurances of str2arglist.

	* src/pluginscheduler.c (struct hash): Change type of ports
	and dependencies from char to gchar.
	(hash_link_destroy): Simplify the removal of the strings arrays
	by using gstrfreev.
	(hash_add): Get the dependencies and required ports as string arrays
	directly via g_strsplit instead of first converting strings to arglists
	and then converting these to string arrays.

2014-08-27  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Get rid of more arglist uses in the scheduler plugins.

	* src/pluginscheduler.h (struct scheduler_plugin): Switch from
	arglist to string array for required_ports and required_udp_ports.

	* src/pluginscheduler.c (hash_link_destroy): Use g_strfreev instead
	of arg_free_all for required_ports and required_udp_ports.
	(plugins_scheduler_init): Don't create a arglist anymore for
	 required_ports and required_udp_ports. Instead, create
	a NULL terminated string array.

	* src/plugs_req.c (get_closed_ports, get_closed_udp_ports): Changed
	type of parameter "ports" from arglist to string array.
	(requirements_common_ports): Changed handling of ports from
	arglist to string array.
	(requirements_plugin): Changed type of internal variables from
	arglist to string array.
 
2014-08-25  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Get rid of some arglist uses in the scheduler plugins.

	* src/pluginscheduler.h (struct scheduler_plugin): Switch from
	arglist to string array for required_keys, mandatory_keys,
	excluded_keys.

	* src/pluginscheduler.c (hash_link_destroy): Use g_strfreev instead
	of arg_free_all for required_keys, mandatory_keys, excluded_keys.
	(plugins_scheduler_init): Don't create a arglist anymore for
	required_keys, mandatory_keys, excluded_keys. Instead, create
	a NULL terminated string array.

	* src/plugs_req.c (key_missing, key_present): Removed.
	(kb_missing_keyname_of_namelist): A replacement for key_missing()
	but now based on string array instead of arglist.
	(kb_present_keyname_of_namelist): A replacement for key_present()
	but now based on string array instead of arglist.
	(mandatory_requirements_met, requirements_plugin): Use new replacement
	functions.

2014-08-25  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/pluginscheduler.c (plugins_scheduler_init): Moved nvticache
	retrieval out of the plugins loop as there is only one cache
	and thus only needs to be retrieved once.

2014-08-24  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/processes.c (process_son): Removed this global variable
	as it is never used.
	(create_process): Removed setting process_son to some value,
	as it will never be read.

2014-08-21  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Post release version bump.

	* CMakeLists.txt: 5.0+beta2

2014-08-21  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Preparing the openvas-scanner 5.0+beta1 release.

	* CHANGES: Updated.

2014-08-13  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	Remove unused STOP_ATTACK and OPENVASSD_VERSION otp commands.

	* src/ntp.c (ntp_parse_input): Don't handle removed request types.

	* src/otp.c (otp_get_client_request): Don't handle unused STOP_ATTACK and
	OPENVASSD_VERSION otp commands.
	(otp_server_openvas_version): Delete function.

	* src/otp.h: Remove CREQ_OPENVASSD_VERSION and CREQ_STOP_ATTACK request
	types. Remove deleted function prototype.

2014-08-13  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	Remove scan pausing feature.

	* src/attack.c (pause_whole_test): Remove global variable.
	(attack_handle_sigusr1, attack_handle_sigusr2): Remove functions.
	(attack_host): Remove pausing check and handling.
	(attack_start): Don't register SIGUSR1 and SIGUSR2.

	* src/hosts.c (hosts_pause_all, hosts_resume_all): Delete functions.

	* src/hosts.h: Remove deleted function prototypes.

	* src/ntp.c (ntp_parse_input): Remove CREQ_PAUSE_WHOLE_TEST and
	CREQ_RESUME_WHOLE_TEST cases handling.

	* src/ntp.h: Remove NTP_PAUSE_WHOLE_TEST and NTP_RESUME_WHOLE_TEST
	definitions.

	* src/otp.c (otp_get_client_request): Remove PAUSE_WHOLE_TEST and
	RESUME_WHOLE_TEST client commands handling.

	* src/otp.h (client_request_t): Remove CREQ_PAUSE_WHOLE_TEST and
	CREQ_RESUME_WHOLE_TEST requests types.

2014-08-06  Henri Doreau <henri.doreau@gmail.com>

	* src/pluginscheduler.c (plugin_next_unrun_dependencie)
	(plugins_scheduler_next): Replaced all occurences of "dependencie" by
	"dependency".

2014-08-06  Henri Doreau <henri.doreau@gmail.com>

	Properly declare scheduling-related structures.

	* src/pluginscheduler.h (plugins_scheduler_t): Consistently define as a
	struct plugins_scheduler *, regardless what macro has been set earlier.
	(struct watch_list, struct hash, struct list, struct plist): Removed
	from the header.
	(struct plugins_scheduler_struct): Renamed (!!) and removed from this
	header.

	* src/pluginscheduler.c (struct watch_list, struct hash, struct list)
	(struct plist, struct plugins_scheduler): Moved declarations to this
	file. Fixed a couple comments.

	* pluginlaunch.c (plugin_launch): Removed unused parameter sched.

	* pluginlaunch.h (plugin_launch): Updated header accordingly.

	* src/attack.c (launch_plugin): Removed unused parameter sched.
	The "typedef void *" witchcraft which this commit removes was hiding a
	type error here (erroneous extra indirection). Updated the plugin_launch
	statement accordingly.
	(attack_host): Updated the launch_plugin statement accordingly.

2014-08-06  Henri Doreau <henri.doreau@gmail.com>

	* src/pluginscheduler.c (plugin_get_running_state)
	(plugin_set_running_state): Useless accessors, removed.
	(plugin_next_unrun_dependencie, plugins_scheduler_next): Replaced calls
	to the removed functions by regular accesses to the
	plugin::running_state field.

	* src/pluginscheduler.h (plugin_set_running_state): Updated header
	accordingly.

	* src/attack.c (launch_plugin): Replaced plugin_set_running_state calls
	by regular assignments.

	* src/pluginlaunch.c (process_mgr_sighand_term)
	(update_running_processes, pluginlaunch_stop, plugin_launch): Replaced
	plugin_set_running_state calls by regular assignments.

2014-08-04  Henri Doreau <henri.doreau@gmail.com>

	* src/attack.c (launch_plugin): Fixed a badly formatted log message.

2014-08-02  Henri Doreau <henri.doreau@gmail.com>

	Cleanup of the legacy logging infrastructure.

	* src/log.c (log_vwrite): Updated documentation. Use variadic versions
	of printf and syslog in reduce caller's code complexity. Assume that log
	messages are not LF-terminated.
	(log_write): Updated documentation.

	* src/attack.c (report_kb_failure, launch_plugin, attack_start)
	(apply_hosts_preferences, apply_source_iface_preference)
	(attack_network): Removed line feed at the end of log messages.

	* src/comm.c (comm_init, comm_loading, send_plug_info, comm_wait_order)
	(comm_setup_plugins): Removed line feed at the end of log messages.

	* src/nasl_plugins.c (nasl_thread): Removed line feed at the end of log
	messages.

	* src/ntp.c (ntp_parse_input, ntp_read_prefs): Removed line feed at the
	end of log messages.

	* src/openvassd.c (start_daemon_mode, reload_openvassd, init_ssl_ctx)
	(main_loop, init_network): Removed line feed at the end of log messages.

	* src/pluginlaunch.c (process_internal_msg, update_running_processes)
	(next_free_process, read_running_processes, pluginlaunch_init): Removed
	line feed at the end of log messages.

	* src/pluginload.c (plugins_reload_from_dir): Removed line feed at the
	end of log messages.

	* src/pluginscheduler.c (hash_fill_deps): Removed line feed at the end
	of log messages.

	* src/processes.c (create_process): Removed line feed at the end of log
	messages.

	* src/sighand.c (sighandler, sighand_segv): Removed line feed at the end
	of log messages.

	* src/utils.c (get_max_hosts_number, get_max_checks_number)
	is_client_present): Removed line feed at the end of log messages.

2014-07-31  Matthew Mundell <matthew.mundell@greenbone.net>

	* src/preferences.c (openvassd_defaults): Add unscanned_closed_udp.

2014-07-21  Michael Wiegand <michael.wiegand@greenbone.net>

	* INSTALL: Improve style of redis section.

	* doc/redis_config.txt: Fix typo.

2014-07-18  Michael Wiegand <michael.wiegand@greenbone.net>

	* tools/openvas-manage-certs.sh: Add support for GnuTLS "--sec-param"
	parameter and use it if the key size is not explicitly set.

2014-07-18  Michael Wiegand <michael.wiegand@greenbone.net>

	* tools/openvas-manage-certs.sh: Redirect both stdout and stderr of
	certtool invocation to log file since certtool sometimes prints error
	messages to stdout.

2014-07-17  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* tools/greenbone-nvt-sync: Added handling of "--help".

2014-07-17  Michael Wiegand <michael.wiegand@greenbone.net>

	* tools/openvas-manage-certs.sh: Check exit status of certtool and
	exit early if things went wrong.

2014-07-17  Michael Wiegand <michael.wiegand@greenbone.net>

	* tools/openvas-manage-certs.sh: Add missing comment. Only remove
	generation directory if the files were already copied somewhere else.

2014-07-17  Michael Wiegand <michael.wiegand@greenbone.net>

	* tools/openvas-manage-certs.sh: Add support for setting key size and
	signing algorithm. Document new settings in help. Actually append to
	log.

2014-07-16  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* tools/openvas-manage-certs.sh: Make cleanup depend on
	Debug mode.

2014-07-16  Michael Wiegand <michael.wiegand@greenbone.net>

	* tools/openvas-manage-certs.sh: Initial revision of new certificate
	management script.

2014-07-15  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/nasl_plugins.c (nasl_thread_args): New struct.
	(nasl_thread): Take a nasl_thread_args pointer as function argument.
	(nasl_plugin_launch): Adjust function call accordingly.

2014-07-11  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (attack_start): Don't attempt to randomly close all
	possibly open file descriptors. Close parent_socket.

	* src/nasl_plugins.c (nasl_thread): Reset kb link as this function is
	called in forked process. Don't attempt to close all possibly open file
	descriptors.
	(scanner_thread): Add socket fd to globals.

2014-07-10  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (attack_start_args): Add parent_socket element.
	(attack_start): Close unused sockets. Update code style.
	(attack_network): Set attack arguments accordingly.

	* src/nasl_plugins.c (nasl_thread): Close old socket file descriptor
	after duplicating it.

2014-07-10  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/pluginlaunch.c (struct running): Remove useless kb, name and sched
	elements.
	(update_running_processes, read_running_processes, plugin_launch):
	Update for running structure's changes.
	(pluginlaunch_child_cleanup): New function.

	* src/pluginlaunch.h: Add function prototype.

	* src/nasl_plugins.c (nasl_thread): Cleanup plugin launcher leftovers.

2014-07-09  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/hosts.c (struct host): Remove useless psoc element.
	(host_rm, hosts_set_pid): Adjust for host structure change.
	(hosts_new): Take host socket as a function argument instead of creating
	an unnamed socket pair. Adjust return value accordingly.

	* src/attack.c (attack_network): Adjust for hosts_new() function change.
	Close socket for child process after the fork.

2014-07-07  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/openvassd.c (check_client, get_x509_dname): Remove functions.
	(scanner_thread): Remove useless dname checking as user-management is
	not part of the scanner anymore.

	* tools/openvas-mkcert-client.in: Don't generate dname file.

	* doc/openvassd.8.in: Update documentation.

2014-07-02  Henri Doreau <henri.doreau@gmail.com>

	* src/openvassd (main): Removed clumsy and unneeded string duplication.

2014-07-02  Henri Doreau <henri.doreau@gmail.com>

	* src/openvassd.c (global_options): Change type to GHashTable.
	(arg_replace_value): Removed unused function.
	(main_loop, init_plugins, init_openvassd, main): Update operations on
	global_options and function prototypes accordingly.

2014-07-02  Henri Doreau <henri.doreau@gmail.com>

	* src/openvassd.c (global_options): Renamed variable for consistency.
	(global_iana_socket, global_plugins, global_preferences, global_options)
	(reload, loading_stop, ovas_scanner_ctx ): Mark as static and removed
	superfluous initializations.

2014-07-01  Hani Benhabiles  <hani.benhabiles@greenbone.net>
1538 1539 1540 1541 1542 1543 1544 1545

	* src/openvassd.c (gcrypt_init): New function.
	(main): Initialize libgcrypt.

	* CMakeLists.txt (GCRYPT_LDFLAGS, GCRYPT_CFLAGS): New variables.

	* src/CMakeLists.txt: Link against libgcrypt.

1546 1547 1548 1549
2014-06-26  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/hosts.c (forward), src/pluginlaunch.c (process_internal_msg): Fix
	memory leaks.
1550

1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561
2014-06-25  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* tools/openvas-mkcert.in, tools/openvas-mkcert-client.in: Sign
	certificates with SHA-256 instead of SHA1.

2014-06-11  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/openvassd.c (main): Better term for help info: "filename"
	instead of "rcfile" which was misleading.

2014-06-06  Michael Wiegand <michael.wiegand@greenbone.net>
1562 1563 1564 1565 1566 1567 1568

	* tools/greenbone-nvt-sync (init_sync): Ensure FEED_CURRENT is
	initialized.
	(do_sync): Remove superfluous and potentially confusing log messages.
	A synchronization may or may not take place in do_sync. If it takes
	place, sync_nvts will log more accurate messages anyway.

1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585
2014-06-05  Henri Doreau <henri.doreau@gmail.com>

	* src/openvassd.c (main): Replaced kb_flush() by flush_all_kbs().
	(flush_all_kbs): new function. Initialize a KB handle and flush all
	entries.

2014-06-05  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/openvassd.c (main): Flush all keyspaces in KB on start-up. This
	is done in order to not get stuck with left-overs from older scanner
	instances that were abruptly terminated during scans.

2014-06-02  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* tools/openvas-mkcert-client.in, tools/openvas-mkcert.in: Default to
	4096 bits RSA keys instead of 1024.

1586 1587 1588 1589
2014-05-30  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* tools/greenbone-nvt-sync: Fixed URL of feed home.

1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688
2014-05-27  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (init_host_kb): Add "Hostname" and "Host-IP" KB entries
	for the host's name and IP address values.

2014-05-22  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* doc/redis_config.txt: Added some more notes on using redis-cli.

2014-05-21  Henri Doreau <henri.doreau@gmail.com>

	* src/attack.c (KB_PATH_DEFAULT): Use definition from openvas-libraries.

2014-05-14  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* doc/openassd.8.in: Fix typo.

2014-05-08  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* doc/redis_config.txt: Added a secion how to use redis-cli
	for analysis and debugging purposes.

2014-05-02  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (fill_host_kb_ssh_credentials): Don't fill publickey ssh
	kb entry.

2014-05-02  Henri Doreau <henri.doreau@gmail.com>

	* COPYING: Updated according to recent changes.

2014-04-29  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* doc/example_redis_2_4.conf.in, doc/example_redis_2_6.conf.in: New.

	* INSTALL: Updated step 5 about redis to mention the above new examples.
	Also increased version of required openvas-libraries to 8.0.0.

	* CMakeLists.txt: Configure and install the two new example files.

2014-04-24  Henri Doreau <henri.doreau@gmail.com>

	* doc/redis_config.txt: Added information about how to configure redis
	to serve KBs.

2014-04-23  Henri Doreau <henri.doreau@gmail.com>

	* src/pluginlaunch.c (process_internal_msg): Remove dead code.

2014-04-23  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* CMakeLists.txt: Increase dependency to openvas-libraries
	from 7.0.0 to 8.0.0.

2014-04-23  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Post branch version bump.

	* CMakeLists.txt: Set to version to 5.0.0 and beta status.

2014-04-23  Henri Doreau <henri.doreau@gmail.com>

	Use the new KB interface exposed by openvas-libraries. Updated
	documentation to describe how to setup and configure a redis backend.

	* INSTALL: Added information about supported versions of redis and how
	to set it up for OpenVAS scanner.

	* src/save_kb.c, src/save_kb.c src/piic.c, src/piic.h, src/locks.c,
	src/locks.h: Removed unused files.

	* src/CMakeLists.txt: Updated accordingly.

	* src/plugs_req.c (key_missing, key_present): Updated to make use of the
	new KB interface and types.

	* src/pluginlaunch.c (process_internal_msg): Ignore obsolete KB update
	messages.

	* src/openvassd.c (scanner_thread): Define and expose a KB handle for
	network scan, delete it eventually if needed.

	* src/attack.h (attack_network): The function now takes an optional
	pointer to a network KB. Updated prototype accordingly.

	* src/attack.c (KB_PATH_DEFAULT, scanner_kb_path, network_scan_status)
	(kb_duplicate): new.
	(launch_plugin): Removed save_kb_* statements which aren't needed
	anymore.
	(check_kb_access, report_kb_failure): Introduced two functions to check
	if the scanner can reach the KB and report potential errors to the
	manager.
	(init_host_kb): Use the new KB initialization method. Propagate errors
	on failure. Removed save_kb_* statements which aren't needed anymore.
	(attack_host): Use the new KB interface. Propagate errors on failure.
	Eventually delete host KB.
	(attack_start): Receive, initialize and forward net KB handle if needed.
	reset KB link on fork.

1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585 2586 2587 2588 2589 2590 2591 2592 2593 2594 2595 2596 2597 2598 2599 2600 2601 2602 2603 2604 2605 2606 2607 2608 2609 2610 2611 2612 2613 2614 2615 2616 2617 2618 2619 2620 2621 2622 2623 2624 2625 2626 2627 2628 2629 2630 2631 2632 2633 2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644 2645 2646 2647 2648 2649 2650 2651 2652 2653 2654 2655 2656 2657 2658 2659 2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673 2674 2675 2676 2677 2678 2679 2680 2681 2682 2683 2684 2685 2686 2687 2688 2689 2690 2691 2692 2693 2694 2695 2696 2697 2698 2699 2700 2701 2702 2703 2704 2705 2706 2707 2708 2709 2710 2711 2712 2713 2714 2715 2716 2717 2718 2719 2720 2721 2722 2723 2724 2725 2726 2727 2728 2729 2730 2731 2732 2733 2734 2735 2736 2737 2738 2739 2740 2741 2742 2743 2744 2745 2746 2747 2748 2749 2750 2751 2752 2753 2754 2755 2756 2757 2758 2759 2760 2761 2762 2763 2764 2765 2766 2767 2768 2769 2770 2771 2772 2773 2774 2775 2776 2777 2778 2779 2780 2781 2782 2783 2784 2785 2786 2787 2788 2789 2790 2791 2792 2793 2794 2795 2796 2797 2798 2799 2800 2801 2802 2803 2804 2805 2806 2807 2808 2809 2810 2811 2812 2813 2814 2815 2816 2817 2818 2819 2820 2821 2822 2823 2824 2825 2826 2827 2828 2829 2830 2831 2832 2833 2834 2835 2836 2837 2838 2839 2840 2841 2842 2843
2014-04-23  Benot Allard  <benoit.allard@greenbone.net>

	Post release version bump.

	* CMakeLists.txt: 4.0.2

2014-04-23  Benot Allard  <benoit.allard@greenbone.net>

	Prepare for 4.0.1 release.

	* CHANGES: Updated

2014-04-14  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* CMakeLists.txt, src/CMakeLists.txt: Remove useless linking against
	libdl, libgpgme and libgcrypt.

2014-04-11  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/comm.c (comm_init): Adjust version buffers comparing size.

2014-04-10  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/comm.c (comm_init): Remove "beta" from OTP identifier.

2014-04-10  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Post release version bump.

	* CMakeLists.txt: Set version to 4.0.1.

2014-04-10  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Preparing the openvas-scanner 4.0.0 release.

	* CHANGES: Updated.

	* CMakeLists.txt: Set version to 4.0.0.

2014-04-07  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* README: Slightly re-phrased to include mentioning of the VM.

	* COPYING: Replaced fixed date by general term to simplify
	maintenance.

2014-04-04  Michael Wiegand <michael.wiegand@greenbone.net>

	Removed obsolete nasl_server_pid variable.

	* src/openvassd.c: Remove global variable nasl_server_pid.

	* src/sighand.c: Remove declaration of extern nasl_server_pid.
	(make_em_die): Remove handling of nasl_server_pid.

2014-04-04  Michael Wiegand <michael.wiegand@greenbone.net>

	Drop handling of "bpf_server" in openvas-scanner. The function in
	libraries always returned 0.

	* src/openvassd.c (main): Do not call bpf_server since it always
	returned 0.
	Remove global variable bpf_server_pid. Remove now superfluous include.

	* src/sighand.c: Remove declaration of extern bpf_server_pid.
	(make_em_die): Remove handling of bpf_server_pid.

2014-04-04  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/openvassd.c (get_x509_dname): Adjust for
	ovas_get_tlssession_from_connection() prototype change.

2014-04-02  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/openvassd.c (init_ssl_ctx): Use log_write() instead of fprintf()
	for log message.

2014-03-31  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/openvassd.c (init_ssl_ctx): Adjust ovas_scanner_new() call.

2014-03-28  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	Add --dh-params command-line option.

	* src/openvassd.c (init_ssl_ctx): Add dhparams function argument. Adjust
	ovas_scanner_context_new() call.
	(main): Add --dh-params cli option. Adjust init_ssl_ctx() call.

	* doc/openvassd.8.in: Update documentation.

2014-03-26  Benot Allard  <benoit.allard@greenbone.net>

	Post release version bump.

	* CMakeLists.txt: 4.0+beta10

2014-03-26  Benot Allard  <benoit.allard@greenbone.net>

	Preparing the openvas-scanner 4.0+beta9 release.

	* CHANGES: Update

2014-03-23  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/nasl_plugin.c (nasl_plugin_add): Removed extra signature
	check during cache build. It was only done to retrieve fingerprints.
	The subsequent exec_nasl_script will drop the NVT anyway if
	signature is not OK.
	This decreases the initial build time of the cache by around 80%.

2014-03-23  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Drop sending of signature keys to the client. These information are
	not used on OpenVAS Manager side. The original idea of knowledge about
	NVT signer has turned out to be of little value because feeds are
	typically not aggregated from different sources but rather provided
	from a single source.

	* src/comm.c (send_plug_info): Do not send the signature keys any more.

2014-03-21  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	Add --gnutls-priorities option for the scanner.

	* src/openvassd.c (loading_client_handle, scanner_thread): Adjust
	ovas_context_attach() calls.
	(init_ssl_ctx): Add priority parameter.
	(main): Add --gnutls-priority option, defaulting to normal. Adjust
	init_ssl_ctx() call.

	* doc/openvassd.8.in: Update for the new option.

2014-03-20  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/openvassd.c (loading_client_handle, scanner_thread): Adjust
	ovas_scanner_context_attach call.
	(ssl_ver_to_encaps): Delete function.
	(init_ssl_ctx): Always create ovas_scanner_ctx with
	OPENVAS_ENCAPS_TLScustom.

2014-03-19  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	Report current and total number of loading plugins to clients when
	scanner is still loading.

	* src/comm.c (comm_loading): Send current and total loading values with
	SCANNER_LOADING otp command.

	* src/openvassd.c: Delete include of removed file.
	(loading_handler_start, loading_handler_stop): Initialize and destroy
	loading plugins shared memory.

	* src/pluginload.c (init_loading_shm, destroy_loading_shm)
	(current_loading_plugins, total_loading_plugins)
	(set_current_loading_plugins, set_total_loading_plugins): New functions.
	(plugins_reload_from_dir): Update number of currently and total loading
	plugins in the shared memory to be seen by other processes.

	* src/pluginload.h: Add function prototypes.

2014-03-18  Michael Wiegand <michael.wiegand@greenbone.net>

	Post release version bump.

	* CMakeLists.txt: Set version to 4.0+beta9.

2014-03-18  Michael Wiegand <michael.wiegand@greenbone.net>

	Preparing the openvas-scanner 4.0+beta8 release.

	* CHANGES: Updated.

2014-03-18  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/openvassd.c (main): In only cache mode, refresh the plugins cache
	early, without listening on the network and skipping other
	unused initializations.

2014-03-17  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/openvassd.c (sighand_loading_stop): New function.
	(loading_handler_start): Add SIGTERM handler for loading handler child
	process. This ensures the loading handler isn't abruptly terminated by
	the parent while responding to a client.

2014-03-17  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* tools/greenbone-nvt-sync (update_openvassd, update_openvasmd): Add
	PID to log and unify log message in error case.

2014-03-17  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Removed outdated and unmaintained documentation remains.

	* doc/kb_entries.txt: Removed. This is an outdated list and unmaintained
	since ages. The NVTs as such are the primary source on what KB entries
	are set.

	* doc/nsr_file_format.txt: Removed. Outdated and unmaintained.

	* doc/nbe_file_format.txt: Removed. Outdated and unmaintained.

2014-03-17  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/comm.c (comm_loading): Receive all lines sent by client before
	closing the connection.

2014-03-17  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	Handle OTP version 2.0 only. Handle NVT_INFO OTP client command.

	* src/comm.c (comm_init): Only handle OTP version 2.0. Return 0 on
	success.

	* src/ntp.c (ntp_parse_input): Handle NVT_INFO client request. Remove
	useless code.

	* src/openvassd.c (handle_client): Remove protocol_version argument and
	related code.
	(scanner_thread): Adjust comm_init() and handle_client() calls.

	* src/otp.c (otp_get_client_request): Handle CREQ_NVT_INFO case.

	* src/otp.h (client_request_t): Add CREQ_NVT_INFO value.

2014-03-15  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Resolve need for misc/otp.h.

	* src/comm.c (comm_loading): Use the keyword "SCANNER_LOADING"
	directly.
	(comm_init): Use a integer directly for the OTP version.

	* src/openvassd.c (handle_client): Use a integer directly for
	OTP version.

2014-03-15  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Rename module npt_11 to just ntp.

	* src/ntp_11.h, src/ntp.h: Renamed ntp_11.h to ntp.h.

	* src/ntp_11.c, src/ntp.c: Renamed ntp_11.c to ntp.c and adjust include
	accordingly.

	* src/utils.c, src/openvassd.c, src/hosts.c, src/comm.c, src/attack.c:
	Adjust include accordingly.

	* COPYING, src/CMakeLists.txt: Adjust module name accordingly.

2014-03-15  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Drop the version indicator for NTP (actually is OTP) as this
	does not make sense code-wise.

	* src/ntp_11.h, src/ntp_11.c, src/comm.c, src/hosts.c, src/openvassd.c,
	src/attack.c: Replaced any "ntp_11_" and "ntp_1x" name by just "ntp_".

2014-03-15  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Rename module opt_1_0 to just otp.

	* src/otp_1_0.h, src/otp.h: Renamed otp_1_0.h to otp.h.

	* src/otp_1_0.c, src/otp.c: Renamed otp_1_0.c to otp.c and adjust include
	accordingly.

	* src/ntp_11.c: Adjust include accordingly.

	* COPYING, src/CMakeLists.txt: Adjust module name accordingly.

2014-03-14  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Drop the version indicator for OTP as this does not make sense
	code-wise.

	* src/otp_1_0.h, src/otp_1_0.c, src/ntp_11.c: Replaced any "otp_1_0_"
	name by just "otp_".

2014-03-14  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	Remove sending of PLUGINS_DEPENDENCIES sending upon client connect with
	protocol version 2.0.

	* src/ntp_11.c (qsort_cmp, _find_plugin, find_plugin)
	(ntp_1x_send_dependencies): Delete unused functions.

	* src/openvassd.c (handle_client): Do not send plugin dependencies in
	protocol version 2.0 case.

	* src/ntp_11.h: Remove deleted function prototype.

2014-03-14  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/openvassd.c (loading_handler_start): Set the sigterm signal
	callback to default for the forked child.
	(loading_handler_stop): Wait for the terminated child process.

2014-03-12  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	Start the loading handler process when scanner is reloaded too.

	* src/openvassd.c (loading_client_handle, loading_handler_start)
	(loading_handler_stop): Move definitions up.
	(reload_openvassd): Start loading handler before reloading config and
	plugins and stop it after finishing.

2014-03-12  Michael Wiegand <michael.wiegand@greenbone.net>

	Post release version bump.

	* CMakeLists.txt: Set version to 4.0+beta8.

2014-03-12  Michael Wiegand <michael.wiegand@greenbone.net>

	Preparing the openvas-scanner 4.0+beta7 release.

	* CHANGES: Updated.

2014-03-12  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Removed OTP command "CERTIFICATES". It was used by the old GTK client
	to retrieve the signing keys for NVT feed content. The core idea at
	that time was that we have feed content with mixed author signing keys.
	This turned out to not get into practice. In case it is needed
	eventually it could be added anew based on future OSP protocol.

	* src/otp_1_0.c (otp_1_0_get_client_request): Removed processing of
	command CERTIFICATES.
	(otp_1_0_server_send_certificates): Removed.

	* src/ntp_11.c (ntp_11_parse_input): Removed processing of
	CREQ_CERTIFICATES.

	* src/otp_1_0.h: Removed enum element CREQ_CERTIFICATES.

2014-03-11  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/comm.c (comm_init): Return -1 instead of exit() on error.
	(comm_loading): New function.

	* src/comm.h: Add function header.

	* src/openvassd.c (restart): Rename to reload.
	(scanner_thread): Check comm_init return value accordingly.
	(check_and_reload): New function.
	(main_loop): Call new function. Improve code structure and remove
	duplication.
	(loading_client_handle, loading_handler_start, loading_handler_stop):
	New functions.
	(main): Call loading handlers.

	* src/pluginload.c (plugins_reload_from_dir): Style fix.

	* src/sighand.c (sighand_chld): Add pid argument. Only wait for the
	specified child process. This fixes catching a SIGCHLD signal from gpgme
	when checking a plugin's fingerprint and waiting for the loading
	handler process.

2014-03-10  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/openvassd.c (get_x509_dname, handle_client): New functions.
	(scanner_thread): Move code to new functions. Improve code style and
	structure and remove useless and duplicate parts.
	(main_loop): Don't call init_ssl_ctx(). Reduce variable scope.
	(set_daemon_mode): New function.
	(main): Call init_ssl_ctx() and set_daemon_mode() and restructure code
	adequately.

	* src/ntp_11.c: Remove DEBUG_SSL definition as never used.

2014-03-10  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/openvassd.c: Remove unneeded defines and prototypes redeclarations.
	(scanner_thread): Remove useless code.
	(init_ssl_ctx, ssl_ver_to_encaps): New functions.
	(main_loop): Move code to new functions. Fix style and remove unneeded
	code accordingly.

2014-03-07  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/openvassd.c (plugins_reload): Remove function.
	(plugins_init): Call plugins_reload_from_dir() directly.

2014-03-07  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/openvassd.c (main_loop): Change asciiaddr and old_addr into
	statically allocated buffers. Remove unused code related to libwrap
	support.

2014-03-06  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c: Include misc/openvas_proctitle.h instead of
	misc/proctitle.h.
	(attack_host): Call proctitle_set instead of setproctitle.

	* src/nasl_plugins.c: Include misc/openvas_proctitle.h instead of
	misc/proctitle.h.
	(nasl_thread): Call proctitle_set instead of setproctitle.

	* src/openvassd.c: Include misc/openvas_proctitle.h instead of
	misc/proctitle.h.
	(scanner_thread, main_loop): Call proctitle_set instead of setproctitle.
	(main): Call proctitle_init instead of initsetproctitle.

2014-03-06  Benot Allard  <benoit.allard@greenbone.net>

	* doc/openvassd.8.in, doc/openvas-mkcert.8: Fix typos reported by
	  lintian.

2014-03-06  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/pluginload.c (calculate_eta): New function
	(plugins_reload_from_dir): Remove useless progress printing to stdout as
	process is now in background. Add an estimation of remaining time to
	reload plugins to the process title.
	(plugins_init, plugins_reload): Remove progress function argument.
	(spin_progress): Remove function.

	* src/pluginload.h: Adjust functions prototypes.

	* src/openavssd.c (reload_openvassd, init_openvassd, main): Adjust
	function calls.
	(init_plugins): Remove progress function argument.

	* doc/openvassd.8.in: Remove progress option documentation.

2014-03-05  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (launch_plugin): Fix possible null pointer dereference.

2014-03-05  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/openvassd.c (main_loop): Fix use after free issue. Code style fix.

2014-03-05  Michael Wiegand <michael.wiegand@greenbone.net>

	Post release version bump.

	* CMakeLists.txt: Set version to 4.0+beta7.

2014-03-05  Michael Wiegand <michael.wiegand@greenbone.net>

	Preparing the openvas-scanner 4.0+beta6 release.

	* CHANGES: Updated.

2014-03-04  Henri Doreau <henri.doreau@gmail.com>

	* src/attack.c (attack_host.c): Replaced a select() statement by an
	equivalent sleep() for readability.

2014-03-04  Henri Doreau <henri.doreau@gmail.com>

	* src/attack.c (init_host_kb, attack_start, attack_host): Minor style
	fixes.

2014-03-03  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/openvassd.c (set_globals_from_preferences): Remove plugins
	function argument. Don't set global plugins value.
	(reload_openvassd): Reset global plugins value.
	(init_plugins): New function.
	(init_openvassd): Fix function documentation. Remove progress function
	argument. Don't initialize plugins. Adjust function call.
	(main): Initalizae plugins before calling main_loop, and after forking
	background process in daemon mode.

2014-03-03  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/openvassd.c (init_openvassd): Defer initializing plugins after
	init_network call.

2014-02-28  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/pluginload.c (plugins_reload_from_dir): Update scanner process
	title to show plugins reloading progress.

2014-02-25  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (launch_plugin, attack_start): Reduce variables scopes.

	* src/comm.c (send_plug_info): Remove useless variable initialization.

	* src/hosts.c (forward, hosts_read_client): Reduce variables scopes.

	* src/locks.c (file_lock): Reduce variable scope.

	* src/log.c (log_init): Remove useless checks. Directly use setlinebuf.

	* src/nasl_plugins.c (nasl_thread): Reduce variables scopes. Remove
	setting of rlimit values as it is dead code. Remove useless variable
	initialization.

	* src/ntp_11.c (ntp_11_read_prefs): Reduce variables scopes.

	* src/openvassd.c (start_daemon_mode): Remove dead code. Call setlinebuf
	directly.
	(check_client, main_loop, main): Reduce variables scopes. Style fix.

	* src/pluginlaunch.c (wait_for_children): Style update.

	* src/pluginload.c (plugins_load_from_dir): Reduce variables scopes.

	* src/pluginscheduler.c (hash_add, hash_fill_deps)
	(enable_plugin_and_dependencies): Reduce variables scopes. Style
	fix.

	* src/save_kb.c (save_kb_entry_present_already, save_kb_rm_entry_value)
	(save_kb_new): Reduce variables scopes.

	* src/sighand.c (sighandler, sighand_segv): Close log before exiting.

2014-02-20  Henri Doreau <henri.doreau@gmail.com>

	* src/attack.c (attack_network): Fixed memory leak.

2014-02-18  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (attack_init_hostinfos, attack_init_hostinfos_vhosts):
	Fix fqdn arg string length.
	(attack_network): Set adequate attack args fqdn value for all host types
	as the api handles it.

2014-02-16  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Post release version bump.

	* CMakeLists.txt: Set version to 4.0+beta6.

2014-02-16  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* CHANGES: Updated.

2014-02-12  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/sighand.h: Removed "extern" declaration for any protos.
	This is of no use.

2014-02-12  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/sighand.h: Removed protos for sighand_pipe, sighand_alarm_plugin,
	sighand_term, sighand_int, sighand_kill, sighand_sigusr1, sighand_io.
	These are not defined anywhere nor used.

2014-02-12  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	Remove dead code and fix memory leaks. Found using cppchecker.

	* src/openvassd.c (set_globals_from_preferences): Call plugins_free
	instead of arg_free, fixing memory leaks.

	* src/CMakeLists.txt: Don't build parser.c

	* src/parser.c, src/parser.h: Remove unused files.

	* COPYING: Remove parser.c and parser.h details.

	* src/processes.c (sighand_process_term): Remove unused function.

	* src/sighand.c, src/sighand.h (sighand_alarm): Remove unused function.

	* src/utils.c, src/utils.h (hosts_arglist_to_string): Remove unused
	function.

2014-02-05  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/attack.c (attack_network): Removed outdated docstring element.

2014-02-05  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/comm.c (comm_terminate): Removed commented-out code fragements.
	It hangs around since at least 9 years.
	(comm_init, comm_wait_order): Write log message when exiting.

2014-02-05  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/attack.c (attack_network): Changed return type from int
	to void because it is always returned success anyway (problems
	are reported as errors which is sufficient).

	* src/attack.h: Adjust proto accordingly.

2014-02-05  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/attack.c (scanner_thread): Don't exit early out of
	otp communication. The attack_network method does
	never return anything else than 0 anyway.

2014-02-05  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	There is no reason why the OTP communication should be interrupted
	in cases where a scan can not be executed (due to whatever reason).
	It is far better continue OTP communication for two reasons: One the
	one hand this way the status of a task can be set to "Error" instead
	of "Stopped".

	* src/attack.c (attack_network): In case no target hosts were
	provided issue an error message and return with OK which prevents
	bailing out of otp.
	In case the interface was not authorized an  error message and
	return with OK which prevents bailing out of otp.

2014-02-05  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/plugs_req.c (get_closed_udp_ports): Call kb_get_port_state_proto()
	only for valid port numbers.

2014-02-04  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c: Include base/openvas_networking.h. Remove getpts
	extern declaration.
	(attack_network): Validate port_range with validate_port_range() and
	send an error message to client upon failure.

2014-01-29  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/nasl_plugins.c (nasl_plugin_launch): Removed computation of
	timeout. It is a dead assignment anyway. The timeout computation
	actually happens in pluginlaunch.c(plugin_launch) in the same
	way.

2014-01-29  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/utils.c (list2args): Removed dead initial assignment of t.
	That variable is anyway initialized in the while-loop.

2014-01-29  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* INSTALL: Add section about CLang and added some notes on
	SIGHUP and pid file.

2014-01-27  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/pluginscheduler.c (enable_plugin_and_dependencies): Return
	directly when plugin was already enabled.

2014-01-27  Michael Wiegand <michael.wiegand@greenbone.net>

	* tools/greenbone-nvt-sync: Add "--omit-dir-times" to rsync options to
	improve compatibility in situations where it is not possible to set
	directory modification times.

2014-01-27  Michael Wiegand <michael.wiegand@greenbone.net>

	* tools/greenbone-nvt-sync: Factor out remaining rsync options, using
	long options to improve readability. Ensure RSYNC_VERBOSE setting is
	honored.

2014-01-21  Michael Meyer <michael.meyer@greenbone.net>

	* tools/greenbone-nvt-sync: Typo fixed.

2014-01-20  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/pluginscheduler.c (enable_plugin_and_dependencies): Add hash table
	argument to detect circular dependencies in recursive calls.
	(plugins_scheduler_init): Adjut enable_plugin_and_dependencies call
	accordingly.

2014-01-15  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/plugs_req.c, src/plugs_req.h, src/attack.c: Improved
	code formatting.

2014-01-15  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/pluginlaunch.h: Removed unneeded proto for nasl_plugin_launch.

2014-01-15  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/pluginload.c (plugins_reload_from_dir): Improved code
	formatting.

2014-01-10  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/nasl_plugins.c, src/plugs_req.c, src/plugs_req.h, src/attack.c,
	src/save_kb.c, src/save_kb.h, src/pluginlaunch.c, src/pluginlaunch.h,
	src/pluginload.h: Use new typedef kb_t.

2014-01-10  Benoit Allard  <benoit.allard@greenbone.net>

	Post release version bump.

        * CMakeLists.txt: Set version to 4.0+beta5.

2014-01-10  Benoit Allard  <benoit.allard@greenbone.net>

	* CHANGES: Set release date for openvas-scanner-4.0+beta4 to 2014-01-10

2014-01-10  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/openvassd.c (restart_scanner): Ignore SIGHUP signals while
	reloading. Rename function to reload_scanner. Adjust log messages.
	(sighup): Move function definition up. Remove log writing call.
	(main_loop): Adjust scanner reloading title.

2014-01-10  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* tools/greenbone-nvt-sync: Renamed --synconly to sync-only to match
	OpenVAS style.

2014-01-09  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* tools/greenbone-nvt-sync: New option --synconly that will prevent
	updating of scanner and manager.
	(restart_openvassd): Renamed to update_openvassd and changed
	the restart directive of start-stop-daemon to the new SIGHUP mechanism.
	(update_openvasmd): Consistent wording with update_openvassd.
	(do_sync): Fix bug for refresh-only mode: Even the current-test should
	not be executed.

2014-01-09  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* CHANGES: Updated. But set no date yet.

2014-01-09  Matthew Mundell <matthew.mundell@greenbone.net>

	Remove --quiet option, making the NVT load messages depend on new option
	--progress instead.  Match the messages to the Manager style.

	* doc/openvassd.8.in: Replace --quiet with --progress.

	* src/openvassd.c (orig_argv): Remove.
	(init_openvassd): Replace quiet arg with progress arg.
	(main): Remove orig_argv processing.  I can't find anything that uses
	this variable.  Replace --quiet with --progress.

	* src/pluginload.c (plugins_init): Replace quiet arg with progress arg.
	(spin_progress): New function.
	(plugins_reload_from_dir): Replace quiet arg with progress arg.  Use
	"NVT" instead of "plugin" in progress messages.  Make the messages
	look more like the Manager ones.  Add load percent next to the total.

2014-01-09  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/openvassd.c: Remove useless include.

2014-01-07  Henri Doreau <henri.doreau@gmail.com>

	* src/pluginscheduler.c (plugin_next_unrun_dependencie): Removed unused
	variable 'counter'. Fixed unsafe use of 'flags'. Fixed and reduced
	indentation. Fixed braces(!).

2014-01-07  Henri Doreau <henri.doreau@gmail.com>

	* src/pluginscheduler.c (hash_get_deps_ptr): Removed useless code.

2014-01-06  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Preparing the openvas-scanner 4.0+beta4 release.

	* CHANGES: Updated. But set no date yet.

2014-01-06  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* doc/openvas-nvt-sync.8, INSTALL: Mention the new SIGHUP
	behaviour.
2014-01-07  Henri Doreau <henri.doreau@gmail.com>

	* src/pluginscheduler.c (hash_get_deps_ptr): Removed useless code.

2013-12-31  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/openvassd.c (set_globals_from_preferences): Also set the
	global_plugins values.
	(restart_openvassd): Reload the nvt plugins. Adjust
	set_globals_from_preferences accordingly.
	(main_loop): Set the process title before and after the reset of the
	plugins and the config.
	(init_openvassd): Adjust set_globals_from_preferences call. Remove
	nvticache creation code.

	* src/pluginload.c: Include base/nvticache.h
	(plugins_init): Create nvti_cache and set preferences accordingly.

2013-12-31  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/openvassd.c (set_globals_from_preferences): New function.
	(restart_openvassd): Reload the configuration file
	(sighup): Update log message.
	(init_openvassd): Change code to call set_globals_from_preferences.
	(main): Don't set global_preferences variable.

	* src/preferences.c (preferences_process): Set the config_file arg to
	the provided filename value.

2013-12-30  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/comm.c (comm_send_preferences): Check the preference via
	is_scanner_only_pref instead of using a list of hard-coded values.

	* src/ntp_11.c (is_scanner_only_pref): Adjust sys values matching. Move
	function to src/utils.h

	* src/utils.h: Add is_scanner_only_pref prototype.

2013-12-13  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/comm.c (comm_send_preferences): Remove server_info preferences as
	they have no use for the manager. Do not send scanner-side only
	preferences which are prefixed with sys_.

2013-12-11  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* INSTALL: Drop step 1.2 about rules file and make an
	extended version of 1.1 to item 2, adapting subsequent enumeration.

	* doc/openvassd.rules: Removed. rules are now configured via
	openvassd.conf.

2013-12-10  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/pluginload.h (plugin_init_t, plugin_run_t) Removed these
	typedefs since they are not used anymore.

2013-12-10  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* COPYING: Remove module, added missing one and fixed a license.

2013-12-10  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (launch_plugin): Adjust plugin_launch function call.

	* src/nasl_plugins.c (nasl_plugin_init): Remove unused function.
	(nasl_plugin_class): Remove unused structure.

	* src/pluginlaunch.c (plugin_launch): Remove launcher argument as only
	nasl_plugin_launch is used now.

	* src/pluginlaunch.h: Add and adjust function prototypes adequately.

	* src/pluginload.c (plugin_classes): Remove unused variable.
	(init_plugin_classes): Delete unused function.
	(collect_nvts): Don't iterate over plugin classes as only .nasl plugins
	are supported.
	(plugins_reload_from_dir): Remove init_plugin_classes call. Don't
	iterate over plugins classes as only .nasl plugins are supported.

	* src/pluginload.h: Add function prototype and remove pl_class_s struct.
	Delete externs.

2013-12-10  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/oval_plugins.c: Delete file.

	* src/CMakeLists.txt: Don't build deleted file.

	* src/pluginload.c (init_plugin_classes): Remove oval plugin class from
	plugins classes list.

2013-11-21  Michael Wiegand <michael.wiegand@greenbone.net>

	Post release version bump.

	* CMakeLists.txt: Set version to 4.0+beta4.

2013-11-21  Michael Wiegand <michael.wiegand@greenbone.net>

	Preparing the openvas-scanner 4.0+beta3 release.

	* CHANGES: Updated.

2013-11-19  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* doc/openvassd.8.in: Removed section "THE RULE SET FORMAT"
	and "THE RULES DATABASE" because the old rules schema and formats
	has been replaced by a new scheme that is simplified and completely
	handled via scanner preferences and openvassd config file.
	Also removed description of config preference "rules" which is not
	handled anymore.

2013-11-19  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* doc/openvassd.8.in: Removed reference to openvas(1) because
	there is no such man page.

2013-11-14  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (host_authorized): Add addr parameter. Adjust calls to
	openvas_host_in_hosts.
	(attack_network): Adjust calls to host_authorized.

	* doc/openvassd.8.in: Update documentation for host access behavior with
	hostnames.

2013-11-14  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/ntp_11.c (is_scanner_only_pref): New function to check for
	scanner-only prefrences.
	(ntp_11_read_prefs): Use new fuction.

2013-11-13  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (iface_authorized): Check access with sys_ifaces_allow and
	sys_ifaces_deny preferences and return value accordingly.
	(apply_source_iface_preference): Handle iface_authoried return value.
	(attack_network): Also apply hosts access control with sys_hosts_allow
	and sys_hosts_deny preferences.

	* src/ntp_11.c (ntp_11_read_prefs): Add sys_hosts_allow, sys_hosts_deny,
	sys_ifaces_allow and sys_ifaces_deny as scanner-side only preferences.

	* doc/openvassd.8: Update documentation for the new scanner-side
	preferences.

2013-11-12  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/openvassd.c (main_loop): Duplicate asciiaddr into old_addr.

2013-11-12  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (attack_network), src/openvassd.c (main_loop): Fix some
	memory leaks.

2013-11-12  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (attack_network): Return error for erroneous source
	interface value too and not just when access to it is denied.

2013-11-11  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* CMakeLists.txt, src/CMakeLists.txt: Adjust for removal of old rules
	system.

	* src/attack.c: Don't include rules.h
	(attack_networks): Remove rules checking.

	* src/comm.c: Don't include rules.h
	(comm_send_rules): Delete function.
	(comm_send_preferences): Remove check for rules preference.

	* src/ntp_11.c: Don't include rules.h
	(ntp_11_rules): Delete function.
	(ntp_11_parse_input): Don't handle CREQ_RULES case.
	(ntp_11_read_prefs): Remove rules special case checking.

	* src/openvassd.c: Don't include rules.h. Remove global_rules.
	(scanner_thread, main_loop, main): Remove rules handling.
	(init_openvassd): Don't initialize rules.

	* src/otp_1_0.c (otp_1_0_get_client_request): Don't handle RULES
	command.
	(client_request_t): Remove CREQ_RULES.
	(openvassd_defaults): Remove rules default.

	* src/rules.h, src/rules.c: Delete files.

	* COPYING: Remove rules license.

2013-11-08  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* doc/openvassd.8.in: Add documentation for hosts_allow and hosts_deny.

	* src/attack.c (host_authorized): New function.
	(attack_network): Use host_authorized to determine host access. Use
	adequate error messages to client and log entries when access is denied
	instead of using E002 error of OTP.

2013-11-08  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (apply_source_iface_preference): Return value for success
	or error, accordingly.
	(attack_network): Handle apply_source_iface_preference return value.

	* doc/openvassd.8.in: Update source_iface documentation.

2013-11-05  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/pluginlaunch.c (update_running_processes): Fix array out of bounds
	that caused segfault under rare situations.

2013-11-05  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (iface_authorized): Remove unneeded log writes.

2013-11-05  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* doc/openvassd.8.in: Update documentation.

	* src/attack.c (apply_hosts_preferences): Log the hosts_ordering method
	used.
	(str_in_comma_list): New function.
	(iface_whitelisted): Rename to iface_authorized. Accordingly check for
	ifaces_allow and ifaces_deny preferences instead.
	(apply_source_iface_preference): Adjust iface_authorized call.

2013-10-31  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* doc/openvassd.8.in: Update documentation for ifaces_whitelist scanner
	preferences.

2013-10-31  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* attack.c (iface_whitelisted): New function.
	(apply_source_iface_preference): Check if interface name is authorized
	in ifaces_whitelist before using it as a source interface.

2013-10-31  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* attack.c (error_message_to_client): New function.
	(apply_source_iface_preference): Push error message to client when there
	is an error with the specified source interface.
	(attack_network): Adjust apply_source_iface_preference call. Use
	error_message_to_client to push error message for host unresolved name.

2013-10-29  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* openvassd.8.in: Update command-line documentation.

2013-10-29  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/oval_plugins.c (text, oval_plugin_add): Don't set nvti
	description.

2013-10-21  Michael Wiegand <michael.wiegand@greenbone.net>

	* tools/greenbone-nvt-sync: Add support for determining if the
	installed feed is current and only sync feed when it is not.

2013-10-21  Michael Wiegand <michael.wiegand@greenbone.net>

	* tools/greenbone-nvt-sync: Use "logger" command for logging. Remove
	superfluous and verbose output to stderr. Make rsync parameters easier
	to manage. Ensure rsync uses maximum compression. Use rsync "--perms
	--chmod" functionality to ensure correct NVT permissions.

2013-10-18  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (apply_source_iface_preference): New function.
	(attack_network): Apply source_iface scanner preference.

	* src/openvassd.c (convert_ip_addresses): Remove unused function.
	(main): Remove src-ip option handling.

	* doc/openvassd.8.in: Update man page.

2013-10-17  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (apply_hosts_preferences): New function.
	(attack_network): Call apply_hosts_preferences instead of checking and
	applying hosts related preferences.

2013-10-14  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/comm.c (send_plug_info): Don't send plugin description.

2013-10-04  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (attack_start_args): Remove hostname member. Add fqdn
	member.
	(attack_init_hostinfos_vhosts, attack_init_hostinfos): Add fqdn
	parameter. Set FQDN host info.
	(attack_start): Stringify host ip instead of using args hostname. Adjust
	attack init function calls. Rename hostname variable.
	(attack_network): Use openvas_host to get the fqdn in attack start args.

2013-10-04  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (attack_network): Always use the string representation of
	IPv4 and IPv6 addresses when a hostname is provided.

2013-10-03  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (attack_network): Send error message to manager when a
	hostname is unresolvable.

2013-09-30  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/preferences.c (openvassd_defaults): Remove unused reverse_lookup
	value.

2013-09-29  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/comm.c (send_plug_info): Remove unused variable "t".

2013-09-29  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/comm.c (send_plug_info): Always send NODESC for description
	instead of sending it only if the NVTI is a newstyle one.
	Also remove the ignoring of the NVTI in case no description is present
	because this is automatically void now.

2013-09-26  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	Post release version bump.

	* CMakeLists.txt: Set version to 4.0+beta3.

2013-09-26  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	Preparing the openvas-scanner 4.0+beta2 release.

	* CHANGES: Updated.

2013-09-18  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (attack_network): Adjust openvas_hosts_exclude call.

2013-09-12  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	Add support for reversed hosts_ordering.

	* src/attack.c (attack_network): Call openvas_hosts_reverse when
	ordering value is reversed. Update comment.

2013-09-12  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	Add support for reverse_lookup_unify scanner preference.

	* src/attack.c (attack_network): Check for reverse_lookup_unify. Update
	other preferences logging style and comments.

2013-09-11  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/attack.c: (attack_start): Remove again the sending
	of FINISHED. It confuses the clients, they don't need this
	extra message.

	* src/ntp_11.c (ntp_11_parse_input): Don't send FINISHED upon
	STOP_ATTACK, HOST_INTERRUPTED is sufficient for the time being.
	(ntp_11_show_end): Removed.

	* src/ntp_11.h: Removed proto accordingly.

2013-09-11  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	Add support for reverse_lookup_only scanner preference.

	* src/attack.c (attack_network): Check for reverse_lookup_only
	preference adequately. Fix log message style.

2013-09-10  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/preferences.c: Removed all now-unneeded includes.
	(preferences_get_checks_read_timeout): Removed.  It is an unused
	function.
	(preferences_reset_cache): Don't call removed function anymore.
	(inited): Removed unused macro.

	* src/preferences.h: Removed proto accordingly.

2013-09-10  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	Add support for exclude_hosts scanner preference.

	* src/attack.c (attack_network): Call openvas_hosts_exclude when
	exclude_hosts value is provided.

2013-09-10  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/preferences.c (preferences_autoload_dependencies): Removed.
	(preferences_reset_cache): Don't reset "autoload_dependencies" anymore.
	Caching is not relevant for this preference anyway, it is called once per attack.
2844

2845 2846 2847 2848 2849 2850 2851 2852 2853 2854 2855 2856 2857 2858 2859 2860 2861 2862 2863 2864 2865 2866 2867 2868 2869 2870 2871 2872 2873 2874 2875 2876 2877 2878 2879 2880 2881 2882 2883 2884 2885 2886 2887 2888 2889 2890 2891 2892 2893 2894 2895 2896 2897 2898 2899 2900 2901 2902 2903 2904 2905 2906 2907 2908 2909 2910 2911 2912 2913 2914 2915 2916 2917 2918 2919 2920 2921 2922 2923 2924 2925 2926 2927 2928 2929 2930 2931 2932 2933 2934 2935 2936 2937 2938 2939 2940 2941 2942 2943 2944 2945 2946 2947 2948 2949 2950 2951 2952 2953 2954 2955 2956 2957 2958 2959 2960 2961 2962 2963 2964 2965 2966 2967 2968 2969 2970 2971 2972 2973 2974 2975 2976 2977 2978 2979 2980 2981 2982 2983 2984 2985 2986 2987 2988 2989 2990 2991 2992 2993 2994 2995 2996 2997 2998 2999 3000 3001 3002 3003 3004 3005 3006 3007 3008 3009 3010 3011 3012 3013 3014 3015 3016 3017 3018 3019 3020 3021 3022 3023 3024 3025 3026 3027 3028 3029 3030 3031 3032 3033 3034 3035 3036 3037 3038 3039 3040 3041 3042 3043 3044 3045 3046 3047 3048 3049 3050 3051 3052 3053 3054 3055 3056 3057 3058 3059 3060 3061 3062 3063 3064 3065 3066 3067 3068 3069 3070 3071 3072
	* src/preferences.h: Remove proto accordingly.

	* src/attack.c (attack_network): Replace the explicit call for
	autoload_dependencies preference by generic bool check. In case of an error,
	apply a default that is sensible in this context.

2013-09-10  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/preferences.h: Remove yet another two forgotten protos.

2013-09-10  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/preferences.h: Remove forgotten proto.

2013-09-10  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/preferences.c (preferences_save_session): Removed.
	It is an unused function.
	(preferences_reset_cache): Don't call removed function anymore.

2013-09-10  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/preferences.h: Remove forgotten proto of recent commit.

2013-09-10  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/preferences.c (preferences_save_empty_sessions): Removed.
	It is an unused function.
	(preferences_reset_cache): Don't call removed function anymore.

2013-09-10  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Removing support for Scanner preference "ntp_opt_show_end" and instead
	show the end always.

	* src/attack.c (attack_start): Show protocol end message (FINISHED) always.
	It is send already always when stopping a scan.

	* src/preferences.c (preferences_ntp_show_end): Removed.
	(preferences_reset_cache): Don't reset "ntp_show_end" anymore.

2013-09-10  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/preferences.c (preferences_use_mac_addr): Removed.
	(preferences_reset_cache): Don't reset "use_mac_addr" anymore. Caching is
	not relevant for this preference anyway, it is called once per host.

	* src/preferences.h: Remove proto accordingly.

	* src/attack.c (attack_network): Replace the explicit call for
	use_mac_addr preference by generic bool check. In case of an error,
	apply a default that is sensible in this context.

2013-09-10  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/preferences.c (preferences_report_killed_plugins): Removed.
	It is an unused function.
	(preferences_reset_cache): Don't call removed function anymore.

	* src/preferences.h: Removed proto accordingly.

2013-09-10  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/preferences.c (preferences_network_scan): Removed.
	(preferences_get_bool): New. Generically check for "yes"/"no" settings.
	(preferences_reset_cache): Don't reset "network_scan" anymore. Caching was
	not relevant for this preference anyway, it is called once per scan.

	* src/preferences.h: Add/remove protos accordingly.

	* src/attack.c (attack_network): Replace the explicit call for network_scan
	preference by generic bool check. In case of an error, apply a default that
	is sensible in this context.

2013-09-09  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	Add support for hosts_ordering scanner preferences.

	* src/attack.c (attack_network): Check for hosts_ordering preference,
	and shuffle hosts list when value is random. Fix coding style.

2013-09-07  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Removing remains of the scanner preference "slice_network_addresses"
	which was dropped with dropping the old host gatherer code.
	New methods to iterate over target hosts will be implemented
	based on the new code base. To not mix up with old prerefences,
	new names will be used for this.

	* src/preferences.c (openvassd_defaults): Removed
	"slice_network_addresses"
	(preferences_get_slice_network_addresses): Removed.

	* src/preferences.h: Removed proto accordingly.

2013-09-05  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	Replace hg module usage with base/openvas_hosts API.

	This also removes the scanner preference "host_expansion" which
	in a magical way extends the list of hosts to be scanned.
	It is strictly not the task of a scanner to extend the given scope
	of scan targets based on unforseeable circumstances. Such intelligence
	is to be solved via the vulnerability management, not via the
	vulnerability scanning.

	* src/attack.c: Remove hg/host_gatherer.h and hg/hg_utils.h includes.
	Include base/openvas_hosts.h
	(attack_start_args): Remove unused hg_globals element.
	(attack_init_hostinfos_vhosts, attack_init_hostinfos, attack_network):
	Remove hg module functions usage. Replace with openvas_hosts functions
	calls. Remove unused code.

	* src/openvassd.c: Remove unneeded include.

	* src/preferences.c: Remove hg/host_gatherer.h include and unused
	preferences_get_host_expansion function.

	* src/preferences.h: Remove function header.

2013-09-03  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	Clean code, remove unused function parameters.

	* src/hosts.c (hosts_stop_host, hosts_read_data): Remove unused globals
	parameter.
	(hosts_stop_all, hosts_read): Adjust function calls.

	* src/hosts.h: Adjust hosts_stop_host prototype.

	* src/ntp_11.c (ntp_11_parse_output): Adjust hosts_stop_host call.

2013-08-22  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	Clean code, remove unused function parameters.

	* src/attack.c (launch_plugin): Adjust plugin_set_running_state,
	save_kb_restore_backup, save_kb_backup and save_kb_exists function call
	accordingly.
	(attack_network): Adjust get_max_hosts_number and get_max_checks_number
	function calls.

	* src/hosts.c (forward, forward_all, host_rm): Remove unused globals
	parameter.

	* src/nasl_plugins.c (nasl_plugin_init): Remove unused prefs and nasl
	parameters.
	(nasl_thread): Adjust preferences_drop_privileges function call.

	* src/ntp_11.c (ntp_11_long_attack): Remove unused orig parameter.

	* src/oval_plugins.c (oval_plugin_init): Remove unused prefs and args
	parameters.

	* src/pluginlaunch.c (process_mgr_sighand_term)
	(update_running_processes, pluginlaunch_init, pluginlaunch_stop)
	(plugin_launch): Adjust plugin_set_running_state and
	get_max_checks_number function calls.

	* src/pluginload.c (init_plugin_classes): Remove unused preferences
	parameter.
	(plugins_reload_from_dir): Adjust init_plugin_classes function call.

	* src/pluginload.h (pl_class_s): Adjust pl_init function prototype.

	* src/pluginscheduler.c (plugin_set_running_state)
	(plugin_next_unrun_dependencie, plugins_scheduler_next): Remove unused
	parameters. Adjust function calls.

	* src/pluginscheduler.h: Adjust headers accordingly.

	* src/preferences.c (preferences_drop_privileges): Remove unused
	parameter.

	* src/preferences.h: Adjust headers accordingly.

	* src/save_kb.c (kb_dirname, kb_fname, save_kb_entry_present_already)
	(save_kb_rm_entry_value, save_kb_rm_entry, save_kb_close)
	(save_kb_exists, save_kb_restore_backup, save_kb_backup)
	(save_kb_load_kb): Remove unused parameters. Adjust functions calls.

	* src/save_kb.h: Adjust headers accordingly.

	* src/utils.c (get_max_hosts_number, get_max_checks_number): Remove
	unused parameters.

	* src/utils.h: Adjust headers accordingly.

2013-08-14  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* INSTALL: Updated reference system from Debian 6 to 7 and
	removed mentioning of GSD.

2013-07-25  Matthew Mundell <matthew.mundell@greenbone.net>

	* INSTALL: Reorder PKG_CONFIG_PATH export, in case another openvas
	installation is already in existing PKG_CONFIG_PATH.

2013-07-12  Michael Wiegand <michael.wiegand@greenbone.net>

	* tools/greenbone-nvt-sync: Simplify test and remove unnecessary stat
	call.

2013-07-01  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/oval_plugins.c: Replaced any occurance of post_note by post_error
	or post_alarm respectively.

2013-07-01  Michael Wiegand <michael.wiegand@greenbone.net>

	* src/attack.c (pattern_matches, fill_host_kb_ssh_credentials): Hide
	debug output behind NDEBUG ndefines so it does not show up when built
	with the "Release" build type.

2013-06-26  Michael Wiegand <michael.wiegand@greenbone.net>

	* CMakeLists.txt: Make SVN revision in version string available again
	for out-of-source build.

2013-06-21  Michael Wiegand <michael.wiegand@greenbone.net>

	Post release version bump.

	* CMakeLists.txt: Set version to 4.0+beta2.

2013-06-21  Michael Wiegand <michael.wiegand@greenbone.net>

	Preparing the openvas-scanner 4.0+beta1 release.
3073 3074 3075

	* CHANGES: Updated.

3076 3077 3078 3079 3080 3081 3082 3083 3084 3085 3086 3087 3088 3089 3090 3091 3092 3093 3094 3095 3096 3097 3098 3099 3100 3101 3102 3103 3104 3105 3106 3107 3108 3109 3110 3111 3112 3113 3114 3115 3116 3117 3118 3119 3120 3121 3122 3123 3124 3125 3126 3127 3128 3129 3130 3131 3132 3133 3134 3135 3136 3137 3138 3139 3140 3141 3142 3143 3144 3145 3146 3147 3148 3149 3150 3151 3152 3153 3154 3155 3156 3157 3158 3159 3160 3161 3162 3163 3164 3165 3166 3167 3168 3169 3170 3171 3172 3173 3174 3175 3176 3177 3178 3179 3180 3181 3182 3183 3184 3185 3186 3187 3188 3189 3190 3191 3192 3193 3194 3195 3196 3197 3198 3199 3200 3201 3202 3203 3204 3205 3206 3207 3208 3209 3210 3211 3212 3213 3214 3215 3216 3217 3218 3219 3220 3221 3222 3223 3224 3225 3226 3227 3228 3229 3230 3231 3232 3233 3234 3235 3236 3237 3238 3239 3240 3241 3242 3243 3244 3245 3246 3247 3248 3249 3250 3251 3252 3253 3254 3255 3256 3257 3258 3259 3260 3261 3262 3263 3264 3265 3266 3267 3268 3269 3270 3271 3272 3273 3274 3275 3276 3277 3278 3279 3280 3281 3282 3283 3284 3285 3286 3287 3288 3289 3290 3291 3292 3293 3294 3295 3296 3297 3298 3299 3300 3301 3302 3303 3304 3305 3306 3307 3308 3309 3310 3311 3312 3313 3314 3315 3316 3317 3318 3319 3320 3321 3322 3323 3324
2013-06-20  Michael Wiegand <michael.wiegand@greenbone.net>

	Adjust version identification string for protocol version switch.

	* src/openvassd.c (scanner_thread): Adjust version identifiers. Handle
	2.0 like 1.0 and 2.1 like 1.1.

	* src/comm.c (comm_init): Replace 1.x with 2.xbeta1.

2013-06-11  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/openvassd.c (check_client): New. Former check_user from users.c.

	* src/users.c, src/users.h: Removed.

	* src/CMakeLists.txt: Removed handling of users.c.

	* COPYING: Removed module users.

2013-06-11  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/ntp_11.c (ntp_11_rules): Renamed variable user_rules to
	client_rules which is more suitable.

2013-06-11  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Move users_add_rule() from users.c to rules.c as rules_add_client_rule()
	which is far more suitable.

	* src/users.c (users_add_rule): Removed.

	* src/users.h: Remove proto accordingly.

	* src/rules.c (rules_add_client_rule): New.

	* src/rules.h: Add proto accordingly.

	* src/ntp_11.c (ntp_11_rules): Rename function call accordingly.

2013-06-11  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/auth.c, src/auth.h: Removed. This layer is not required
	anymore.

	* src/attack.c, src/comm.c, src/ntp_11.c, src/openvassd.c,
	src/sighand.c src/utils.c: Remove include of auth.h.

	* src/CMakeLists.txt: Remove handling of module auth.c.

	* COPYING: Remove module auth.

2013-06-11  Matthew Mundell <matthew.mundell@greenbone.net>

	* src/openvassd.c (scanner_thread): Skip username/password part of OTP.
	Patch by Jan-Oliver Wagner.

2013-05-31  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/users.c (check_user): The file name is static, so
	don't use a variable anymore.

	* src/auth.c (auth_check_user): Ignore username and password,
	only dname is of interest. Therfore simplify code.

2013-05-31  Michael Wiegand <michael.wiegand@greenbone.net>

	Mark results of code analysis based on a number of valgrind runs.

	* src/pluginlaunch.c (process_internal_msg): Add TODO regarding
	possible memleak.

	* src/pluginscheduler.c (plugins_scheduler_init): Add TODO regarding
	possible memleak.

2013-05-30  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/users.c (check_user): Remove any handling of the user name,
	it isn't required anyway. Removed the parameter "user".

	* src/users.h: Removed now unused macro OPENVAS_MAX_USERNAME_LEN.
	Adjusted proto accordingly.

	* src/auth.c (auth_check_user): Adjust call of check_user.

2013-05-29  Michael Wiegand <michael.wiegand@greenbone.net>

	* tools/openvas-nvt-sync.in: Add support for determining if the
	installed feed is current and only sync feed when it is not. Note that
	this only works with rsync.

2013-05-28  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* doc/openvassd.8.in: Remove now-outdated parts about organization
	of users directory.

2013-05-28  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/hosts.c: Removed unnecessary include.

2013-05-28  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* INSTALL, CMakeLists.txt: Increase dependency to openvas-libraries
	from 6.0.0 to 7.0.0.

2013-05-28  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/attack.c (launch_plugin, attack_network): Remove handling of
	username which is not relevant anymore because we have only one user.
	(attack_user_name): Removed. It is not used anymore now.

	* src/openvassd.c (scanner_tread): Removed handling of username.
	(main): Don't read environment variable OPENVASUSER
	and use it to set the user in global arglist. This seems to make
	no sense at all here even for old times.

	* src/ntp_11.c (ntp_11_parse_input, ntp_11_rules):  Removed handling of username.

	* src/rules.c (rules_add): Don't have parameter username anymore because it
	is not used anyway.

	* src/rules.h: Adjust header accordingly.

	* src/auth.c (auth_check_user): Don't store the username anymore into
	the globals arglist.


2013-05-28  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/save_kb.c (save_kb_new, save_kb_load_kb, save_kb_write): Remove
	handling of username, because "kbs" is not user-specific anymore.

2013-05-23  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Removing "users" directory. Any remaining file-based data
	are now located directly in the OpenVAS state directory.

	* tools/openvas-mkcert-client.in: Changed paramters: -n does
	need anymore a user name. Internally "om" is used statically.
	No user directory is created or considered anymore. The file
	"dname" is now created directly in the state directory.

	* src/save_kb.c (kb_dirname): Moved location of
	OPENVAS_USERS_DIR/$user/kbs/ to OPENVAS_STATE_DIR/kbs/

	* src/users.c (user_home): Removed.
	(check_user): Moved location of OPENVAS_USERS_DIR/$user/auth/dname
	to OPENVAS_STATE_DIR/dname.

	* src/users.h: Removed proto accordingly.

	* CMakeLists.txt, src/CMakeLists.txt: Removed handling of
	OPENVAS_USERS_DIR.

2013-05-16  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/openvassd.c (scanner_thread): Remove useless rules
	variable.

2013-05-16  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/openvassd.c (scanner_thread): Permissions will never
	occur during authentication anymore because we do not have
	server-side user permissions. Therefore drop the code
	for setting the permissions.

2013-05-15  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/auth.c (auth_check_user): Use a simple success value instead
	of a faked rules object.

	* src/auth.h: Adapt proto accordingly.

	* src/openvassd.c (scanner_thread): Adjust call of auth_check_user
	accordingly.

	* src/users.h: Remove now unused BAD_LOGIN_ATTEMPT.

	* src/rules.h: Add includes to cover what is used here.

2013-05-15  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/users.c (check_user): Better naming for internal variable
	and swap logic of testing.

2013-05-15  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/users.c (check_user): Use a simple success value instead
	of a faked rules object.

	* src/users.h: Adapt proto accordingly.

	* src/auth.c (auth_check_user): Use new call of check_user.

2013-05-15  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/users.c (check_user): Remove code path to check password.
	Removed parameter "password".
	(MD5_DIGEST_LENGTH): Remove this makro as not needed anymore.

	* src/users.h: Adjust proto accordingly.

	* src/auth.c (auth_check_user): Call check_user without password
	and removed any password management. But still keep the protocol
	part for reading the Password.

2013-05-14  Michael Wiegand <michael.wiegand@greenbone.net>

	* src/openvassd.c (main): Free GOptionContext after use.

2013-05-14  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* CMakeLists.txt: Move the location of "openvassd.rules" from
	DATA (share/) directory to SYSCONF (etc/) directory.

	* doc/openvassd.rules: New. Sample and default file for
	openvassd.rules.

	* INSTALL: Added optinal items 1.1 and 1.2 about openvassd.conf
	and openvassd.rules.

2013-05-13  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/rules.c (rules_init): Don't call rules_new anymore. The result
	wasn't used anyway and creating the file when it is not there
	is wrong behaviour anyway. That file needs to be carefully
	configured by the administrator of the OpenVAS Scanner installation.
	(rules_new): Removed. It is now unused.

2013-05-13  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/users.c (check_user): Don't read the rules file of the user
	anymore and don't make it mandatory that at least an empty
	file "username/auth/rules" exists.
	Therefore now returns always a empty rules structure.
	(users_read_rules): Removed. This was used only by the code
	removed above.

2013-05-13  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* tools/openvas-mkcert-client.in: Removed creation of rules file
	during user creation. The user created with this script is only
	used for controling via OpenVAS Manager. The rules of actual
	users are now managed by OpenVAS Manager and stored in that
	database.

2013-05-07  Michael Wiegand <michael.wiegand@greenbone.net>

	* CMakeLists.txt: Remove creation of GnuPG homedir here since
	openvas-libraries already takes care of this.
3325 3326 3327

2013-04-11  Michael Wiegand <michael.wiegand@greenbone.net>

3328 3329 3330
	* INSTALL: Note increased GnuTLS dependency.

2013-04-05  Matthew Mundell <matthew.mundell@greenbone.net>
3331 3332 3333 3334 3335

	* src/log.c (log_init): Print fail messages about log file to stderr, so
	that tools wanting to parse "openvassd -s" output can separate out the
	the actual settings.

3336
2013-04-05  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>
3337

3338
	Remove scanner preference "silent_dependencies".
3339

3340 3341 3342
	This setting advised the scanner to hold back results of those NVTs
	that were not explicitely selected but were only executed because they
	appeared as dependencies of selected ones.
3343

3344 3345 3346 3347 3348 3349 3350 3351 3352 3353
	It is removed because it is actually task of the user or the
	controlling unit of the scanner (OpenVAS Manager) to filter whatever
	is of interest.
	The actual scan result should better remain complete inside the
	result databse. Dropping for example detection details makes a
	report less clear.
	Another aspect is, that use of this preference is too error-prone
	because users too easily combine a selection of NVT with this
	preference and accidently switch of results they actually would
	have expected (leading to False Negatives).
3354

3355 3356 3357
	So, for comprehensibility and consistency a scan result should
	always be complete. It is not the task of a scanner to drop any
	information.
3358

3359 3360 3361 3362
	This patch may require some adjustments or improved ways of handling
	results in the Scanner clients. This change will change default
	behaviour of scan configurations that were setting
	silent_dependencies to yes.
3363

3364 3365 3366 3367
	* src/pluginscheduler.c (enable_plugin_and_dependencies): Removed
	parameter "silent" and its handling.
	(plugins_scheduler_init): Call enable_plugin_and_dependencies without
	"silent" parameter. Also remove parameter "silent_dependencies".
3368

3369
	* src/pluginscheduler.h: Adjust proto accordingly.
3370

3371 3372
	* src/attack.c (attack_network): Adjust call of plugins_scheduler_init
	accordingly.
3373

3374 3375 3376 3377 3378 3379 3380 3381 3382 3383 3384 3385 3386 3387 3388 3389 3390 3391 3392 3393 3394 3395 3396 3397 3398 3399 3400 3401
	* src/preferences.c (openvassd_defaults): Removed "silent_dependencies".
	(preferences_silent_dependencies): Removed.
	(preferences_reset_cache): Removed handling of silent_dependencies.

	* src/preferences.h: Removed proto accordingly.

	* src/pluginlaunch.c (process_internal_msg): Don't consider LAUNCH_SILENT anymore.

	* src/pluginscheduler.h: Remove LAUNCH_SILENT.

2013-03-28  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/attack.c (attack_host): Adjust setproctitle call argument to start
	with "openvassd:".

	* src/openvassd.c (scanner_thread, main_loop): Adjust setproctitle call
	argument to start with "openvassd:".

	* src/nasl_plugins.c (nasl_thread): Adjust setproctitle call argument to
	start with "openvassd:".

	* src/oval_plugins.c (oval_thread): Adjust setproctitle call argument to
	start with "openvassd:".

2013-03-24  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/utils.c (version_check, is_symlink, check_symlink)
	(is_socket_connected, set_linger): Remove unused functions.
3402

3403
	* src/utils.h: Remove unused headers and declarations accordingly.
3404

3405
2013-03-21  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>
3406

3407 3408 3409 3410 3411 3412 3413 3414 3415 3416 3417 3418 3419 3420 3421 3422 3423 3424 3425 3426 3427 3428 3429 3430 3431 3432 3433 3434 3435 3436 3437 3438 3439 3440 3441 3442 3443 3444 3445 3446 3447 3448 3449 3450 3451 3452 3453 3454 3455 3456 3457 3458 3459 3460 3461 3462 3463 3464 3465 3466 3467 3468 3469 3470 3471 3472 3473 3474 3475 3476 3477 3478 3479 3480 3481 3482 3483 3484 3485 3486 3487 3488 3489 3490 3491 3492 3493 3494 3495 3496 3497 3498 3499 3500 3501 3502 3503 3504 3505 3506 3507
	Removing the shell scripts to add and to remove a user.
	This is the first part of moving the user management into
	OpenVAS Manager module. The Scanner should eventually only
	be accessed with certificates. For the time being,
	OpenVAS Administrator can manager traditional user accounts
	for the Scanner.

	* tools/openvas-adduser.in, tools/openvas-rmuser.in: Removed.

	* doc/openvas-adduser.8, doc/openvas-rmuser.8: Removed.

	* COPYING: Removed entries accordingly.

	* CMakeLists.txt: Removed handling of the two scritps.

	* doc/openvassd.8.in: Removed references to the documentation
	for the two scripts.

	* tools/openvas-mkcert-client.in: Removed reference to
	openvas-adduser documentation.

2013-03-20  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* po/openvas-scripts-de.po, po/Makefile, po/README, po/: Removed.
	The i18n support for scripts has not proven and the scripts
	will undergo a major change anyway.

2013-03-20  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* INSTALL: Removed notes on OpenVAS-Client which is not
	compatible anymore with the OTP changes.

2013-03-15  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* CMakeLists.txt: Increased dependency to gnutls from 2.2 to 2.8.

2013-03-14  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/comm.c (is_valid_feed_version): New function.
	(nvt_feed_version): Test fgets() return value correctly.
	(comm_send_nvt_info): Validate feed version before sending it.

2013-03-14  Hani Benhabiles  <hani.benhabiles@greenbone.net>

	* src/comm.c (nvt_feed_version): New function.
	(comm_send_nvt_info): Send nvt feed version instead of DUMMY value.

2013-03-06  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Reverting parts of the previous patch because under certain
	conditions (network_scan_status == busy) the kb_saving
	is still needed.

	* src/save_kb.c: Removed unneeded include.
	(save_kb): Re-added a simplified version.

	* src/save_kb.h: Re-added proto accordingly.

	* src/piic.c (kb_parse): Re-added handling for case "save_kb".

	* src/attack.c (attack_network, launch_plugin, init_host_kb):
	Re-adding, partly simplified, handling for case "save_kb", in
	other words for network scan situations.

2013-03-05  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Third part of removing kb-saving feature. This completes
	the removal of the user-driven kb saving.

	* src/preferences.c (openvassd_defaults): Removed "kb_max_age".

	* src/save_kb.c (save_kb_max_age): Removed.
	(save_kb_load_kb): Apply the default 864000 for max_age
	directly (the old default, 10 days).

	* src/save_kb.h: Removed proto accordingly.

2013-03-05  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Second part of removing kb-saving feature.
	This removes the scanner configs for advising to save kb.
	Thus no kb files are stored anymore under users/$user/kbs/
	during a non-network scan. Network scans will still save
	KBs.

	* src/preferences.c (openvassd_defaults): Removed
	"save_knowledge_base", "kb_restore",
	"only_test_hosts_whose_kb_we_dont_have" and
	"only_test_hosts_whose_kb_we_have".

	* src/save_kb.c (save_kb, save_kb_pref_untested_hosts_only,
	save_kb_pref_tested_hosts_only, save_kb_pref_restore): Removed.

	* src/save_kb.h: Removed protos accordingly.

	* src/attack.c (attack_network, launch_plugin, init_host_kb):
	Removed handling for case "save_kb".

	* src/piic.c (kb_parse): Removed handling for case "save_kb".

2013-03-05  Hani Benhabiles  <hani.benhabiles@greenbone.net>
3508 3509 3510 3511

	* src/comm.c (plugin_is_newstyle): Remove function. Now part of
	plugutils.c in libraries.

3512
2013-04-05  Matthew Mundell <matthew.mundell@greenbone.net>
3513 3514 3515 3516

	* src/nasl_plugins.c (plugin_is_newstyle): Check tag in case it is NULL.
	Also move &&'s to front of line for consistency.

3517 3518 3519 3520 3521 3522 3523 3524 3525 3526 3527 3528 3529 3530
2013-03-04  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	First part of removing kb-saving feature.
	This removes the scanner configs for selecting which NVT categories
	should be replayed. Now all will be replayed regardless of the
	category. However, this is temporary.

	* src/preferences.c (openvassd_defaults): Removed
	"kb_dont_replay_scanners", "kb_dont_replay_denials",
	"kb_dont_replay_info_gathering", "kb_dont_replay_attacks".

	* src/save_kb.c (save_kb_replay_check): Removed.

	* src/save_kb.h: Removed proto accordingly.
3531

3532 3533 3534 3535
	* src/attack.c (launch_plugin): In case of using save_kb,
	any NVT will be replayed now.

2013-03-03  Hani Benhabiles  <hani.benhabiles@greenbone.net>
3536 3537 3538 3539 3540

	* src/comm.c (send_plug_info): Send NOSUMMARY instead of whole summary
	when script tag summary is present.
	(plug_is_newstyle): Rename to plugin_is_newstyle.

3541
2013-03-02  Hani Benhabiles  <hani.benhabiles@greenbone.net>
3542 3543 3544 3545 3546 3547 3548

	* src/comm.c (plug_is_newstyle): New function to check if plugin has all
	newly added tags (summary, affected, insight, detection, impact,
	solution).
	(send_plug_info): Send NODESC instead of whole description when plugin
	has all new style tags.

3549 3550 3551 3552 3553 3554 3555
2013-03-01  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	* src/openvassd.c (main): Don't initialize services
	(openvas_init_svc) anymore. It is not needed anymore because removed
	from openvas-libraries (see there for rationale).

2013-03-01  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>
3556

3557 3558 3559 3560 3561 3562 3563 3564 3565 3566 3567 3568 3569
	The port_range "default" is not allowed anymore. It is now
	mandatory that the client sends an explicit one.
	Ratonale: "default" is an intransparent behaviour from user
	perspective.

	* src/preferences.c (openvassd_option openvassd_defaults): Removed
	port_range from the default settings.

	* src/attack.c (attack_network): Check port_range directly as found in
	preferences. Don't assume "1-15000" in absense of port_range and don't
	consider port_range == "-1" as something valid.

2013-03-01  Timo Pollmeier <timo.pollmeier@greenbone.net>
3570 3571 3572 3573

	* tools/greenbone-nvt-sync (RSYNC_DELETE): Remove quotes causing
	exclude of private directory to be ignored.

3574
2013-02-28  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>
3575

3576 3577 3578 3579
	* src/comm.c (comm_send_nvti_info): Renamed OTP command
	"PLUGINS_MD5" to "NVT_INFO" which is more apropriate as
	no MD5 is handled at all anymore. The parameter is kept
	as static text "DUMMY".
3580

3581
2013-02-28  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>
3582

3583
	* src/comm.c (comm_send_md5_plugins): Renamed to comm_send_nvt_info.
3584

3585 3586 3587 3588 3589 3590 3591 3592 3593 3594 3595 3596 3597 3598 3599 3600 3601 3602 3603 3604 3605 3606 3607 3608 3609 3610 3611 3612 3613 3614 3615 3616 3617 3618 3619 3620
	* src/comm.h: Updated proto accordingly.

	* src/openvassd.c (scanner_thread): Renamed call accordingly.

2013-02-28  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Remove handling of MD5 for NVTs from OTP. Those checksums have
	no meaning to the client because the client can not verify
	them as it has no access to the actual NVT files.
	So, the MD5 could serve as version/change indicator at best, but
	that is already redundant with the revisioning in the tags.
	The MD5 checksums could be used to determine which plugins
	are changed since last contact (provided the client stores them)
	in order to use PLUGIN_INFO for getting the changed ones
	instead of downloading all. In practice it has shown that
	it is simpler to just download all always.

	This removes the command SEND_PLUGINS_MD5 from OTP.

	* src/comm.c (comm_send_md5_plugins): Remove md5 computations
	and rather just send "DUMMY" as md5 value for command PLUGINS_MD5
	for the time being. Removed answering on SEND_PLUGINS_MD5.

	* src/plugs_hash.c, src/plugs_hash.h: Removed.

	* COPYING: Removed module plugs_hash.

	* src/CMakeLists.txt: Removed handling of plugs_hash.

	* src/nasl_plugins.c: Removed include of plugs_hash.h,

2013-02-27  Timo Pollmeier <timo.pollmeier@greenbone.net>

	* tools/greenbone-nvt-sync: Update version number.

2013-02-27  Timo Pollmeier <timo.pollmeier@greenbone.net>
3621 3622 3623 3624

	* tools/greenbone-nvt-sync: Add PRIVATE_SUBDIR and private directory
	functionality to RSYNC_DELETE.

3625 3626 3627 3628 3629 3630
2013-02-27  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>

	Post branch version bump.

	* CMakeLists.txt: Set to version to 4.0.0 and beta status.

3631 3632 3633 3634 3635 3636 3637 3638 3639 3640 3641 3642 3643 3644 3645 3646 3647 3648 3649 3650 3651 3652 3653 3654 3655 3656 3657 3658 3659 3660 3661 3662 3663 3664 3665 3666 3667 3668 3669 3670 3671 3672 3673 3674 3675 3676 3677 3678 3679 3680 3681 3682 3683 3684 3685 3686 3687 3688 3689 3690 3691 3692 3693 3694 3695 3696 3697 3698 3699 3700 3701 3702 3703 3704 3705 3706 3707 3708 3709 3710 3711 3712 3713 3714 3715 3716 3717 3718 3719 3720 3721 3722 3723 3724 3725 3726 3727 3728 3729 3730 3731 3732 3733 3734 3735 3736 3737 3738 3739 3740 3741 3742 3743 3744 3745 3746 3747 3748 3749 3750 3751 3752 3753 3754 3755 3756 3757 3758 3759 3760 3761 3762 3763 3764 3765 3766 3767 3768 3769 3770 3771 3772 3773 3774 3775 3776 3777 3778 3779 3780 3781 3782 3783 3784 3785 3786 3787 3788 3789 3790 3791 3792 3793 3794 3795 3796 3797 3798 3799 3800 3801 3802 3803 3804 3805 3806 3807 3808 3809 3810 3811 3812 3813 3814 3815 3816 3817 3818 3819 3820 3821 3822 3823 3824 3825 3826 3827 3828 3829 3830 3831 3832 3833 3834 3835 3836 3837 3838 3839 3840 3841 3842 3843 3844 3845 3846 3847 3848 3849 3850 3851 3852 3853 3854 3855 3856 3857 3858 3859 3860 3861 3862 3863 3864 3865 3866 3867 3868 3869 3870 3871 3872 3873 3874 3875 3876 3877 3878 3879 3880 3881 3882 3883 3884 3885 3886 3887 3888 3889 3890 3891 3892 3893 3894 3895 3896 3897 3898 3899 3900 3901 3902 3903 3904 3905 3906 3907 3908 3909 3910 3911 3912 3913 3914 3915 3916 3917 3918 3919 3920 3921 3922 3923 3924 3925 3926 3927 3928 3929 3930 3931 3932 3933 3934 3935 3936 3937 3938 3939 3940 3941 3942 3943 3944 3945 3946 3947 3948 3949 3950 3951 3952 3953 3954