GitLab's annual major release is around the corner. Along with a lot of new and exciting features, there will be a few breaking changes. Learn more here.

CONTRIBUTING.md 2.6 KB
Newer Older
1 2
# Table of Contents
---
Sophie Brun's avatar
Sophie Brun committed
3

4 5 6 7 8 9
 * [Introduction](#intro)
 * [Code Repository](#repo)
 * [Bug Reports](#bug)
 * [Pull Requests](#pr)
 * [issues.nmap.org redirector](#issues)
 * [The HACKING file](#hacking)
10

11
## <a name="intro"></a>Introduction
12

13
This file serves as a supplement to the [HACKING file](HACKING). It contains information specifically about Nmap's use of Github and how contributors can use Github services to participate in Nmap development.
14

15
## <a name="repo"></a>Code Repository
16

17
The authoritative code repository is still the Subversion repository at [https://svn.nmap.org/nmap](https://svn.nmap.org/nmap). The Github repository is synchronized once per hour. All commits are made directly to Subversion, so Github is a read-only mirror.
18

19
## <a name="bug"></a>Bug Reports
20

21 22 23 24 25
Nmap uses Github Issues to keep track of bug reports. Please be sure to include the version of Nmap that you are using, steps to reproduce the bug, and a description of what you expect to be the correct behavior.

## <a name="pr"></a>Pull Requests

Nmap welcomes your code contribution in the form of a Github Pull Request. Since the Github repository is currently read-only, we cannot merge directly from the PR. Instead, we will convert your PR into a patch and apply it to the Subversion repository. We will be sure to properly credit you in the CHANGELOG file, and the commit message will reference the PR number.
26 27

Because not all Nmap committers use Github daily, it is helpful to send a
28
notification email to [dev@nmap.org](mailto:dev@nmap.org) referencing the PR and including a short
29 30 31 32 33 34 35 36 37 38
description of the functionality of the patch.

Using pull requests has several advantages over emailed patches:

1. It allows Travis CI build tests to run and check for code issues.

2. Github's interface makes it easy to have a threaded discussion of code
changes.

3. Referencing contributions by PR number is more convenient than tracking by
39
[seclists.org](http://seclists.org/) mail archive URL, especially when the discussion spans more than
40 41
one quarter year.

42
## <a name="issues"></a>issues.nmap.org redirector
43

44
For convenience, you may use [issues.nmap.org](http://issues.nmap.org) to redirect to issues (bug reports and pull requests) by number (e.g. [http://issues.nmap.org/34](http://issues.nmap.org/34)) or to link to the new-issue page: [http://issues.nmap.org/new](http://issues.nmap.org/new).
45

46
## <a name="hacking"></a>The HACKING file
47 48

General information about hacking Nmap and engaging with our community of
49
developers and users can be found in the [HACKING file](HACKING). It describes how to get started, licensing, style guidance, and how to use the dev mailing list.