Otherwise we get plenty of error messages:

DEBUG build/debian-cd stderr: Use of uninitialized value
$ENV{"NONFREE_COMPONENTS"} in split at
<<DIR>>/simple-cdd/debian-cd/tools/which_deb line 23.

Installation from the weekly installer image fails (2022-W40 and
2022-W41). From syslog:

    in-target: The following packages have unmet dependencies:
    in-target:  king-phisher : Depends: python3-matplotlib (>= 1.4.3) but it is not installable
    in-target:                 Recommends: python3-mpltoolkits.basemap (>= 1.0.7) but it is not installable

From a manual install, using the iso packages set in sources.list:

    # apt install king-phisher
    [...]
    The following packages have unmet dependencies:
     python3-fonttools : Depends: python3-unicodedata2 (>= 14.0.0) but it is not installable or
                                  python3-all (>= 3.11.0) but 3.10.6-1 is to be installed
    E: Unable to correct problems, you have held broken packages.

Dependency chain is as follow:

    king-phisher
    +-- python3-matplotlib
      +-- python3-fonttools
        +-- python3-unicodedata2 (>= 14.0.0) | python3-all (>= 3.11.0)

In the set of packages that are available in the iso, we don't have
python3-unicodedata2 , however we have python3-all , BUT it's at version
3.10.6-1 ... So nothing can satisfy the dependency.

For now, let's manually force python3-unicodedata2 in the iso, as a
workaround.

Revert "Work-around non-co-installability of nvidia-tesla-kernel-support and nvidia-tesla-470-kernel-support"

This reverts commit 8bd6060b.

Actually --firmware-binary is also affected by the same issue and there
I'd rather not remove the logic to include the firmwares in the
installer. So instead I went for a temporary solution where I excluded
nvidia-graphics-drivers-tesla-470 from Kali entirely.

Work-around non-co-installability of nvidia-tesla-kernel-support and nvidia-tesla-470-kernel-support

Issue has been reported to Debian in https://bugs.debian.org/1018873

Ths first line ('... boolean true') is needed to trick debian-cd into
believing that the type of the question is a boolean.

Otherwise debian-cd will think that the question doesn't exist, probably
because it doesn't know the type, probably because there's no type to
start with (this is an error message, not a question).

FTR, without the first line, it fails with:

  2022-08-04 10:05:37,846 DEBUG Checking configuration...
  error: Cannot find a question for encfs/security-information
  2022-08-04 10:05:38,016 ERROR preseed file invalid:
    <<LBDIR>>/simple-cdd/profiles/kali.preseed

Add usr-is-merged to the list of offline packages

See merge request !27

memtest86 is no longer in Debian testing / Kali Rolling

The function get_user_list returns a list of users on stdout, so
obviously it can't use stdout to also display messages. Use stderr
instead.

Note that we could also silently skip if we find a directory in /home
that is not a user. Does it happen in practice?

Add the kali user to the vboxsf group, if it exists

See merge request !25

The vboxsf group is created by the postinst script of the package
virtualbox-guest-utils. The kali user needs to be part of this group
in order to access VirtualBox's shared folders.

This change does just that. It's effective for all the Live images
(where VirtualBox guest additions are installed unconditionnally),
and for the systems installed by the Installer image where VirtualBox
was detected (and therefore VirtualBox guest additions were installed).

Ref: <https://bugs.kali.org/view.php?id=7643>

Up to now, it was fine to use a command such as:

    usermod -a -G group1,group2,... kali

However a limitation is that all the groups that are given to the option
-G must exist. If that's not the case, usermod fails (return code: 6)
without doing anything, and the user is not added to any group.

So with this commit, we prepare the code to support optional groups,
that might or might not exist. If ever a group does not exist, it's
skipped silently.

Changes:
- order groups alphabetically
- use the same comment "Ensure those groups exist" consistently in the 2
  scripts, and also drop the comment regarding a "generically named"
  function.
- adds "|| true" to the usermod command in kali-user-setup (only for
  consistency, the script is not run with "set -e" anyway).

After those changes, the two functions "configure_usergroups()" are very
similar, and it's very easy to spot the differences between both.

This was introduced in 5989ec37, and
probably that was not the intention.

Adding root to groups doesn't break anything, but I don't think it makes
any sense either.

In a real situation, those packages are installed by the chain of
depends/recommends orca -> speech-dispatcher ->
(speech-dispatcher-espeak-ng, sound-icons).

However that chain is broken, in all likelyhood by debian-cd dependency
handling, cf. #601203.

This mention should ensure these packages are present in the generated
ISO.

Fixes: #46

* Override *.cfg instead of using hooks
* Harmonize the menu entries labels (same text, add architectures...)

Update script to copy grub theme to installer iso

See merge request !22

In a real situation, the package is installed by a chain of recommends
pipewire-bin -> wireplumber -> pipewire-pulse and that chain is broken
either by debian-cd's dependency handling or by simple-cdd's logic to
build its local mirror. But this mention should ensure its presence in
the generated ISO.

This reverts commit d1ad9e1e.

The empty directory `local_packages` was there for a reason.
`simple-cdd` gives a warning when this directory doesn't exist:

  WARNING local package source /home/kali/live-build-config/simple-cdd/local_packages is neither a file nor a directory

So re-instate this empty dir to keep the logs clean.

I assume that `variant-minimal` was also there for a good reason.