1. 10 May, 2015 3 commits
    • dmarc-noreply@freelists.org's avatar
      tests: fix regexp in ps_sched_batch.exp to match in first line · af6e264b
      dmarc-noreply@freelists.org authored
      The current regexp checks for a \s+ in the beginning, however that will
      only match if there is a \n in the `ps` output before test-schedbatch,
      but that will not happen if test-schedbatch is the first process in the
      list, which happens if the PID of test-schedbatch is low enough to bring
      it up in the sorted list.
      
      Fix it by enabling newline-sensitive matching with (?n) which then
      allows using ^ and $ anchors in the regexp (including an optional \r
      introduced by expect.) Matching the end of line also improves checking
      that the last field matches 18 exactly and not something like 181, etc.
      
      Tested that `make check` does not break and also fixed the flakiness
      seen in an environment with few processes running under the test user
      which made the issue more frequent.
      Signed-off-by: Filipe Brandenburger's avatarFilipe Brandenburger <filbranden@google.com>
      Signed-off-by: Craig Small's avatarCraig Small <csmall@enc.com.au>
      af6e264b
    • dmarc-noreply@freelists.org's avatar
      tests: do not mark ps_sched_batch.exp as untested · e981f2bb
      dmarc-noreply@freelists.org authored
      Right now the test case is both testing it (expect_pass "$test") and
      marking it as untested (untested "$test"), it should do either one or
      the other, so stop marking it as untested.
      
      Before this change, these lines appear in testsuite/ps.log or the output
      of `make check RUNTESTFLAGS="--all"`:
      
        PASS: ps SCHED_BATCH scheduler
        UNTESTED: ps SCHED_BATCH scheduler
      
      Note that the second line is confusing, it's implying that the test is
      untested, right after having tested it and indicated it passes.
      
      After this change, only the first line will appear.
      
      Tested that both `make check` and `make distcheck` continue working with
      this commit.
      Signed-off-by: Filipe Brandenburger's avatarFilipe Brandenburger <filbranden@google.com>
      Signed-off-by: Craig Small's avatarCraig Small <csmall@enc.com.au>
      e981f2bb
    • Craig Small's avatar
      revert ps_sched checks for following commits · e0256d1f
      Craig Small authored
      e0256d1f
  2. 09 May, 2015 1 commit
    • Craig Small's avatar
      Fix some sched and tty tests · 4050148a
      Craig Small authored
      The ps sched test has been disabled. There are too many
      odd build farms this fails in strange ways.
      
      Other odd build farms have no tty and so some tests check
      for no tty and skip if not found.
      4050148a
  3. 09 Jan, 2012 1 commit