Commit 5f3c071c authored by Qualys Security Advisory's avatar Qualys Security Advisory Committed by Craig Small

slabtop: Reset slab_list if get_slabinfo() fails.

Otherwise "the state of 'list' and 'stats' are undefined" (as per
get_slabinfo()'s documentation) and free_slabinfo() crashes (a
use-after-free).
parent 2fc42db3
......@@ -364,6 +364,7 @@ int main(int argc, char *argv[])
memset(&stats, 0, sizeof(struct slab_stat));
if (get_slabinfo(&slab_list, &stats)) {
slab_list = NULL;
retval = EXIT_FAILURE;
break;
}
......@@ -436,7 +437,8 @@ int main(int argc, char *argv[])
if (is_tty)
tcsetattr(STDIN_FILENO, TCSAFLUSH, &saved_tty);
free_slabinfo(slab_list);
if (slab_list)
free_slabinfo(slab_list);
if (!run_once)
endwin();
return retval;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment