This project is mirrored from https://*****@gitlab.com/koha-community/Koha.git. The repository failed to update .
Repository mirroring has been paused due to too many failed attempts, and can be resumed by a project maintainer.
Last successful update .
  1. 26 Feb, 2019 1 commit
  2. 26 Nov, 2018 2 commits
  3. 26 Oct, 2018 1 commit
  4. 24 Aug, 2018 2 commits
  5. 05 Feb, 2018 1 commit
  6. 27 Oct, 2017 1 commit
  7. 25 Aug, 2017 1 commit
  8. 14 Jul, 2017 1 commit
  9. 10 Jul, 2017 2 commits
  10. 05 Jul, 2017 3 commits
    • Marcel de Rooy's avatar
      Bug 17843: [QA Follow-up] Some polishing · ca0bde1e
      Marcel de Rooy authored
      Resolve warning from members/summary-print.pl:
          "my" variable $itemtype masks earlier declaration in same scope
      
      Test if find returns a Koha object in GetDescription.
      Test if find returns a Koha object too in shelves.pl. While testing, I had
      a crash on a biblioitem with itemtype NULL (bad record, but these things
      tend to happen somehow.)
      Can't call method "imageurl" on an undefined value at virtualshelves/shelves.pl line 253.
      Same for opac/opac-shelves.pl.
      
      Note: Did not add tests everywhere but generally, I have the impression that
      we do not sufficiently test on the results of Koha::Object->find. Mostly we
      just assume that it will find a record. Several reports include fixes to
      resolve that wrong assumption.
      Signed-off-by: default avatarMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
      ca0bde1e
    • joubu's avatar
      Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes · 091d6c51
      joubu authored
      The C4::Koha::getitemtypeinfo subroutine did the almost same job as
      GetItemTypes. On top of that it returned the imageurl value processed by
      C4::Koha::getitemtypeimagelocation.
      This value is only used from the 2 [opac-]shelves.pl scripts. Then it's
      better not retrieve it only when we need it.
      
      Test plan:
      Play with the different scripts touched by this patch and focus on item
      types. The same description as prior to this patch must be displayed.
      Note that sometimes it is not the translated description which is
      displayed, but that should be fixed on another bug report. Indeed we do
      not expect this patch to change any behaviors.
      Signed-off-by: default avatarLari Taskula <lari.taskula@jns.fi>
      Signed-off-by: default avatarMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
      091d6c51
    • Marcel de Rooy's avatar
      Bug 18228: Implement the new columns in code · a58aca05
      Marcel de Rooy authored
      The two new columns as mentioned in the commit message of the table
      revision must be used in the codebase now.
      
      Highlighting some changes in Koha::VirtualShel[f|ves]:
      [1] Additional methods is_public and is_private.
      [2] Method add_biblio did not check permissions. Does now. No impact on the
          interface, but one call in the unit test was affected.
      [3] Method remove_biblios is signficantly simplified. Removed a FIXME.
      [4] Method can_biblios_be_removed now redirects to can_biblios_be_added.
          A followup report may deal with unifying those routines.
      [5] Condition in get_some_shelves changed.
      [6] The reference to allow_add in get_shelves_containing_record can simply
          be removed.
      
      opac-shelves.pl and shelves.pl now pass the default setting of Owner only
      to the template.
      Templates shelves.tt and opac-shelves.tt now include the new permission
      field with three choices as mentioned in the table revision patch.
      
      opac-addbybiblionumber.pl and addbybiblionumber now need a check on
      allow_change_from_owner; search conditions slightly adjusted to the new
      permission scheme.
      
      Test plan:
      When we refer to visibility in the test plan, please check the Add to-combo
      on opac search results and staff results. And check opac-addbybiblionumber
      by clicking Save to Lists from opac results.
      The step 'Check delete' means: open the list in opac and check if you see
      the Delete button below the entries (only check, do not delete).
      
      [ 1] Create private list I01 (perm=Owner)
      [ 2] Check visibility: Seen.
      [ 3] Add a book. (Change by owner should be allowed.)
      [ 4] Check delete: Yes.
      [ 5] Edit list I01, set perm=Nobody
      [ 6] Check visibility: Not seen.
      [ 7] Check delete: No.
      [ 8] Share list I01 with another patron.
      [ 9] Check visibility for the other patron: Not seen.
      [10] Check delete for the other patron: No.
      [11] Change permission of list I01 to Anyone (by owner).
      [12] Check visibility for the other patron: Seen.
      [13] Let other patron add a book (change is allowed).
      [14] Let owner delete the same book again (change allowed).
      
      [15] Create public list U01 (perm=Owner)
      [16] Check visibility: Seen.
      [17] Add a book. (Change by owner should be allowed.)
      [18] Login as other user. Check visibility: Not seen. Check delete: No.
      [19] Change permission of U01 to Nobody (by owner)
      [20] As owner: Check visibility: Not seen. Check delete: No.
      [21] As other user: Check visibility: Not seen. Check delete: No.
      [22] Create public list U02 (perm=Anyone)
      [23] Add a book by owner.
      [24] Delete the same book by other user. Add another book.
      Signed-off-by: default avatarMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
      Signed-off-by: default avatarJesse Maseto <jesse@bywatersolutions.com>
      Signed-off-by: Wm. Nick Clemens's avatarNick Clemens <nick@bywatersolutions.com>
      a58aca05
  11. 05 Jun, 2017 1 commit
  12. 03 Mar, 2017 3 commits
  13. 14 Feb, 2017 1 commit
  14. 30 Jan, 2017 1 commit
  15. 11 Oct, 2016 1 commit
  16. 25 Sep, 2016 2 commits
  17. 22 Jul, 2016 3 commits
  18. 24 Jun, 2016 3 commits
    • Tomas Cohen Arazi's avatar
      Bug 15485: (QA followup) Simplify logic and use *ResultsDisplay value during upgrade · 609f5371
      Tomas Cohen Arazi authored
      This patch makes the new sysprefs work as the previously defined. Instead of falling back
      to what *ResultsDisplay is set, it now has its own 'default' (that still defaults to the
      *Results*.xslt).
      
      The default values are set to 'default' as the rest of XSLT-related sysprefs, and the upgrade
      picks whatever is set in OPACXSLTResultsDisplay and XSLTResultsDisplay so current behaviour
      is preserved.
      Signed-off-by: default avatarTomas Cohen Arazi <tomascohen@theke.io>
      Signed-off-by: default avatarHector Castro <hector.hecaxmmx@gmail.com>
      New XSLTs for Lists work as advertised
      Signed-off-by: default avatarKyle M Hall <kyle@bywatersolutions.com>
      609f5371
    • Tomas Cohen Arazi's avatar
      Bug 15485: (QA followup) Fix behaviour and default values · add61ef6
      Tomas Cohen Arazi authored
      Jonathan noticed the current behaviour is that the lists rendering
      falls back to the XSLTResults, and if not defined (i.e. != 'default' and
      != some_path) it falls back to a legacy display (non-XSLT).
      
      The patchset changed this behaviour because 'default' is not a valid value
      for the lists. So it should fallback to the current behaivour (i.e. Results
      XSLT configuration) if not defined. This patch fixes this by adding
       || C4::Context->preference('XSLTResultsDisplay')
      (and the OPAC counterpart).
      
      It also fixes minor glitches on the update message (oops) and bad default value
      in sysprefs.sql  for 'XSLTListsDisplay'.
      
      Thanks Jonathan!
      Signed-off-by: default avatarHector Castro <hector.hecaxmmx@gmail.com>
      Signed-off-by: default avatarKyle M Hall <kyle@bywatersolutions.com>
      add61ef6
    • Tomas Cohen Arazi's avatar
      Bug 15485: Use lists-specific XSLT sysprefs · 04143f6a
      Tomas Cohen Arazi authored
      This patch makes the shelves.pl (staff) and opac-shelves.pl scripts
      use the new sysprefs for specifying custom XSLTs for lists display.
      
      XSLT.pm is patched so it defaults to the corresponding *Results.xsl
      files if none is specified.
      
      To test:
      - Create a list
      - Open the list in the staff interface
      - On a new tab, open the list in the OPAC.
      - Apply this patches
      === default behaviour
      - Open the list (both opac and staff) on new tabs
      => SUCCESS: They look exactly the same (hint: the syspref is set to ''
         so it should fallback to using the one we were using.
      === using the new functionality
      - Create custom XSLTs for lists, for example:
        $ cd /home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/xslt
        $ cp MARC21slim2OPACResults.xsl MARC21slim2OPACLists.xsl
      - Edit your sysprefs, setting OPACXSLTListsDisplay to:
        /home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/{langcode}/xslt/MARC21slim2OPACLists.xsl
      - Reload the OPAC list view
      => SUCCESS: Looks exactly as before
      - Make some minor tweak (for example in line 423 replace
        <xsl:text> </xsl:text>
      for
        <xsl:text> BLAH </xsl:text>
      - Reload the list
      => SUCCESS: BLAH shows in several places on the title.
      - Repeat for the staff interface
      - Sign off :-D
      
      So we can now set custom XSLTs for lists.
      
      Sponsored-by: Carnegie Stout Library
      Signed-off-by: Wm. Nick Clemens's avatarNick Clemens <nick@bywatersolutions.com>
      Signed-off-by: default avatarDeb Stephenson <DStephen@dubuque.lib.ia.us>
      Signed-off-by: joubu's avatarJonathan Druart <jonathan.druart@bugs.koha-community.org>
      Signed-off-by: default avatarKyle M Hall <kyle@bywatersolutions.com>
      04143f6a
  19. 23 May, 2016 2 commits
  20. 04 May, 2016 1 commit
  21. 26 Apr, 2016 3 commits
  22. 07 Mar, 2016 1 commit
  23. 22 Feb, 2016 1 commit
    • joubu's avatar
      Bug 15810: Make sure the CGI->param is not called in a list context when creating private shelves · d6329e4f
      joubu authored
      This patch fixes the following bug:
      If OpacAllowPublicListCreation is set to "not allow", the creation of a
      private list raises an error at the OPAC.
      
      CGI->param is called in a list context and some parameters are not
      filled from the template if the pref is set to "not allow".
      To make sure we don't have a "Odd number of elements in anonymous hash",
      we force the context to scalar.
      
      Test plan:
      1/ Set OpacAllowPublicListCreation to "not allow"
      2/ Create private and public lists at the OPAC and the intranet
      => Everything should work fine with this patch applied
      Signed-off-by: default avatarKatrin Fischer <katrin.fischer@bsz-bw.de>
      Signed-off-by: default avatarKyle M Hall <kyle@bywatersolutions.com>
      
      Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com 
      d6329e4f
  24. 11 Feb, 2016 1 commit
  25. 16 Nov, 2015 1 commit