Skip to content
  • Tomas Cohen Arazi's avatar
    Bug 28772: Make secret validation use the new method · 3816a57a
    Tomas Cohen Arazi authored and joubu's avatar joubu committed
    
    
    This patch makes the Koha::OAuth library use the new validation method
    
    To test:
    1. In master, enable RESTOAuth2ClientCredentials and have your
       superlibrarian patron a client_id/secret pair generated
    2. Use Postman to gain an access token with the client_id/secret pair
    => SUCCESS: This works in Koha
    3. Use the access token to GET /api/v1/patrons
    => SUCCESS: It works
    4. Apply this patchset up to the regression tests
    5. Run:
       $ updatedatabase
       $ koha-plack --restart kohadev
    => SUCCESS: All good
    6. Repeat 2
    => FAIL: You get an error trying to acquire an access token. Boo
    7. Run:
       $ kshell
      k$ prove t/db_dependent/api/v1/oauth.t
    => FAIL: Tests fail!
    8. Apply this patch
    9. Run:
       $ koha-plack --restart kohadev
       $ kshell
      k$ prove t/db_dependent/api/v1/oauth.t
    => SUCCESS: Tests pass!
    10. Repeat 2
    => SUCCESS: Your original client_id/secret pair works!
    11. Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi's avatarTomas Cohen Arazi <tomascohen@theke.io>
    
    Signed-off-by: default avatarMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
    
    Signed-off-by: default avatarJonathan Druart <jonathan.druart@bugs.koha-community.org>
    3816a57a