Skip to content
This project is mirrored from https://*****@gitlab.com/koha-community/Koha.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer or owner.
Last successful update .
  1. Feb 11, 2020
    • joubu's avatar
      Bug 24162: Add quantity column to the late orders page · 6ca3b42b
      joubu authored 
      This patch add a new column "quantity" to the late orders page

Test plan:
1. Create some orders, close the basket
2. Go to the "Late orders" page
=> You should see a new column "quantity" that contains the number of
items of the order

Sponsored-by: Cork Institute of Technology
      6ca3b42b
    • joubu's avatar
      Bug 24163: Add the csv into the DB - as an example · f3ace90c
      joubu authored 
      Sponsored-by: Institute of Technology Tralee
      f3ace90c
    • joubu's avatar
      Bug 24163: Allow to define CSV profile for late orders export · d730927d
      joubu authored 
      This new enhancement adds the ability to create a CSV profile for the late
orders export.
Prior to this, the CSV profile was hardcoded in a template and not
editable (unless you modify the .tt file of course).

The main difficulty of the request was to make the multiple claims dates
accessible from the CSV profile. So far we only accept columns from the
database. However we would like to use the Koha::Acquisition::Order
object to make things easier (it had a ->claims method to access the
different claims).
To acchieve this, we are going to accept the TT syntax for that CSV profile.
It means that only CSV profiles created for 'late_orders' will have the
capability to use the TT syntax (can be extended later of course if
needed).
The alternative was to use specific placeholders, like %claims_count%,
%claimed_date%, but it sounded more powerful and flexible to allow the
TT syntax instead.

Note that the former export (template based) still exists and is the
default option.

Test plan:
0. Apply the patches and execute the update database entry
1. Create some orders, close the basket
2. Claim some of the orders
3. Note the new button at the bottom of the table that have several
entries.
=> The first entry will generate a CSV file using the previous method
=> The second entry will generate it using the new CSV profile, note
that the number of claims as well as the different claims date are
displayed.

4. Bonus point: Edit the CSV profile (Home › Tools › CSV export
profiles) that is named "Late orders (csv profile)", or create a new
one, and modify it.
Export the late orders using this CSV profile and confirm that the
generated CSV file is the one you expect.

Sponsored-by: Institute of Technology Tralee
      d730927d
    • joubu's avatar
      Bug 24161: Add tests · 5dedc27b
      joubu authored 
      Sponsored-by: Cork Institute of Technology
      5dedc27b
    • joubu's avatar
      Bug 24161: Remove GetLateOrders · 2ccfd99c
      joubu authored 
      Sponsored-by: Cork Institute of Technology
      2ccfd99c
    • joubu's avatar
      Bug 24161: Keep tracks of late orders claims · 80b7b848
      joubu authored 
      So far we only record the number of claims and the date of the last
claim, in the aqorders table.
To keep track of the different claim dates, this patchset is going to
make the following DB changes:
  * Create a new table 'aqorders_claims' (id, ordernumber, claimed_on)
  * Remove the two columns from the aqorders table: claims_count and
  claimed_date

This will allow to display the different claim dates where needed: on
the late orders page, and the basket page.

To avoid additional fetches of Koha::Acquisition::Orders, GetLateOrders
has been moved to Koha::Acquisition::Orders->filter_by_late
That way we are going to add consistency, robustness, and cover the
feature with new tests.

Test plan:
0/ Create a bunch of new orders. Make sure they are from different
vendor (with different delivery time).
1/ Go to the late orders page and claim some orders
2/ Reclaim some of those orders
3/ Confirm that you can see the different claim dates for a given orders
(the history of the late orders claims is kept and displayed)

4/ Bonus point: Regression tests:

a. Modify the closedate of the basket in the database. That
will allow you to make sure the patch set did not introduce regressions.
It would be good to test the different filters on the late orders page:
 * delay
 * Estimated delivery date from/to
 * Vendor

b. Confirm that the subtotal and the total values from the late orders
page is correct.

c. Test the update database entry: do not apply these patches, claims
some orders against master. Apply the patch, execute the update DB entry
then confirm that the number of claims is correct (note that the dates
will not as it is not possible to guess them).

QA note: the branchcode parameter has been removed from filter_by_late.
At first glance it seems that it was not used.

Sponsored-by: Cork Institute of Technology
      80b7b848
    • joubu's avatar
      Bug 24161: Add the Koha::Acquisition::Order::Claim[s] classes · 19ba06af
      joubu authored 
      Sponsored-by: Cork Institute of Technology
      19ba06af
    • joubu's avatar
      Bug 24161: DBIC changes · fcd7ea37
      joubu authored 
      Sponsored-by: Cork Institute of Technology
      fcd7ea37
    • joubu's avatar
      Bug 24161: DB changes · 519dcb78
      joubu authored 
      Sponsored-by: Cork Institute of Technology
      519dcb78
    • joubu's avatar
      Bug 24388: Remove uneeded test in lateorders.tt · 17922715
      joubu authored 
      The budget_lock is never set (and has never been).

Test plan:
For QAer only, make sure this never worked
      17922715
  3. Feb 10, 2020
  5. Feb 07, 2020
  7. Feb 06, 2020