Rails5: fix artifacts controller download spec

Rails5 has params[:file_type] as '' if file_type is included as nil
in the request
150 jobs for rails5-fix-artifacts-controller-spec in 59 minutes and 56 seconds (queued for 12 seconds)
Status Job ID Name Coverage
  Prepare
passed #104848625
gitlab-org
compile-assets

00:12:20

passed #104848623
gitlab-org
retrieve-tests-metadata

00:00:24

passed #104848626
gitlab-org
setup-test-env

00:12:15

 
  Test
passed #104848844
allowed to fail
code_quality

00:09:27

passed #104848804
gitlab-org
db:check-schema-pg

00:02:09

passed #104848801
gitlab-org
db:migrate:reset-mysql

00:05:07

passed #104848798
gitlab-org
db:migrate:reset-pg

00:02:45

passed #104848827
gitlab-org
db:rollback-mysql

00:04:33

passed #104848824
gitlab-org
db:rollback-pg

00:02:48

passed #104848846
allowed to fail
dependency_scanning

00:32:33

passed #104848789
gitlab-org
docs lint

00:01:04

passed #104848791
gitlab-org
downtime_check

00:01:17

passed #104848795
gitlab-org
ee_compat_check

00:02:54

passed #104848834
gitlab-org
gitlab:assets:compile

00:12:57

passed #104848831
gitlab-org
gitlab:setup-mysql

00:05:15

passed #104848828
gitlab-org
gitlab:setup-pg

00:05:06

passed #104848849
gitlab-org
gitlab_git_test

00:00:46

passed #104848843
gitlab-org
karma

00:08:54

57.81%
passed #104848821
gitlab-org
migration:path-mysql

00:14:32

passed #104848808
gitlab-org
migration:path-pg

00:11:15

passed #104848847
gitlab-org
qa:internal

00:02:14

passed #104848848
gitlab-org
qa:selectors

00:02:07

passed #104848793
gitlab-org
rails5_gemfile_lock_check

00:01:15

passed #104848664
gitlab-org
rspec-mysql 0 30

00:20:29

passed #104848665
gitlab-org
rspec-mysql 1 30

00:17:48

passed #104848674
gitlab-org
rspec-mysql 10 30

00:16:44

passed #104848675
gitlab-org
rspec-mysql 11 30

00:19:10

passed #104848676
gitlab-org
rspec-mysql 12 30

00:18:51

passed #104848677
gitlab-org
rspec-mysql 13 30

00:20:28

passed #104848679
gitlab-org
rspec-mysql 14 30

00:17:42

passed #104848681
gitlab-org
rspec-mysql 15 30

00:18:37

passed #104848682
gitlab-org
rspec-mysql 16 30

00:20:29

passed #104848683
gitlab-org
rspec-mysql 17 30

00:17:20

passed #104848684
gitlab-org
rspec-mysql 18 30

00:23:16

passed #104848685
gitlab-org
rspec-mysql 19 30

00:19:21

passed #104848666
gitlab-org
rspec-mysql 2 30

00:20:00

passed #104848686
gitlab-org
rspec-mysql 20 30

00:21:59

passed #104848687
gitlab-org
rspec-mysql 21 30

00:19:43

passed #104848688
gitlab-org
rspec-mysql 22 30

00:19:23

passed #104848689
gitlab-org
rspec-mysql 23 30

00:17:29

passed #104848690
gitlab-org
rspec-mysql 24 30

00:18:56

passed #104848691
gitlab-org
rspec-mysql 25 30

00:21:40

passed #104848692
gitlab-org
rspec-mysql 26 30

00:16:41

passed #104848693
gitlab-org
rspec-mysql 27 30

00:18:51

passed #104848694
gitlab-org
rspec-mysql 28 30

00:19:10

passed #104848695
gitlab-org
rspec-mysql 29 30

00:17:57

passed #104848667
gitlab-org
rspec-mysql 3 30

00:18:15

passed #104848668
gitlab-org
rspec-mysql 4 30

00:18:29

passed #104848669
gitlab-org
rspec-mysql 5 30

00:19:56

passed #104848670
gitlab-org
rspec-mysql 6 30

00:18:50

passed #104848671
gitlab-org
rspec-mysql 7 30

00:18:16

passed #104848672
gitlab-org
rspec-mysql 8 30

00:17:15

passed #104848673
gitlab-org
rspec-mysql 9 30

00:19:48

passed #104848750
gitlab-org allowed to fail
rspec-mysql-rails5 0 30

00:18:55

passed #104848751
gitlab-org allowed to fail
rspec-mysql-rails5 1 30

00:18:18

passed #104848761
gitlab-org allowed to fail
rspec-mysql-rails5 10 30

00:19:05

passed #104848762
gitlab-org allowed to fail
rspec-mysql-rails5 11 30

00:19:57

passed #104848763
gitlab-org allowed to fail
rspec-mysql-rails5 12 30

00:20:29

passed #104848765
gitlab-org allowed to fail
rspec-mysql-rails5 13 30

00:21:54

failed #104858890
gitlab-org allowed to fail
rspec-mysql-rails5 14 30

00:21:23

passed #104848767
gitlab-org allowed to fail
rspec-mysql-rails5 15 30

00:22:23

passed #104848768
gitlab-org allowed to fail
rspec-mysql-rails5 16 30

00:22:32

passed #104848769
gitlab-org allowed to fail
rspec-mysql-rails5 17 30

00:19:05

passed #104848770
gitlab-org allowed to fail
rspec-mysql-rails5 18 30

00:25:23

passed #104848771
gitlab-org allowed to fail
rspec-mysql-rails5 19 30

00:20:53

passed #104848752
gitlab-org allowed to fail
rspec-mysql-rails5 2 30

00:24:44

passed #104848772
gitlab-org allowed to fail
rspec-mysql-rails5 20 30

00:23:17

passed #104848773
gitlab-org allowed to fail
rspec-mysql-rails5 21 30

00:21:47

passed #104848774
gitlab-org allowed to fail
rspec-mysql-rails5 22 30

00:24:50

passed #104848775
gitlab-org allowed to fail
rspec-mysql-rails5 23 30

00:20:48

passed #104848777
gitlab-org allowed to fail
rspec-mysql-rails5 24 30

00:21:03

passed #104848778
gitlab-org allowed to fail
rspec-mysql-rails5 25 30

00:23:25

passed #104848779
gitlab-org allowed to fail
rspec-mysql-rails5 26 30

00:19:03

passed #104848780
gitlab-org allowed to fail
rspec-mysql-rails5 27 30

00:22:44

passed #104848781
gitlab-org allowed to fail
rspec-mysql-rails5 28 30

00:23:57

passed #104848782
gitlab-org allowed to fail
rspec-mysql-rails5 29 30

00:22:33

passed #104848754
gitlab-org allowed to fail
rspec-mysql-rails5 3 30

00:17:58

passed #104848755
gitlab-org allowed to fail
rspec-mysql-rails5 4 30

00:20:43

passed #104848756
gitlab-org allowed to fail
rspec-mysql-rails5 5 30

00:23:52

passed #104848757
gitlab-org allowed to fail
rspec-mysql-rails5 6 30

00:19:51

passed #104848758
gitlab-org allowed to fail
rspec-mysql-rails5 7 30

00:18:46

passed #104848759
gitlab-org allowed to fail
rspec-mysql-rails5 8 30

00:17:44

passed #104848760
gitlab-org allowed to fail
rspec-mysql-rails5 9 30

00:24:24

passed #104848627
gitlab-org
rspec-pg 0 30

00:19:25

passed #104848628
gitlab-org
rspec-pg 1 30

00:16:56

passed #104848637
gitlab-org
rspec-pg 10 30

00:17:10

passed #104848638
gitlab-org
rspec-pg 11 30

00:19:07

passed #104848640
gitlab-org
rspec-pg 12 30

00:17:06

passed #104848641
gitlab-org
rspec-pg 13 30

00:18:53

passed #104848642
gitlab-org
rspec-pg 14 30

00:15:38

passed #104848643
gitlab-org
rspec-pg 15 30

00:18:25

passed #104848644
gitlab-org
rspec-pg 16 30

00:16:55

passed #104848645
gitlab-org
rspec-pg 17 30

00:16:40

passed #104848646
gitlab-org
rspec-pg 18 30

00:18:18

passed #104848647
gitlab-org
rspec-pg 19 30

00:16:11

passed #104848629
gitlab-org
rspec-pg 2 30

00:20:02

passed #104848649
gitlab-org
rspec-pg 20 30

00:14:55

passed #104848650
gitlab-org
rspec-pg 21 30

00:20:38

passed #104848652
gitlab-org
rspec-pg 22 30

00:18:35

passed #104848654
gitlab-org
rspec-pg 23 30

00:16:22

passed #104848656
gitlab-org
rspec-pg 24 30

00:16:29

passed #104848657
gitlab-org
rspec-pg 25 30

00:17:31

passed #104848659
gitlab-org
rspec-pg 26 30

00:14:59

passed #104848660
gitlab-org
rspec-pg 27 30

00:20:03

passed #104848661
gitlab-org
rspec-pg 28 30

00:18:50

passed #104848662
gitlab-org
rspec-pg 29 30

00:17:24

passed #104848630
gitlab-org
rspec-pg 3 30

00:17:36

passed #104848631
gitlab-org
rspec-pg 4 30

00:18:56

passed #104848632
gitlab-org
rspec-pg 5 30

00:19:51

passed #104848633
gitlab-org
rspec-pg 6 30

00:18:35

passed #104848634
gitlab-org
rspec-pg 7 30

00:18:10

passed #104848635
gitlab-org
rspec-pg 8 30

00:16:01

passed #104848636
gitlab-org
rspec-pg 9 30

00:17:12

passed #104848696
gitlab-org allowed to fail
rspec-pg-rails5 0 30

00:19:07

passed #104848697
gitlab-org allowed to fail
rspec-pg-rails5 1 30

00:18:31

passed #104848706
gitlab-org allowed to fail
rspec-pg-rails5 10 30

00:17:09

passed #104848707
gitlab-org allowed to fail
rspec-pg-rails5 11 30

00:18:53

passed #104848708
gitlab-org allowed to fail
rspec-pg-rails5 12 30

00:20:16

passed #104848709
gitlab-org allowed to fail
rspec-pg-rails5 13 30

00:21:12

failed #104858290
gitlab-org allowed to fail
rspec-pg-rails5 14 30

00:22:20

passed #104848711
gitlab-org allowed to fail
rspec-pg-rails5 15 30

00:22:03

passed #104848713
gitlab-org allowed to fail
rspec-pg-rails5 16 30

00:22:52

passed #104848715
gitlab-org allowed to fail
rspec-pg-rails5 17 30

00:19:02

passed #104848716
gitlab-org allowed to fail
rspec-pg-rails5 18 30

00:19:25

passed #104848717
gitlab-org allowed to fail
rspec-pg-rails5 19 30

00:19:49

passed #104848698
gitlab-org allowed to fail
rspec-pg-rails5 2 30

00:23:22

passed #104848718
gitlab-org allowed to fail
rspec-pg-rails5 20 30

00:18:04

passed #104848719
gitlab-org allowed to fail
rspec-pg-rails5 21 30

00:20:03

passed #104848720
gitlab-org allowed to fail
rspec-pg-rails5 22 30

00:21:06

passed #104848721
gitlab-org allowed to fail
rspec-pg-rails5 23 30

00:21:25

passed #104848722
gitlab-org allowed to fail
rspec-pg-rails5 24 30

00:18:46

passed #104848723
gitlab-org allowed to fail
rspec-pg-rails5 25 30

00:21:31

passed #104848724
gitlab-org allowed to fail
rspec-pg-rails5 26 30

00:17:23

passed #104848730
gitlab-org allowed to fail
rspec-pg-rails5 27 30

00:18:57

passed #104848742
gitlab-org allowed to fail
rspec-pg-rails5 28 30

00:20:52

passed #104848749
gitlab-org allowed to fail
rspec-pg-rails5 29 30

00:16:53

passed #104848699
gitlab-org allowed to fail
rspec-pg-rails5 3 30

00:16:59

passed #104848700
gitlab-org allowed to fail
rspec-pg-rails5 4 30

00:20:21

passed #104848701
gitlab-org allowed to fail
rspec-pg-rails5 5 30

00:21:02

passed #104848702
gitlab-org allowed to fail
rspec-pg-rails5 6 30

00:21:42

passed #104848703
gitlab-org allowed to fail
rspec-pg-rails5 7 30

00:19:12

passed #104848704
gitlab-org allowed to fail
rspec-pg-rails5 8 30

00:17:59

passed #104848705
gitlab-org allowed to fail
rspec-pg-rails5 9 30

00:19:55

passed #104848845
allowed to fail
sast

00:04:44

passed #104848783
gitlab-org
static-analysis

00:22:00

failed #104848766
gitlab-org allowed to fail
rspec-mysql-rails5 14 30

00:22:51

failed #104848710
gitlab-org allowed to fail
rspec-pg-rails5 14 30

00:20:40

 
  Post Test
passed #104848851
gitlab-org
coverage

00:03:07

94.82%
failed #104848850
gitlab-org allowed to fail
flaky-examples-check

00:01:50

passed #104848852
gitlab-org
lint:javascript:report

00:02:28

 
Name Stage Failure
failed
rspec-pg-rails5 14 30 Test
coverage/: found 5 matching files                  
knapsack/: found 4 matching files

rspec_flaky/: found 4 matching files

WARNING: tmp/capybara/: no matching files
Uploading artifacts to coordinator... ok
id=104858290 responseStatus=201 Created token=pJGDzi7p
Uploading artifacts...
junit_rspec.xml: found 1 matching files

Uploading artifacts to coordinator... ok
id=104858290 responseStatus=201 Created token=pJGDzi7p
ERROR: Job failed: exit code 1
failed
rspec-mysql-rails5 14 30 Test
coverage/: found 5 matching files                  
knapsack/: found 4 matching files

rspec_flaky/: found 4 matching files

WARNING: tmp/capybara/: no matching files
Uploading artifacts to coordinator... ok
id=104858890 responseStatus=201 Created token=1S5zhfpp
Uploading artifacts...
junit_rspec.xml: found 1 matching files

Uploading artifacts to coordinator... ok
id=104858890 responseStatus=201 Created token=1S5zhfpp
ERROR: Job failed: exit code 1
failed
flaky-examples-check Post Test
    "first_flaky_at": "2018-10-04 20:27:41 +0000",
"last_flaky_at": "2018-10-04 20:27:41 +0000",
"last_flaky_job": "https://gitlab.com/jlemaes/gitlab-ce/-/jobs/104848698"
}
}
Running after script...
$ date
Thu Oct 4 20:53:05 UTC 2018
ERROR: Job failed: exit code 1