1. 11 Jun, 2018 1 commit
  2. 01 Jun, 2018 1 commit
  3. 05 Mar, 2018 1 commit
  4. 13 Feb, 2018 2 commits
  5. 06 Feb, 2018 1 commit
  6. 06 Nov, 2017 1 commit
  7. 02 Aug, 2017 1 commit
  8. 01 Aug, 2017 1 commit
  9. 21 Jun, 2017 1 commit
  10. 30 May, 2017 1 commit
  11. 24 May, 2017 3 commits
  12. 02 May, 2017 3 commits
  13. 01 May, 2017 10 commits
  14. 16 Dec, 2016 2 commits
    • Timothy Andrew's avatar
      Implement review comments from @dbalexandre. · 3e144276
      Timothy Andrew authored
      - Don't define "allowed environment variables" in two places.
      - Dispatch to different arities of `Popen.open` without an if/else block.
      - Use `described_class` instead of explicitly stating the class name within a
      - spec.
      - Remove `git_environment_variables_validator_spec` and keep the validation inline.
      3e144276
    • Timothy Andrew's avatar
      Validate environment variables in `Gitlab::Git::RevList` · a2b39feb
      Timothy Andrew authored
      The list of environment variables in `Gitlab::Git::RevList` need to be validate
      to make sure that they don't reference any other project on disk.
      
      This commit mixes in `ActiveModel::Validations` into `Gitlab::Git::RevList`, and
      validates that the environment variables are on the level (using a custom
      validator class). If the validations fail, the force push is still executed
      without any environment variables set.
      
      Add specs for the validation using shared examples.
      a2b39feb