.rubocop_todo.yml 24.5 KB
Newer Older
1
# This configuration was generated by
Rémy Coutable's avatar
Rémy Coutable committed
2
# `rubocop --auto-gen-config`
3
# on 2018-01-18 18:23:26 +0100 using RuboCop version 0.52.1.
4 5 6 7 8
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

9
# Offense count: 181
Rémy Coutable's avatar
Rémy Coutable committed
10 11 12
Capybara/CurrentPathExpectation:
  Enabled: false

13
# Offense count: 23
Rémy Coutable's avatar
Rémy Coutable committed
14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30
FactoryBot/DynamicAttributeDefinedStatically:
  Exclude:
    - 'spec/factories/broadcast_messages.rb'
    - 'spec/factories/ci/builds.rb'
    - 'spec/factories/ci/runners.rb'
    - 'spec/factories/clusters/applications/helm.rb'
    - 'spec/factories/clusters/platforms/kubernetes.rb'
    - 'spec/factories/emails.rb'
    - 'spec/factories/gpg_keys.rb'
    - 'spec/factories/group_members.rb'
    - 'spec/factories/merge_requests.rb'
    - 'spec/factories/notes.rb'
    - 'spec/factories/oauth_access_grants.rb'
    - 'spec/factories/project_members.rb'
    - 'spec/factories/todos.rb'
    - 'spec/factories/uploads.rb'

31
# Offense count: 167
Rémy Coutable's avatar
Rémy Coutable committed
32 33 34 35
# Cop supports --auto-correct.
Layout/EmptyLinesAroundArguments:
  Enabled: false

36
# Offense count: 253
37 38 39 40 41
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
Layout/ExtraSpacing:
  Enabled: false

42
# Offense count: 83
43
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
44
# Configuration parameters: EnforcedStyle, IndentationWidth.
45 46 47 48
# SupportedStyles: special_inside_parentheses, consistent, align_brackets
Layout/IndentArray:
  Enabled: false

49
# Offense count: 237
50
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
51
# Configuration parameters: EnforcedStyle, IndentationWidth.
52 53 54 55
# SupportedStyles: special_inside_parentheses, consistent, align_braces
Layout/IndentHash:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
56
# Offense count: 11
57
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
58 59 60 61 62 63 64 65 66 67 68 69 70 71 72
# Configuration parameters: AllowForAlignment.
Layout/SpaceBeforeFirstArg:
  Exclude:
    - 'config/routes/project.rb'
    - 'db/migrate/20170506185517_add_foreign_key_pipeline_schedules_and_pipelines.rb'
    - 'features/steps/project/source/browse_files.rb'
    - 'features/steps/project/source/markdown_render.rb'
    - 'lib/api/runners.rb'
    - 'spec/features/search/user_uses_search_filters_spec.rb'
    - 'spec/routing/project_routing_spec.rb'
    - 'spec/services/system_note_service_spec.rb'

# Offense count: 93
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
73 74 75 76
# SupportedStyles: require_no_space, require_space
Layout/SpaceInLambdaLiteral:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
77
# Offense count: 1
78
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
79 80 81 82 83 84 85
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets.
# SupportedStyles: space, no_space, compact
# SupportedStylesForEmptyBrackets: space, no_space
Layout/SpaceInsideArrayLiteralBrackets:
  Exclude:
    - 'spec/lib/gitlab/import_export/relation_factory_spec.rb'

86
# Offense count: 327
Rémy Coutable's avatar
Rémy Coutable committed
87 88
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
89 90 91 92 93
# SupportedStyles: space, no_space
# SupportedStylesForEmptyBraces: space, no_space
Layout/SpaceInsideBlockBraces:
  Enabled: false

94
# Offense count: 156
95 96 97 98 99 100 101
# Cop supports --auto-correct.
Layout/SpaceInsideParens:
  Enabled: false

# Offense count: 14
# Cop supports --auto-correct.
Layout/SpaceInsidePercentLiteralDelimiters:
Rémy Coutable's avatar
Rémy Coutable committed
102 103 104 105 106
  Exclude:
    - 'lib/gitlab/git_access.rb'
    - 'lib/gitlab/health_checks/fs_shards_check.rb'
    - 'spec/lib/gitlab/health_checks/fs_shards_check_spec.rb'

107
# Offense count: 26
Rémy Coutable's avatar
Rémy Coutable committed
108 109 110 111 112 113 114 115 116 117 118 119 120 121 122
Lint/DuplicateMethods:
  Exclude:
    - 'app/models/application_setting.rb'
    - 'app/models/commit.rb'
    - 'app/models/note.rb'
    - 'app/services/merge_requests/merge_service.rb'
    - 'lib/bitbucket/representation/repo.rb'
    - 'lib/declarative_policy/base.rb'
    - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb'
    - 'lib/gitlab/cycle_analytics/base_event_fetcher.rb'
    - 'lib/gitlab/diff/formatters/base_formatter.rb'
    - 'lib/gitlab/git/blob.rb'
    - 'lib/gitlab/git/repository.rb'
    - 'lib/gitlab/git/tree.rb'
    - 'lib/gitlab/git/wiki_page.rb'
123 124
    - 'lib/gitlab/auth/ldap/person.rb'
    - 'lib/gitlab/auth/o_auth/user.rb'
Rémy Coutable's avatar
Rémy Coutable committed
125 126 127 128 129 130 131 132

# Offense count: 4
Lint/InterpolationCheck:
  Exclude:
    - 'spec/features/issues/filtered_search/filter_issues_spec.rb'
    - 'spec/features/users_spec.rb'
    - 'spec/services/quick_actions/interpret_service_spec.rb'

133
# Offense count: 206
Rémy Coutable's avatar
Rémy Coutable committed
134 135 136 137 138 139 140 141
# Configuration parameters: MaximumRangeSize.
Lint/MissingCopEnableDirective:
  Enabled: false

# Offense count: 2
Lint/NestedPercentLiteral:
  Exclude:
    - 'lib/gitlab/git/repository.rb'
142
    - 'spec/support/shared_examples/email_format_shared_examples.rb'
Rémy Coutable's avatar
Rémy Coutable committed
143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172

# Offense count: 1
Lint/ReturnInVoidContext:
  Exclude:
    - 'app/models/project.rb'

# Offense count: 1
# Configuration parameters: IgnoreImplicitReferences.
Lint/ShadowedArgument:
  Exclude:
    - 'lib/gitlab/database/sha_attribute.rb'

# Offense count: 3
# Cop supports --auto-correct.
Lint/UnneededRequireStatement:
  Exclude:
    - 'db/post_migrate/20161221153951_rename_reserved_project_names.rb'
    - 'db/post_migrate/20170313133418_rename_more_reserved_project_names.rb'
    - 'lib/declarative_policy.rb'

# Offense count: 9
Lint/UriEscapeUnescape:
  Exclude:
    - 'app/controllers/application_controller.rb'
    - 'app/models/project_services/drone_ci_service.rb'
    - 'spec/lib/google_api/auth_spec.rb'
    - 'spec/requests/api/files_spec.rb'
    - 'spec/requests/api/internal_spec.rb'
    - 'spec/requests/api/issues_spec.rb'

173 174 175 176 177 178
# Offense count: 1
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
Metrics/LineLength:
  Max: 1310

Rémy Coutable's avatar
Rémy Coutable committed
179 180 181 182 183 184 185 186 187 188 189 190 191 192
# Offense count: 2
Naming/ConstantName:
  Exclude:
    - 'lib/gitlab/import_sources.rb'
    - 'lib/gitlab/ssh_public_key.rb'

# Offense count: 11
# Configuration parameters: EnforcedStyle.
# SupportedStyles: lowercase, uppercase
Naming/HeredocDelimiterCase:
  Exclude:
    - 'spec/lib/gitlab/diff/parser_spec.rb'
    - 'spec/lib/json_web_token/rsa_token_spec.rb'
    - 'spec/models/commit_spec.rb'
193 194
    - 'spec/support/helpers/repo_helpers.rb'
    - 'spec/support/helpers/seed_repo.rb'
Rémy Coutable's avatar
Rémy Coutable committed
195

196
# Offense count: 112
Rémy Coutable's avatar
Rémy Coutable committed
197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212
# Configuration parameters: Blacklist.
# Blacklist: END, (?-mix:EO[A-Z]{1})
Naming/HeredocDelimiterNaming:
  Enabled: false

# Offense count: 1
Performance/UnfreezeString:
  Exclude:
    - 'features/steps/project/commits/commits.rb'

# Offense count: 1
# Cop supports --auto-correct.
Performance/UriDefaultParser:
  Exclude:
    - 'lib/gitlab/url_sanitizer.rb'

213
# Offense count: 3821
Rémy Coutable's avatar
Rémy Coutable committed
214 215 216
# Configuration parameters: Prefixes.
# Prefixes: when, with, without
RSpec/ContextWording:
217 218
  Enabled: false

219
# Offense count: 293
220 221 222
RSpec/EmptyLineAfterFinalLet:
  Enabled: false

223
# Offense count: 188
224 225 226
RSpec/EmptyLineAfterSubject:
  Enabled: false

227 228 229 230 231 232 233
# Offense count: 258
# Configuration parameters: EnforcedStyle.
# SupportedStyles: method_call, block
RSpec/ExpectChange:
  Enabled: false

# Offense count: 221
Rémy Coutable's avatar
Rémy Coutable committed
234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249
RSpec/ExpectInHook:
  Enabled: false

# Offense count: 7
# Configuration parameters: EnforcedStyle.
# SupportedStyles: implicit, each, example
RSpec/HookArgument:
  Exclude:
    - 'spec/spec_helper.rb'
    - 'spec/support/carrierwave.rb'
    - 'spec/support/db_cleaner.rb'
    - 'spec/support/gitaly.rb'
    - 'spec/support/setup_builds_storage.rb'

# Offense count: 19
# Configuration parameters: EnforcedStyle.
250 251
# SupportedStyles: it_behaves_like, it_should_behave_like
RSpec/ItBehavesLike:
Rémy Coutable's avatar
Rémy Coutable committed
252 253 254 255 256 257
  Exclude:
    - 'spec/lib/gitlab/git/commit_spec.rb'
    - 'spec/lib/gitlab/git/repository_spec.rb'
    - 'spec/lib/gitlab/shell_spec.rb'
    - 'spec/services/notification_service_spec.rb'
    - 'spec/workers/git_garbage_collect_worker_spec.rb'
258

Rémy Coutable's avatar
Rémy Coutable committed
259
# Offense count: 5
260
RSpec/IteratedExpectation:
Rémy Coutable's avatar
Rémy Coutable committed
261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283
  Exclude:
    - 'spec/features/admin/admin_settings_spec.rb'
    - 'spec/features/merge_requests/diff_notes_resolve_spec.rb'
    - 'spec/features/projects/awards/user_interacts_with_awards_in_issue_spec.rb'
    - 'spec/lib/gitlab/gitlab_import/client_spec.rb'
    - 'spec/lib/gitlab/legacy_github_import/client_spec.rb'

# Offense count: 75
RSpec/LetBeforeExamples:
  Exclude:
    - 'spec/controllers/projects/commit_controller_spec.rb'
    - 'spec/lib/banzai/filter/issue_reference_filter_spec.rb'
    - 'spec/lib/banzai/filter/user_reference_filter_spec.rb'
    - 'spec/lib/gitlab/email/handler/create_issue_handler_spec.rb'
    - 'spec/lib/gitlab/email/handler/create_merge_request_handler_spec.rb'
    - 'spec/lib/gitlab/email/handler/create_note_handler_spec.rb'
    - 'spec/models/commit_range_spec.rb'
    - 'spec/models/milestone_spec.rb'
    - 'spec/models/project_services/packagist_service_spec.rb'
    - 'spec/models/repository_spec.rb'
    - 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb'
    - 'spec/serializers/pipeline_details_entity_spec.rb'
    - 'spec/views/ci/lints/show.html.haml_spec.rb'
284

Rémy Coutable's avatar
Rémy Coutable committed
285 286 287 288 289 290
# Offense count: 1
RSpec/MultipleSubjects:
  Exclude:
    - 'spec/services/merge_requests/create_from_issue_service_spec.rb'

# Offense count: 4
291
RSpec/OverwritingSetup:
Rémy Coutable's avatar
Rémy Coutable committed
292 293 294 295 296 297
  Exclude:
    - 'spec/lib/gitlab/background_migration/migrate_events_to_push_event_payloads_spec.rb'
    - 'spec/models/email_spec.rb'
    - 'spec/services/merge_requests/add_todo_when_build_fails_service_spec.rb'
    - 'spec/services/notes/quick_actions_service_spec.rb'

298
# Offense count: 965
Rémy Coutable's avatar
Rémy Coutable committed
299 300 301
# Configuration parameters: Strict, EnforcedStyle.
# SupportedStyles: inflected, explicit
RSpec/PredicateMatcher:
302 303
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
304
# Offense count: 35
305 306 307
RSpec/RepeatedExample:
  Enabled: false

308
# Offense count: 140
Rémy Coutable's avatar
Rémy Coutable committed
309 310 311 312 313
# Configuration parameters: EnforcedStyle.
# SupportedStyles: and_return, block
RSpec/ReturnFromStub:
  Enabled: false

314
# Offense count: 112
315 316 317
RSpec/ScatteredLet:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
318
# Offense count: 22
319
RSpec/ScatteredSetup:
Rémy Coutable's avatar
Rémy Coutable committed
320 321 322 323 324 325
  Exclude:
    - 'spec/controllers/projects/templates_controller_spec.rb'
    - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb'
    - 'spec/lib/gitlab/git/env_spec.rb'
    - 'spec/requests/api/jobs_spec.rb'
    - 'spec/services/projects/create_service_spec.rb'
326

327
# Offense count: 1
328
RSpec/SharedContext:
Rémy Coutable's avatar
Rémy Coutable committed
329 330 331 332 333 334 335 336 337 338 339 340
  Exclude:
    - 'spec/features/admin/admin_groups_spec.rb'

# Offense count: 5
RSpec/VoidExpect:
  Exclude:
    - 'spec/features/projects/artifacts/download_spec.rb'
    - 'spec/features/projects/services/user_activates_mattermost_slash_command_spec.rb'
    - 'spec/models/ci/group_spec.rb'
    - 'spec/models/ci/runner_spec.rb'
    - 'spec/services/users/destroy_service_spec.rb'

341
# Offense count: 41
Rémy Coutable's avatar
Rémy Coutable committed
342 343 344
# Configuration parameters: Include.
# Include: db/migrate/*.rb
Rails/CreateTableWithTimestamps:
345 346
  Enabled: false

347
# Offense count: 155
348 349 350
Rails/FilePath:
  Enabled: false

351
# Offense count: 121
Rémy Coutable's avatar
Rémy Coutable committed
352 353 354 355 356
# Configuration parameters: Include.
# Include: app/models/**/*.rb
Rails/HasManyOrHasOneDependent:
  Enabled: false

357
# Offense count: 157
Rémy Coutable's avatar
Rémy Coutable committed
358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386
# Configuration parameters: Include.
# Include: app/models/**/*.rb
Rails/InverseOf:
  Enabled: false

# Offense count: 48
# Configuration parameters: Include.
# Include: app/controllers/**/*.rb
Rails/LexicallyScopedActionFilter:
  Enabled: false

# Offense count: 14
# Cop supports --auto-correct.
Rails/Presence:
  Exclude:
    - 'app/controllers/projects/blob_controller.rb'
    - 'app/models/ci/pipeline.rb'
    - 'app/models/clusters/platforms/kubernetes.rb'
    - 'app/models/concerns/mentionable.rb'
    - 'app/models/concerns/token_authenticatable.rb'
    - 'app/models/project_services/hipchat_service.rb'
    - 'app/models/project_services/irker_service.rb'
    - 'app/models/project_services/jira_service.rb'
    - 'app/models/project_services/kubernetes_service.rb'
    - 'app/models/project_services/packagist_service.rb'
    - 'app/models/wiki_page.rb'
    - 'lib/gitlab/git/hook.rb'
    - 'lib/gitlab/github_import/importer/releases_importer.rb'

387 388 389 390
# Offense count: 2
# Configuration parameters: Include.
# Include: db/migrate/*.rb
Rails/ReversibleMigration:
Rémy Coutable's avatar
Rémy Coutable committed
391 392
  Exclude:
    - 'db/migrate/20160824103857_drop_unused_ci_tables.rb'
393

394
# Offense count: 446
395 396 397
# Configuration parameters: Blacklist.
# Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters
Rails/SkipsModelValidations:
398 399
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
400 401 402 403 404 405
# Offense count: 1
# Configuration parameters: Environments.
# Environments: development, test, production
Rails/UnknownEnv:
  Exclude:
    - 'db/migrate/20171124125748_populate_missing_merge_request_statuses.rb'
406

Rémy Coutable's avatar
Rémy Coutable committed
407
# Offense count: 13
408
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
409 410 411 412 413 414 415 416 417 418 419 420
Security/YAMLLoad:
  Exclude:
    - 'config/initializers/carrierwave.rb'
    - 'lib/gitlab/background_migration/deserialize_merge_request_diffs_and_commits.rb'
    - 'lib/gitlab/redis/wrapper.rb'
    - 'lib/system_check/incoming_email/imap_authentication_check.rb'
    - 'spec/config/mail_room_spec.rb'
    - 'spec/initializers/secret_token_spec.rb'
    - 'spec/lib/gitlab/prometheus/additional_metrics_parser_spec.rb'
    - 'spec/models/clusters/platforms/kubernetes_spec.rb'
    - 'spec/models/project_services/kubernetes_service_spec.rb'

421
# Offense count: 64
Rémy Coutable's avatar
Rémy Coutable committed
422 423
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
424 425 426
# SupportedStyles: percent_q, bare_percent
Style/BarePercentLiterals:
  Enabled: false
427

Rémy Coutable's avatar
Rémy Coutable committed
428 429 430 431 432 433 434 435
# Offense count: 5
Style/CommentedKeyword:
  Exclude:
    - 'lib/tasks/gitlab/backup.rake'
    - 'spec/tasks/gitlab/backup_rake_spec.rb'

# Offense count: 30
Style/DateTime:
436
  Enabled: false
Connor Shea's avatar
Connor Shea committed
437

Rémy Coutable's avatar
Rémy Coutable committed
438
# Offense count: 1
Connor Shea's avatar
Connor Shea committed
439
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460
Style/Dir:
  Exclude:
    - 'qa/qa.rb'

# Offense count: 9
# Cop supports --auto-correct.
Style/EachWithObject:
  Exclude:
    - 'config/initializers/gollum.rb'
    - 'lib/expand_variables.rb'
    - 'lib/gitlab/ci/ansi2html.rb'
    - 'lib/gitlab/ee_compat_check.rb'
    - 'lib/gitlab/hook_data/issuable_builder.rb'
    - 'lib/gitlab/i18n/po_linter.rb'
    - 'lib/gitlab/import_export/members_mapper.rb'
    - 'lib/gitlab/import_export/relation_factory.rb'
    - 'scripts/static-analysis'

# Offense count: 24
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
461 462 463 464
# SupportedStyles: empty, nil, both
Style/EmptyElse:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
465 466 467 468 469 470 471 472
# Offense count: 14
# Cop supports --auto-correct.
Style/EmptyLambdaParameter:
  Exclude:
    - 'app/models/ci/build.rb'
    - 'app/models/ci/runner.rb'

# Offense count: 12
Connor Shea's avatar
Connor Shea committed
473 474
# Cop supports --auto-correct.
Style/EmptyLiteral:
Rémy Coutable's avatar
Rémy Coutable committed
475 476 477 478 479
  Exclude:
    - 'features/steps/project/commits/commits.rb'
    - 'lib/gitlab/fogbugz_import/importer.rb'
    - 'lib/gitlab/git/diff_collection.rb'
    - 'lib/gitlab/gitaly_client.rb'
480
    - 'scripts/trigger-build'
Rémy Coutable's avatar
Rémy Coutable committed
481 482 483 484 485
    - 'spec/features/merge_requests/versions_spec.rb'
    - 'spec/helpers/merge_requests_helper_spec.rb'
    - 'spec/lib/gitlab/request_context_spec.rb'
    - 'spec/lib/gitlab/workhorse_spec.rb'
    - 'spec/requests/api/jobs_spec.rb'
486
    - 'spec/support/shared_examples/chat_slash_commands_shared_examples.rb'
487

488
# Offense count: 102
489
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
490
# Configuration parameters: EnforcedStyle.
491 492
# SupportedStyles: compact, expanded
Style/EmptyMethod:
493
  Enabled: false
Connor Shea's avatar
Connor Shea committed
494

495
# Offense count: 23
Connor Shea's avatar
Connor Shea committed
496
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
497 498 499 500 501 502 503 504
Style/Encoding:
  Enabled: false

# Offense count: 2
Style/EvalWithLocation:
  Exclude:
    - 'app/models/service.rb'

505
# Offense count: 35
Rémy Coutable's avatar
Rémy Coutable committed
506 507
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
508 509
# SupportedStyles: format, sprintf, percent
Style/FormatString:
510 511
  Enabled: false

512
# Offense count: 384
Connor Shea's avatar
Connor Shea committed
513 514 515 516
# Configuration parameters: MinBodyLength.
Style/GuardClause:
  Enabled: false

517
# Offense count: 22
Connor Shea's avatar
Connor Shea committed
518
Style/IfInsideElse:
519 520
  Enabled: false

521
# Offense count: 809
Connor Shea's avatar
Connor Shea committed
522 523 524 525
# Cop supports --auto-correct.
Style/IfUnlessModifier:
  Enabled: false

526
# Offense count: 75
Connor Shea's avatar
Connor Shea committed
527
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
528
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
529 530
# SupportedStyles: line_count_dependent, lambda, literal
Style/Lambda:
531
  Enabled: false
Connor Shea's avatar
Connor Shea committed
532

Rémy Coutable's avatar
Rémy Coutable committed
533
# Offense count: 11
Connor Shea's avatar
Connor Shea committed
534 535
# Cop supports --auto-correct.
Style/LineEndConcatenation:
Rémy Coutable's avatar
Rémy Coutable committed
536 537 538 539 540 541
  Exclude:
    - 'app/helpers/tree_helper.rb'
    - 'spec/features/issuables/markdown_references_spec.rb'
    - 'spec/lib/gitlab/checks/project_moved_spec.rb'
    - 'spec/lib/gitlab/gfm/reference_rewriter_spec.rb'
    - 'spec/lib/gitlab/incoming_email_spec.rb'
Connor Shea's avatar
Connor Shea committed
542

Rémy Coutable's avatar
Rémy Coutable committed
543
# Offense count: 39
Connor Shea's avatar
Connor Shea committed
544
# Cop supports --auto-correct.
545
Style/MethodCallWithoutArgsParentheses:
546
  Enabled: false
Connor Shea's avatar
Connor Shea committed
547

548
# Offense count: 18
549
Style/MethodMissing:
550
  Enabled: false
551

Rémy Coutable's avatar
Rémy Coutable committed
552 553 554 555 556 557 558 559 560 561 562
# Offense count: 7
Style/MixinUsage:
  Exclude:
    - 'features/support/env.rb'
    - 'spec/factories/ci/builds.rb'
    - 'spec/factories/ci/job_artifacts.rb'
    - 'spec/factories/lfs_objects.rb'
    - 'spec/factories/notes.rb'
    - 'spec/lib/gitlab/import_export/project_tree_restorer_spec.rb'
    - 'spec/lib/gitlab/import_export/version_checker_spec.rb'

563
# Offense count: 6
564 565
# Cop supports --auto-correct.
Style/MultilineIfModifier:
Rémy Coutable's avatar
Rémy Coutable committed
566 567 568 569 570 571 572
  Exclude:
    - 'app/helpers/snippets_helper.rb'
    - 'app/models/project_wiki.rb'
    - 'app/services/ci/process_pipeline_service.rb'
    - 'app/services/create_deployment_service.rb'
    - 'lib/api/commit_statuses.rb'
    - 'lib/gitlab/ci/trace.rb'
573

574
# Offense count: 25
Connor Shea's avatar
Connor Shea committed
575
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
576 577
# Configuration parameters: Whitelist.
# Whitelist: be, be_a, be_an, be_between, be_falsey, be_kind_of, be_instance_of, be_truthy, be_within, eq, eql, end_with, include, match, raise_error, respond_to, start_with
Connor Shea's avatar
Connor Shea committed
578
Style/NestedParenthesizedCalls:
579
  Enabled: false
Connor Shea's avatar
Connor Shea committed
580

581
# Offense count: 19
Connor Shea's avatar
Connor Shea committed
582
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
583
# Configuration parameters: EnforcedStyle, MinBodyLength.
Connor Shea's avatar
Connor Shea committed
584 585
# SupportedStyles: skip_modifier_ifs, always
Style/Next:
586
  Enabled: false
Connor Shea's avatar
Connor Shea committed
587

588
# Offense count: 61
589
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
590
# Configuration parameters: EnforcedOctalStyle.
591 592
# SupportedOctalStyles: zero_with_o, zero_only
Style/NumericLiteralPrefix:
593
  Enabled: false
Douwe Maan's avatar
Douwe Maan committed
594

595
# Offense count: 114
596
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
597
# Configuration parameters: AutoCorrect, EnforcedStyle.
598 599 600 601
# SupportedStyles: predicate, comparison
Style/NumericPredicate:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
602 603 604 605 606 607 608 609 610
# Offense count: 4
# Cop supports --auto-correct.
Style/OrAssignment:
  Exclude:
    - 'app/models/concerns/token_authenticatable.rb'
    - 'lib/api/commit_statuses.rb'
    - 'lib/gitlab/project_transfer.rb'

# Offense count: 50
Connor Shea's avatar
Connor Shea committed
611 612 613 614
# Cop supports --auto-correct.
Style/ParallelAssignment:
  Enabled: false

615
# Offense count: 917
Connor Shea's avatar
Connor Shea committed
616 617 618 619 620
# Cop supports --auto-correct.
# Configuration parameters: PreferredDelimiters.
Style/PercentLiteralDelimiters:
  Enabled: false

621
# Offense count: 15
Connor Shea's avatar
Connor Shea committed
622 623
# Cop supports --auto-correct.
Style/PerlBackrefs:
Rémy Coutable's avatar
Rémy Coutable committed
624 625 626 627 628 629 630 631 632 633 634 635 636
  Exclude:
    - 'app/controllers/projects/application_controller.rb'
    - 'app/helpers/submodule_helper.rb'
    - 'lib/backup/manager.rb'
    - 'lib/banzai/filter/abstract_reference_filter.rb'
    - 'lib/banzai/filter/autolink_filter.rb'
    - 'lib/banzai/filter/emoji_filter.rb'
    - 'lib/banzai/filter/gollum_tags_filter.rb'
    - 'lib/expand_variables.rb'
    - 'lib/gitlab/diff/highlight.rb'
    - 'lib/gitlab/search_results.rb'
    - 'lib/gitlab/sherlock/query.rb'

637
# Offense count: 87
Rémy Coutable's avatar
Rémy Coutable committed
638 639
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
640 641 642 643
# SupportedStyles: compact, exploded
Style/RaiseArgs:
  Enabled: false

644
# Offense count: 9
Connor Shea's avatar
Connor Shea committed
645 646
# Cop supports --auto-correct.
Style/RedundantBegin:
Rémy Coutable's avatar
Rémy Coutable committed
647 648 649 650 651 652 653 654 655 656 657 658 659 660 661
  Exclude:
    - 'app/controllers/projects/clusters/gcp_controller.rb'
    - 'app/models/merge_request.rb'
    - 'app/services/projects/import_service.rb'
    - 'lib/api/branches.rb'
    - 'lib/gitlab/current_settings.rb'
    - 'lib/gitlab/git/commit.rb'
    - 'lib/gitlab/health_checks/base_abstract_check.rb'
    - 'lib/tasks/gitlab/task_helpers.rb'

# Offense count: 1
# Cop supports --auto-correct.
Style/RedundantConditional:
  Exclude:
    - 'lib/system_check/helpers.rb'
Connor Shea's avatar
Connor Shea committed
662

663
# Offense count: 57
Connor Shea's avatar
Connor Shea committed
664 665
# Cop supports --auto-correct.
Style/RedundantFreeze:
666
  Enabled: false
Connor Shea's avatar
Connor Shea committed
667

Rémy Coutable's avatar
Rémy Coutable committed
668
# Offense count: 15
669 670 671
# Cop supports --auto-correct.
# Configuration parameters: AllowMultipleReturnValues.
Style/RedundantReturn:
Rémy Coutable's avatar
Rémy Coutable committed
672 673 674 675 676 677 678 679 680 681 682
  Exclude:
    - 'app/controllers/application_controller.rb'
    - 'app/controllers/concerns/issuable_actions.rb'
    - 'app/controllers/groups/application_controller.rb'
    - 'app/controllers/omniauth_callbacks_controller.rb'
    - 'app/controllers/profiles/keys_controller.rb'
    - 'app/controllers/projects/application_controller.rb'
    - 'app/services/access_token_validation_service.rb'
    - 'lib/gitlab/utils.rb'
    - 'lib/google_api/auth.rb'

683
# Offense count: 460
Connor Shea's avatar
Connor Shea committed
684 685 686 687
# Cop supports --auto-correct.
Style/RedundantSelf:
  Enabled: false

688
# Offense count: 142
Connor Shea's avatar
Connor Shea committed
689
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
690
# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
Connor Shea's avatar
Connor Shea committed
691 692
# SupportedStyles: slashes, percent_r, mixed
Style/RegexpLiteral:
693 694 695
  Enabled: true
  EnforcedStyle: mixed
  AllowInnerSlashes: false
Connor Shea's avatar
Connor Shea committed
696

697
# Offense count: 36
Connor Shea's avatar
Connor Shea committed
698 699
# Cop supports --auto-correct.
Style/RescueModifier:
700
  Enabled: false
701

702
# Offense count: 107
Rémy Coutable's avatar
Rémy Coutable committed
703 704 705 706 707 708
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: implicit, explicit
Style/RescueStandardError:
  Enabled: false

709
# Offense count: 92
Rémy Coutable's avatar
Rémy Coutable committed
710 711 712 713 714
# Cop supports --auto-correct.
# Configuration parameters: ConvertCodeThatCanStartToReturnNil.
Style/SafeNavigation:
  Enabled: false

715
# Offense count: 8
Connor Shea's avatar
Connor Shea committed
716 717
# Cop supports --auto-correct.
Style/SelfAssignment:
Rémy Coutable's avatar
Rémy Coutable committed
718 719 720 721 722 723 724 725
  Exclude:
    - 'app/models/concerns/bulk_member_access_load.rb'
    - 'app/serializers/base_serializer.rb'
    - 'app/services/notification_service.rb'
    - 'lib/api/runners.rb'
    - 'spec/features/merge_requests/diff_notes_resolve_spec.rb'
    - 'spec/features/projects/clusters/interchangeability_spec.rb'
    - 'spec/support/import_export/configuration_helper.rb'
Connor Shea's avatar
Connor Shea committed
726 727 728 729 730

# Offense count: 50
# Cop supports --auto-correct.
# Configuration parameters: AllowIfMethodIsEmpty.
Style/SingleLineMethods:
Rémy Coutable's avatar
Rémy Coutable committed
731 732
  Exclude:
    - 'lib/gitlab/ci/ansi2html.rb'
Connor Shea's avatar
Connor Shea committed
733

Rémy Coutable's avatar
Rémy Coutable committed
734
# Offense count: 66
Connor Shea's avatar
Connor Shea committed
735
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
736
# Configuration parameters: .
Connor Shea's avatar
Connor Shea committed
737 738 739 740
# SupportedStyles: use_perl_names, use_english_names
Style/SpecialGlobalVars:
  EnforcedStyle: use_perl_names

Rémy Coutable's avatar
Rémy Coutable committed
741
# Offense count: 1
Connor Shea's avatar
Connor Shea committed
742
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
743 744 745 746 747 748 749
Style/StderrPuts:
  Exclude:
    - 'config/initializers/rspec_profiling.rb'

# Offense count: 45
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
750 751
# SupportedStyles: single_quotes, double_quotes
Style/StringLiteralsInInterpolation:
752
  Enabled: false
753

754
# Offense count: 106
Connor Shea's avatar
Connor Shea committed
755 756 757 758 759 760
# Cop supports --auto-correct.
# Configuration parameters: IgnoredMethods.
# IgnoredMethods: respond_to, define_method
Style/SymbolProc:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
761
# Offense count: 9
762
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
763
# Configuration parameters: EnforcedStyle, AllowSafeAssignment.
764
# SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex
765
Style/TernaryParentheses:
Rémy Coutable's avatar
Rémy Coutable committed
766 767 768 769 770 771 772
  Exclude:
    - 'app/finders/projects_finder.rb'
    - 'app/helpers/namespaces_helper.rb'
    - 'features/support/capybara.rb'
    - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb'
    - 'spec/requests/api/pipeline_schedules_spec.rb'
    - 'spec/support/capybara.rb'
773

774
# Offense count: 17
Connor Shea's avatar
Connor Shea committed
775 776 777
# Cop supports --auto-correct.
# Configuration parameters: AllowNamedUnderscoreVariables.
Style/TrailingUnderscoreVariable:
Rémy Coutable's avatar
Rémy Coutable committed
778 779 780 781 782 783 784 785 786 787 788 789 790
  Exclude:
    - 'app/controllers/admin/background_jobs_controller.rb'
    - 'app/controllers/invites_controller.rb'
    - 'app/helpers/tab_helper.rb'
    - 'lib/backup/manager.rb'
    - 'lib/gitlab/logger.rb'
    - 'lib/gitlab/upgrader.rb'
    - 'lib/system_check/app/migrations_are_up_check.rb'
    - 'lib/system_check/incoming_email/mail_room_running_check.rb'
    - 'lib/tasks/gitlab/check.rake'
    - 'lib/tasks/gitlab/task_helpers.rb'
    - 'spec/lib/gitlab/etag_caching/middleware_spec.rb'
    - 'spec/services/quick_actions/interpret_service_spec.rb'
Connor Shea's avatar
Connor Shea committed
791

Rémy Coutable's avatar
Rémy Coutable committed
792
# Offense count: 5
Connor Shea's avatar
Connor Shea committed
793 794 795 796
# Cop supports --auto-correct.
# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
Style/TrivialAccessors:
Rémy Coutable's avatar
Rémy Coutable committed
797 798 799
  Exclude:
    - 'app/models/external_issue.rb'
    - 'app/serializers/base_serializer.rb'
800
    - 'lib/gitlab/auth/ldap/person.rb'
Rémy Coutable's avatar
Rémy Coutable committed
801
    - 'lib/system_check/base_check.rb'
Connor Shea's avatar
Connor Shea committed
802

Rémy Coutable's avatar
Rémy Coutable committed
803
# Offense count: 4
Connor Shea's avatar
Connor Shea committed
804 805
# Cop supports --auto-correct.
Style/UnlessElse:
Rémy Coutable's avatar
Rémy Coutable committed
806 807 808 809 810
  Exclude:
    - 'lib/backup/manager.rb'
    - 'lib/gitlab/project_search_results.rb'
    - 'lib/tasks/gitlab/check.rake'
    - 'spec/features/issues/award_emoji_spec.rb'
Connor Shea's avatar
Connor Shea committed
811

812
# Offense count: 31
Connor Shea's avatar
Connor Shea committed
813 814
# Cop supports --auto-correct.
Style/UnneededInterpolation:
815
  Enabled: false
Connor Shea's avatar
Connor Shea committed
816

817
# Offense count: 11
Connor Shea's avatar
Connor Shea committed
818 819
# Cop supports --auto-correct.
Style/ZeroLengthPredicate:
Rémy Coutable's avatar
Rémy Coutable committed
820 821 822 823 824 825 826 827 828 829 830
  Exclude:
    - 'app/models/deploy_key.rb'
    - 'app/models/network/commit.rb'
    - 'app/models/network/graph.rb'
    - 'app/models/project_services/asana_service.rb'
    - 'app/services/boards/create_service.rb'
    - 'app/services/merge_requests/conflicts/list_service.rb'
    - 'lib/declarative_policy/dsl.rb'
    - 'lib/extracts_path.rb'
    - 'lib/gitlab/git/repository.rb'

831
# Offense count: 22840
Rémy Coutable's avatar
Rémy Coutable committed
832 833 834 835
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
Metrics/LineLength:
  Max: 1310