Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • macchiato macchiato
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 53
    • Issues 53
    • List
    • Boards
    • Service Desk
    • Milestones
    • Requirements
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Insights
    • Issue
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Jeremy W. Sherman
  • macchiatomacchiato
  • Issues
  • #62
Closed
Open
Created Feb 08, 2017 by Jeremy W. Sherman@jeremy-wOwner

One post with failed parsing should not break rendering all other posts

A post response like this broke Macchiato and Cappuccino the other day, thanks to how is_visible: false shakes out:

{
  "meta": {
    "code": 200,
    "server": "16.163"
  },
  "data": [
    {
      "id": 111724,
      "is_visible": false,
      "is_muted": false,
      "is_deleted": false
    }
  ]
}

Verify that:

  • we can handle and display that – note that it has no content or author???, so we'll need to supply our own default! – and that
  • our post parsing allows to fail one post without failing the whole lot of them. Prefer to load content vs throw it all away because one nit was off!

Note that Cappuccino displays it as a big "Post Is Private" block without any other info. Example private post here.

Assignee
Assign to
Time tracking