Regression in collinear-normal toy
The collinear-normal
toy is no longer working. As shown in the pictures below, the lines are not normal to one of the curves and the intersection points also do not lie on the curve.
good | bad |
---|---|
The regression was introduced in commit 7d345c62:
sbasis-to-bezier. Due to rev 2122, use higher order error calc, see http://inkscape.13.x6.nabble.com/Recent-change-to-ellipse-to-path-conversion-method-tp4968499p4968824.html
- if(tail_error(B, 2) < tol || sbasis_size(B) == 2) { // nearly cubic enough
+ if(tail_error(B, 3) < tol || sbasis_size(B) == 2) { // nearly cubic enough
Reverting this change also fixes the issue on master, so fortunately there is only one layer of breakage.