Evaluate if `_win32_set_inkscape_env` is still required
The function _win32_set_inkscape_env()
was dropped along with some other platform-specific code during the rewrite of main.cpp in db05b842.
We need to investigate which of the following parts of this function are still required and re-implement them:
-
add inkscape directory to DLL search path so dynamically linked extension modules find their libraries using SetDllDirectoryW()
✔ still required,needs to be re-implementedre-implemented in 96117fe9 -
add inkscape directory to PATH
✔ actually done on Windows somehow, but desirable across OSs, soshould be re-implemented independent of OS.implemented in 4eb1edd5 and works for Linux, Mac and Windows. -
set INKSCAPE_LOCALEDIR
(might be required to allow for localization of Python extensions)
✖ not required, Python gettext finds locale properly without it. (INKSCAPE_LOCALEDIR
still works as expected but should be set through the parent process) -
some cryptic call of SetErrorMode()
("prevent "please insert disk" messages. fixes bug #950781")
✖ does not seem to be required anymore, issue not reproduced
Edited by Jonathan Neuhauser