-
Daniel Boles authored
commit 7cff5df2 (HEAD -> djb_desktop_events) Author: Daniel Boles <dboles.src+inkscape@gmail.com> Date: Wed Sep 6 17:15:00 2023 +0100 Desktop|InkscapeWindow: Reduce GdkEvent dependency …by consolidating the WindowStateEvent in InkscapeWindow, & just having that pass the 2 data we care about to the Desktop; by replacing the use of ::focus-in-event with notify::is-active. During migration to GTK4 we can basically just replace a signal and type as now commented. Make the method private and non-virtual because it had no reason to be otherwise & replace uses of the GLib typedef `gchar` w/ just `char`. Make getters const-correct, dodge raw `new` in favor of `make_unique()`, & rm a GTK4 TODO I think is wrong as there fewer classes will derive from GtkButton commit 81151551 Author: Daniel Boles <dboles.src+inkscape@gmail.com> Date: Wed Sep 6 15:13:59 2023 +0100 Fix overflow of INVALID MessageId to the type used lpe-ellipse_5pts was declaring a constant value INVALID of greater than 32 bits, which is all that `unsigned long int` is required to be in C++, and it was not specifies as an unsigned literal either, so in some cases e.g. a Windows (I think!) pipeline I saw, it can cause overflow warning. Fix that by just using std::optional and having nullopt indicate the invalid state, but also update the typedef of MessageId to explicitly be std::uint_least_32t, so we are very clear about the min bits we expect. Also, make the class/methods final, and be more obvious than the IIFE, which I don't see adding anything useful here, just needing commented. Finally, =delete members publicly, in case that leads to a better error. commit ee0caa83 Author: Daniel Boles <dboles.src+inkscape@gmail.com> Date: Wed Sep 6 14:41:41 2023 +0100 desktop: Remove unused signal fixing existing TODO and remove now-unused forward-decls of GdkEventAny and `CHECK IF USED` comments that clearly are used