Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • inkscape inkscape
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 1,542
    • Issues 1,542
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 141
    • Merge requests 141
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • InkscapeInkscape
  • inkscapeinkscape
  • Merge requests
  • !717

Check knot still exists before updating

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nathan Lee requested to merge nathanal/inkscape:patternextended into master Jun 07, 2019
  • Overview 1
  • Commits 2
  • Pipelines 2
  • Changes 3

Constantly. Its a light check, so hopefully the overhead isn't noticeable.

It checks every time the knots need to be updated and will remove them if they are invalid. This only applies to pattern knots right now (though it leaves all knots open to having a check).

This is two separate commits. The second just makes the Pattern Knot Entity classes derive from an new inbetween Pattern Knot Entity class.

This is an extension of a quick and dirty patch to fix #70 (closed) (removing the pattern leads to a crash if pattern knots are present)


WIP/update

The more I look at it, the more appropriate a connection seems to be.

Update: but I can't see how to do this without including knot_missing in some way
Update: To check: if knotholders only link to one pattern at a time (and LPEs, etc. separately), I'll be wrong (since we can attach signals)

Edited Dec 18, 2021 by Adam Belis
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: patternextended